Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034082Retail ModulesWeb POSpublic2016-09-26 07:542017-03-15 20:18
Reporterguillermogil 
Assigned Tojorgewederago 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034082: Modify Services not returnables functionality to allow any kind of product as not returnable.
DescriptionModify Services not returnables functionality to allow any kind of product as not returnable.
Steps To ReproduceN/A
Proposed SolutionReview Returnable Services in order to extend that functionality.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0031632 closed aaroncalero Retail Modules It would be nice to implement Services functionality in WebPOS 
causes defect 0034974 closed collazoandy4 Openbravo ERP new eclipse warning 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-26 07:54guillermogilNew Issue
2016-09-26 07:54guillermogilAssigned To => guillermogil
2016-09-26 07:54guillermogilTriggers an Emergency Pack => No
2016-09-26 07:54guillermogilFile Added: returns.diff
2016-09-26 07:54guillermogilFile Added: posterminal.diff
2016-09-26 07:54guillermogilFile Added: core.diff
2016-09-26 07:55guillermogilRelationship addedrelated to 0031632
2016-10-05 07:15guillermogilAssigned Toguillermogil => jorgewederago
2016-11-02 16:24jorgewederagoFile Added: coreReturnableProducts.diff
2016-11-02 16:25jorgewederagoFile Added: posTerminalReturnableProducts.diff
2016-11-02 16:25jorgewederagoFile Added: returnsReturnableProduct.diff
2016-11-02 16:26jorgewederagoFile Deleted: returns.diff
2016-11-02 16:26jorgewederagoFile Deleted: posterminal.diff
2016-11-02 16:26jorgewederagoFile Deleted: core.diff
2017-01-03 08:20guillermogilFile Deleted: coreReturnableProducts.diff
2017-01-03 08:20guillermogilFile Deleted: posTerminalReturnableProducts.diff
2017-01-03 08:20guillermogilFile Deleted: returnsReturnableProduct.diff
2017-01-11 11:18hgbotCheckin
2017-01-11 11:18hgbotNote Added: 0093328
2017-01-11 11:18hgbotStatusnew => resolved
2017-01-11 11:18hgbotResolutionopen => fixed
2017-01-11 11:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/eaf6bf66e5b92320caaf80eaa2a07d3450168b5a [^]
2017-01-11 11:18hgbotCheckin
2017-01-11 11:18hgbotNote Added: 0093329
2017-01-11 11:18hgbotCheckin
2017-01-11 11:18hgbotNote Added: 0093330
2017-01-11 11:18hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/eaf6bf66e5b92320caaf80eaa2a07d3450168b5a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d285b1c1480473bccd3da44ad777667828447436 [^]
2017-01-11 11:19hgbotCheckin
2017-01-11 11:19hgbotNote Added: 0093331
2017-01-11 11:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d285b1c1480473bccd3da44ad777667828447436 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ccea078ea9af95e2d0c73c36e489e42fba991af2 [^]
2017-01-11 11:19hgbotCheckin
2017-01-11 11:19hgbotNote Added: 0093332
2017-01-11 11:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ccea078ea9af95e2d0c73c36e489e42fba991af2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3269e1418373aa71e59b97aa5cdb572b229be681 [^]
2017-01-11 11:21hgbotCheckin
2017-01-11 11:21hgbotNote Added: 0093333
2017-01-11 11:21hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3269e1418373aa71e59b97aa5cdb572b229be681 [^] => http://code.openbravo.com/erp/devel/pi/rev/1d69491419cc0a909d2ca8ef93e4b3284d93f4cb [^]
2017-01-11 11:21hgbotCheckin
2017-01-11 11:21hgbotNote Added: 0093334
2017-01-11 11:21hgbotCheckin
2017-01-11 11:21hgbotNote Added: 0093335
2017-01-11 11:22hgbotCheckin
2017-01-11 11:22hgbotNote Added: 0093336
2017-01-11 11:22hgbotCheckin
2017-01-11 11:22hgbotNote Added: 0093337
2017-01-11 11:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1d69491419cc0a909d2ca8ef93e4b3284d93f4cb [^] => http://code.openbravo.com/erp/devel/pi/rev/5b206910eb992e2f91394c2cea5166617980c894 [^]
2017-01-11 11:23hgbotCheckin
2017-01-11 11:23hgbotNote Added: 0093338
2017-01-11 15:37jorgewederagoReview Assigned To => marvintm
2017-01-11 17:26marvintmStatusresolved => closed
2017-01-11 17:26marvintmFixed in Version => RR17Q2
2017-01-17 08:28alostaleRelationship addedcauses 0034974
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095081
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095082
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095083
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095084
2017-03-15 20:18hudsonbotCheckin
2017-03-15 20:18hudsonbotNote Added: 0095085

Notes
(0093328)
hgbot   
2017-01-11 11:18   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: eaf6bf66e5b92320caaf80eaa2a07d3450168b5a
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Dec 14 10:00:34 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/eaf6bf66e5b92320caaf80eaa2a07d3450168b5a [^]

Fixed issue 34082
Returnable services structure has been used to extend the functionality and have returnable products

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0093329)
hgbot   
2017-01-11 11:18   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: e6f0f4110959867aacb91626adbd443ea5a90bd2
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Dec 14 11:35:47 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/e6f0f4110959867aacb91626adbd443ea5a90bd2 [^]

Related to issue 34082: Beautifier applied

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0093330)
hgbot   
2017-01-11 11:18   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d285b1c1480473bccd3da44ad777667828447436
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Dec 14 10:02:08 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d285b1c1480473bccd3da44ad777667828447436 [^]

Fixed issue 34082
Returnable services structure has been used to extend the functionality and have returnable products

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0093331)
hgbot   
2017-01-11 11:19   
Repository: erp/pmods/org.openbravo.retail.returns
Changeset: ccea078ea9af95e2d0c73c36e489e42fba991af2
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Jan 11 11:12:13 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/ccea078ea9af95e2d0c73c36e489e42fba991af2 [^]

Fixed Issue 34082: Merge
> Merge with the development branch for returnable products functionality

---
M web/org.openbravo.retail.returns/js/modalReturnLines.js
---
(0093332)
hgbot   
2017-01-11 11:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3269e1418373aa71e59b97aa5cdb572b229be681
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Jan 11 11:10:34 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3269e1418373aa71e59b97aa5cdb572b229be681 [^]

Fixed Issue 34082: Merge
Merge with the development branch for returnable products functionality

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
---
(0093333)
hgbot   
2017-01-11 11:21   
Repository: erp/devel/pi
Changeset: 1d69491419cc0a909d2ca8ef93e4b3284d93f4cb
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Dec 14 10:02:22 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1d69491419cc0a909d2ca8ef93e4b3284d93f4cb [^]

Fixed issue 34082
Returnable services structure has been used to extend the functionality and have returnable products

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/M_OFFER_TYPE.xml
M src/org/openbravo/common/actionhandler/RFCServiceReturnableActionHandler.java
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
M src/org/openbravo/erpCommon/ad_actionButton/RMInsertOrphanLine.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
---
(0093334)
hgbot   
2017-01-11 11:21   
Repository: erp/devel/pi
Changeset: 0927675f0e3f570dcd8ed3887e93bd8a59429035
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Tue Jan 03 09:09:12 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/0927675f0e3f570dcd8ed3887e93bd8a59429035 [^]

Related to issue 34082: Missing file added

---
A src/org/openbravo/materialmgmt/ProductPriceUtils.java
---
(0093335)
hgbot   
2017-01-11 11:21   
Repository: erp/devel/pi
Changeset: 351c22471a3446c900b60d8e68752bdd34f6c34f
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Jan 04 12:34:19 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/351c22471a3446c900b60d8e68752bdd34f6c34f [^]

Related to issue 34082: Missing copyright added

---
M src/org/openbravo/materialmgmt/ProductPriceUtils.java
---
(0093336)
hgbot   
2017-01-11 11:22   
Repository: erp/devel/pi
Changeset: 5b5b3b81aa1275265dfb7dcb78222516e33c213b
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Jan 09 12:03:41 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5b5b3b81aa1275265dfb7dcb78222516e33c213b [^]

Related to issue 34082: Code review improvements

N1: Renamed serviceProduct --> product
C6: Javadoc for new method now describes products (and not only services)
C6: Javadoc for old method now points to the new one
G35: Order Date is truncated to day of month instead of formatting and then getting the date

---
M src/org/openbravo/materialmgmt/ProductPriceUtils.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
---
(0093337)
hgbot   
2017-01-11 11:22   
Repository: erp/devel/pi
Changeset: 5b206910eb992e2f91394c2cea5166617980c894
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Jan 11 11:14:00 2017 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5b206910eb992e2f91394c2cea5166617980c894 [^]

Fixed Issue 34082: Merge
> Merge with the development branch for returnable products functionality

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/M_OFFER_TYPE.xml
M src/org/openbravo/common/actionhandler/RFCServiceReturnableActionHandler.java
M src/org/openbravo/common/actionhandler/SRMOPickEditLines.java
M src/org/openbravo/erpCommon/ad_actionButton/RMInsertOrphanLine.java
M src/org/openbravo/materialmgmt/ServicePriceUtils.java
A src/org/openbravo/materialmgmt/ProductPriceUtils.java
---
(0093338)
hgbot   
2017-01-11 11:23   
Repository: tools/automation/pi-mobile
Changeset: f4b94fe464d58b985b2945fdc609b80e75f4bb4a
Author: Jorge Wederago <jorge.wederago <at> openbravo.com>
Date: Wed Jan 11 11:16:48 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f4b94fe464d58b985b2945fdc609b80e75f4bb4a [^]

Related to issue 34082: Non returnable products test case

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/returns/VerifyNotReturnableProduct.java
---
(0095081)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095082)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095083)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095084)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test
(0095085)
hudsonbot   
2017-03-15 20:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^]
Maturity status: Test