Openbravo Issue Tracking System - Retail Modules
View Issue Details
0034081Retail ModulesWeb POSpublic2016-09-25 14:522016-09-27 18:44
mtaal 
mtaal 
normalminorhave not tried
closedfixed 
5
 
RR16Q4RR16Q4 
Sandrahuguet
No
0034081: Data customer/address save: remove code which is never used
The data customer and address save js files have some code which is never used and can be removed.

datacustomeraddrsave.js has the variable customerAddrListToChange and its usage, it is only set but never used, its declaration and usage ([1]) can be removed

datacustomersave.js: has the variable customersListToChange ([2]) which is never used, it can be removed.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b09d17f57c4b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l30 [^]

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b09d17f57c4b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l30 [^]
Load webpos
check the full source code for the above variables
No tags attached.
Issue History
2016-09-25 14:52mtaalNew Issue
2016-09-25 14:52mtaalAssigned To => mtaal
2016-09-25 14:52mtaalTriggers an Emergency Pack => No
2016-09-26 15:55mtaalReview Assigned To => Sandrahuguet
2016-09-26 15:56hgbotCheckin
2016-09-26 15:56hgbotNote Added: 0090270
2016-09-26 15:56hgbotStatusnew => resolved
2016-09-26 15:56hgbotResolutionopen => fixed
2016-09-26 15:56hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f27fd70782c915d434ec2e33d0ee73705d5dc1a8 [^]
2016-09-27 18:44SandrahuguetNote Added: 0090310
2016-09-27 18:44SandrahuguetStatusresolved => closed
2016-09-27 18:44SandrahuguetFixed in Version => RR16Q4

Notes
(0090270)
hgbot   
2016-09-26 15:56   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: f27fd70782c915d434ec2e33d0ee73705d5dc1a8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Sep 26 15:55:39 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f27fd70782c915d434ec2e33d0ee73705d5dc1a8 [^]

Fixes issue 34081: Data customer/address save: remove code which is never used
Removed not-used code

---
M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js
M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js
---
(0090310)
Sandrahuguet   
2016-09-27 18:44   
Reviewed and tested