Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034075Retail ModulesFilter by stock in product searchpublic2016-09-23 13:572016-10-26 19:02
Reporterasiermartirena 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034075: [SER-QA 1810] Having stockcriteria, when a product search fails, can show wrong error messages
DescriptionHaving the stockcriteria module installed, when an user tries to search for products and the process fails due to a reason different to not having connection (for example because the user doesn't have access to something), the error message displayed is not correct in some cases.
Steps To ReproduceEnable remote preference for products.
Login Web POS.
Search for products. During this search force or configure in order to throw an exception.
The Web POS shows a message telling that the user must be online to get the stock.
Proposed Solution
Additional Information
TagsSER-QA
Relationships
Attached Filesdiff Issue_34075_MobileCore.diff (5,477) 2016-09-26 09:57
https://issues.openbravo.com/file_download.php?file_id=9854&type=bug
diff Issue_34075_StockCriteria.diff (1,032) 2016-09-26 09:57
https://issues.openbravo.com/file_download.php?file_id=9855&type=bug
diff issue_34075.diff (2,413) 2016-10-24 18:24
https://issues.openbravo.com/file_download.php?file_id=9949&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-23 13:57asiermartirenaNew Issue
2016-09-23 13:57asiermartirenaAssigned To => asiermartirena
2016-09-23 13:57asiermartirenaTriggers an Emergency Pack => No
2016-09-26 09:57asiermartirenaFile Added: Issue_34075_MobileCore.diff
2016-09-26 09:57asiermartirenaFile Added: Issue_34075_StockCriteria.diff
2016-09-26 10:03asiermartirenaResolution time => 1476050400
2016-09-26 10:03asiermartirenaAssigned Toasiermartirena => Retail
2016-09-26 10:03asiermartirenaSummaryHaving stockcriteria, when a product search fails, can show wrong error messages => [SER-QA 1810] Having stockcriteria, when a product search fails, can show wrong error messages
2016-09-26 10:04asiermartirenaTag Attached: SER-QA
2016-09-27 11:33ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-09-27 11:33ranjith_qualiantech_comStatusnew => scheduled
2016-10-17 15:16hgbotCheckin
2016-10-17 15:16hgbotNote Added: 0090640
2016-10-18 04:38hgbotCheckin
2016-10-18 04:38hgbotNote Added: 0090653
2016-10-18 04:38hgbotStatusscheduled => resolved
2016-10-18 04:38hgbotResolutionopen => fixed
2016-10-18 04:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/162aa3a84fb138f4a3ae1b493f5f83b0a3928628 [^]
2016-10-24 12:13marvintmReview Assigned To => marvintm
2016-10-24 12:13marvintmStatusresolved => closed
2016-10-24 12:39marvintmNote Added: 0090815
2016-10-24 12:39marvintmStatusclosed => new
2016-10-24 12:39marvintmResolutionfixed => open
2016-10-24 18:24marvintmFile Added: issue_34075.diff
2016-10-25 08:32ranjith_qualiantech_comStatusnew => scheduled
2016-10-25 15:36hgbotCheckin
2016-10-25 15:36hgbotNote Added: 0090870
2016-10-25 15:36hgbotStatusscheduled => resolved
2016-10-25 15:36hgbotResolutionopen => fixed
2016-10-25 15:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/162aa3a84fb138f4a3ae1b493f5f83b0a3928628 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/034e07390d302f83e5c7fa0e311edfeab3e2033d [^]
2016-10-26 19:02hgbotCheckin
2016-10-26 19:02hgbotNote Added: 0090932
2016-10-26 19:02marvintmStatusresolved => closed

Notes
(0090640)
hgbot   
2016-10-17 15:16   
Repository: erp/pmods/org.openbravo.retail.stockcriteria
Changeset: a75620cf146d6dbc7094d638dda8a7eef674db22
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 17 18:43:40 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockcriteria/rev/a75620cf146d6dbc7094d638dda8a7eef674db22 [^]

Related to issue 34075 : Added AD Message inorder to show proper msg for stock validation

---
M web/org.openbravo.retail.stockcriteria/js/hookPostFailureRemoteProductSearch.js
---
(0090653)
hgbot   
2016-10-18 04:38   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 162aa3a84fb138f4a3ae1b493f5f83b0a3928628
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 17 18:46:17 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/162aa3a84fb138f4a3ae1b493f5f83b0a3928628 [^]

Fixes issue 34075 : Added AD Message to show proper message in Product Charateristics search

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0090815)
marvintm   
2016-10-24 12:39   
Currently there is a flow which enters an infinite loop. To reproduce it follow these steps:
- Configure local masterdata (not remote).
- Install stock criteria module.
- Log in the Web POS. Search without filters. It works correctly.
- Then search with stock filter. Works correctly also.
- Go offline. Search with stock filter. It should fail, and should not try to search in local (as its impossible to do the proper search with the stock filter enabled). However, even though it fails, it then retries the remote search infinitely, and the browser eventually fails.
(0090870)
hgbot   
2016-10-25 15:36   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 034e07390d302f83e5c7fa0e311edfeab3e2033d
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Oct 25 19:06:26 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/034e07390d302f83e5c7fa0e311edfeab3e2033d [^]

Fixes issue 34075 : Added stock validation for product search if the pos is offline

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---
(0090932)
hgbot   
2016-10-26 19:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ec6bf1d63827b011f491e1b91ccee18cdd71cd78
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Oct 26 19:01:48 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ec6bf1d63827b011f491e1b91ccee18cdd71cd78 [^]

Related to issue 34075. Ensure proper message is shown if an uncaught exception happens in the backend.

---
M web/org.openbravo.mobile.core/source/retail/component/ob-retail-searchproductcharacteristic.js
---