Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034068Openbravo ERP04. Warehouse managementpublic2016-09-23 10:372016-10-13 11:31
Reporterngarcia 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket43689
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034068: Stock valuation is updated to 0 when the stock if 0 by the Reset Unit Cost process but not by Costing Background Process
DescriptionStock valuation is updated to 0 when the stock if 0 by the Reset Unit Cost process but not by Costing Background Process
Steps To ReproduceAs system admin role:
   Set Cost Precision of the currency to 6
As group admin role:
   Set the following two preferences as Y:
      Allow to persist Unit Cost
      Enable Negative Stock Corrections
   Create a new product
   Create a physical inventory and add the previously created product:
      Quantity count: 19
      Cost: 26.24069
   Create two Goods Shipments: one of 10 units and one of 9 units
   Launch the Costing Background Process
   Check the Stock Valuation is -0.01 in Product - Unit Cost tab
   Launch the Reset Unit Cost process and check the stock valuation is updated to 0
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034056 closed markmm82 Wrong stock in Unit Cost tab of Product window 
blocks defect 0034055 closed markmm82 Wrong cost adjustment is made when stock reaches 0 but stock valuation is not 0 due to rounding issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-23 10:37ngarciaNew Issue
2016-09-23 10:37ngarciaAssigned To => Triage Finance
2016-09-23 10:37ngarciaOBNetwork customer => Yes
2016-09-23 10:37ngarciaModules => Core
2016-09-23 10:37ngarciaSupport ticket => 43689
2016-09-23 10:37ngarciaResolution time => 1476309600
2016-09-23 10:37ngarciaTriggers an Emergency Pack => No
2016-09-23 10:38ngarciaRelationship addedrelated to 0034056
2016-09-23 10:38ngarciaIssue Monitored: networkb
2016-09-28 12:38aferrazAssigned ToTriage Finance => markmm82
2016-09-29 16:41markmm82Statusnew => scheduled
2016-09-29 21:31markmm82Note Added: 0090392
2016-09-30 12:43hgbotCheckin
2016-09-30 12:43hgbotNote Added: 0090423
2016-09-30 12:43hgbotStatusscheduled => resolved
2016-09-30 12:43hgbotResolutionopen => fixed
2016-09-30 12:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/79f4c2e75d1f874ec5a411aec95586c139f995ef [^]
2016-09-30 12:46aferrazReview Assigned To => aferraz
2016-09-30 12:46aferrazNote Added: 0090425
2016-09-30 12:46aferrazStatusresolved => closed
2016-09-30 12:46aferrazFixed in Version => 3.0PR16Q4
2016-09-30 14:08hgbotCheckin
2016-09-30 14:08hgbotNote Added: 0090427
2016-09-30 14:08aferrazNote Deleted: 0090425
2016-09-30 14:08aferrazNote Added: 0090429
2016-09-30 19:07hudsonbotCheckin
2016-09-30 19:07hudsonbotNote Added: 0090448
2016-09-30 19:07hudsonbotCheckin
2016-09-30 19:07hudsonbotNote Added: 0090449
2016-10-10 18:54aferrazRelationship addedblocks 0034055
2016-10-11 15:16hgbotCheckin
2016-10-11 15:16hgbotNote Added: 0090534
2016-10-13 11:31hudsonbotCheckin
2016-10-13 11:31hudsonbotNote Added: 0090552

Notes
(0090392)
markmm82   
2016-09-29 21:31   
Test Plan
As system admin role:
   Set Cost Precision of the currency (i.e EUR) to 6
As group admin role:
   Set the following two preferences as Y:
      Allow to persist Unit Cost
      Enable Negative Stock Corrections
   Create a new product
   Create a physical inventory and add the previously created product:
      Quantity count: 19
      Cost: 26.24069
   Create two Goods Shipments: one of 10 units and one of 9 units
   Launch the Costing Background Process
   Check the Stock Valuation is 0.00 in Product - Unit Cost tab. It is correct
   Launch the Reset Unit Cost process and check the stock valuation remains 0
(0090423)
hgbot   
2016-09-30 12:43   
Repository: erp/devel/pi
Changeset: 79f4c2e75d1f874ec5a411aec95586c139f995ef
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Sep 29 14:59:52 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/79f4c2e75d1f874ec5a411aec95586c139f995ef [^]

Fixes issue 34068: Stock valuation updated to 0 by cost processes if no stock

Stock valuation is updated to 0 when the stock if 0 by the Reset Unit Cost process and the Costing Background Process

---
M src-db/database/model/functions/M_UPDATE_STOCK_VALUATION.xml
---
(0090427)
hgbot   
2016-09-30 14:08   
Repository: erp/devel/pi
Changeset: 5cffde20b3b1b5b147b3072b1240dc6b81eac21e
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 30 13:09:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5cffde20b3b1b5b147b3072b1240dc6b81eac21e [^]

Related to issue 34068: Code review improvements

---
M src-db/database/model/functions/M_UPDATE_STOCK_VALUATION.xml
---
(0090429)
aferraz   
2016-09-30 14:08   
Code review + Testing OK
(0090448)
hudsonbot   
2016-09-30 19:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090449)
hudsonbot   
2016-09-30 19:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090534)
hgbot   
2016-10-11 15:16   
Repository: erp/devel/pi
Changeset: bfe0fd55340fadedae20717cb8db6b52af86be01
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Oct 11 14:42:30 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bfe0fd55340fadedae20717cb8db6b52af86be01 [^]

Related to issue 34068: Fix stock valuation

Fix stock valuation in case we are updating valuation but stock was not updated yet.
Only in case we are updating stock and it is updated to zero, valuation will be updated to zero too.

---
M src-db/database/model/functions/M_UPDATE_STOCK_VALUATION.xml
---
(0090552)
hudsonbot   
2016-10-13 11:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9b5b1cc15f9c [^]
Maturity status: Test