Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034067Openbravo ERP04. Warehouse managementpublic2016-09-23 10:142016-09-27 21:59
Reporterngarcia 
Assigned Toinigosanchez 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2016-09-08
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/b4a8ad7a445ff946888867836f3c3c80cb988f2a [^]
Triggers an Emergency PackNo
Summary0034067: No UOM Conversion Rate between UOMs found warning shown although the product does not have a 2nd UOM configured
DescriptionNo UOM Conversion Rate between UOMs found warning shown although the product does not have a 2nd UOM configured
Steps To ReproduceAs group admin role:
   Create a new product
   Add it to a Goods Receipt
   Check the following warning is shown and it should not:
      No UOM Conversion Rate between UOMs found
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by design defect 00323663.0PR16Q4 closed inigosanchez callout invocation ineficiencies 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-23 10:14ngarciaNew Issue
2016-09-23 10:14ngarciaAssigned To => Triage Finance
2016-09-23 10:14ngarciaModules => Core
2016-09-23 10:14ngarciaTriggers an Emergency Pack => No
2016-09-23 10:14ngarciaIssue Monitored: networkb
2016-09-23 12:54aferrazAssigned ToTriage Finance => platform
2016-09-23 12:56aferrazRelationship addedcaused by 0032366
2016-09-23 16:03caristuRegression level => Pre packaging ( pi )
2016-09-23 16:03caristuRegression date => 2016-09-08
2016-09-23 16:03caristuRegression introduced in release => pi
2016-09-23 16:03caristuRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/b4a8ad7a445ff946888867836f3c3c80cb988f2a [^]
2016-09-23 16:14caristuNote Added: 0090211
2016-09-26 15:58inigosanchezStatusnew => scheduled
2016-09-26 15:58inigosanchezAssigned Toplatform => inigosanchez
2016-09-27 16:27inigosanchezReview Assigned To => caristu
2016-09-27 16:28hgbotCheckin
2016-09-27 16:28hgbotNote Added: 0090304
2016-09-27 16:28hgbotStatusscheduled => resolved
2016-09-27 16:28hgbotResolutionopen => fixed
2016-09-27 16:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/65f08702a33332adc9d9bff1a5a278d8d1326487 [^]
2016-09-27 19:10caristuNote Added: 0090313
2016-09-27 19:10caristuStatusresolved => closed
2016-09-27 19:10caristuFixed in Version => 3.0PR16Q4
2016-09-27 21:59hudsonbotCheckin
2016-09-27 21:59hudsonbotNote Added: 0090314

Notes
(0090211)
caristu   
2016-09-23 16:14   
This problem is caused by the following line: https://code.openbravo.com/erp/devel/pi/file/a570fdbe9083/src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java#l327 [^]

Previously it was necessary to send the "null" value as part of the callout execution result, this way the parseCalloutResponse() of the FIC was able to retrieve the null values properly. This now is not necessary in SimpleCallouts due to its new internal implementation.
(0090304)
hgbot   
2016-09-27 16:28   
Repository: erp/devel/pi
Changeset: 65f08702a33332adc9d9bff1a5a278d8d1326487
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Tue Sep 27 16:26:36 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/65f08702a33332adc9d9bff1a5a278d8d1326487 [^]

Fixes issue 34067: No UOM Conversion Rate between UOMs found warning shown.

This problem is related with Improve performance callouts project. The problem
was related with how to manage null and "null" values.

Previously it was necessary to send the "null" value as part of the callout
execution result because StringBuilder in CalloutInfo class couldn't accept
null Objects values. Then, this way the parseCalloutResponse() of the FIC
was able to retrieve the null values properly. This now is not necessary in
SimpleCallouts due to its new internal implementation.

It have been resolved this problem by sending null Object as part of the
callout execution result in both cases: When a "null" String or null
Object is recieved. Now the problem it has fixed and the null and "null"
values are managing properly.

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
M src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java
---
(0090313)
caristu   
2016-09-27 19:10   
Verified
(0090314)
hudsonbot   
2016-09-27 21:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/673f645f2c5e [^]
Maturity status: Test