Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034058Retail ModulesWeb POSpublic2016-09-22 14:042016-11-24 12:52
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression levelProduction - Confirmed Stable
Regression date
Regression introduced in releaseRR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09dc9563011a [^]
Triggers an Emergency PackNo
Summary0034058: If deleteCurrent function forces to create a new order the document Sequence is wrongly generated
DescriptionIf deleteCurrent function (OB.MobileApp.model.orderlist.deleteCurrent(true)) forces to create a new order the document Sequence is wrongly generated.
It is not taking into account the new orderList order when it is adding the new order to the orderList.
Steps To ReproduceLogin on WebPOS
Add a product
New ticket
Add a product
New ticket
Add a product
Set the following command on the console:
OB.MobileApp.model.orderList.deleteCurrent(true);
Set the following command on the console:
OB.MobileApp.model.orderList.deleteCurrent(true);

You will see that on the orderList are several document numbers wrong
Proposed SolutionSee attached diff
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034069RR16Q3.3 closed jorge-garcia If deleteCurrent function forces to create a new order the document Sequence is wrongly generated 
depends on backport 0034070RR16Q2.4 closed Retail If deleteCurrent function forces to create a new order the document Sequence is wrongly generated 
Attached Filesdiff forceNewTicketCreation.diff (565) 2016-09-22 14:05
https://issues.openbravo.com/file_download.php?file_id=9847&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-22 14:04guillermogilNew Issue
2016-09-22 14:04guillermogilAssigned To => Retail
2016-09-22 14:04guillermogilOBNetwork customer => Yes
2016-09-22 14:04guillermogilResolution time => 1474840800
2016-09-22 14:04guillermogilRegression level => Production - Confirmed Stable
2016-09-22 14:04guillermogilRegression introduced in release => RR16Q2
2016-09-22 14:04guillermogilRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09dc9563011a [^]
2016-09-22 14:04guillermogilTriggers an Emergency Pack => No
2016-09-22 14:05guillermogilFile Added: forceNewTicketCreation.diff
2016-09-22 14:36guillermogilSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13161#r13161
2016-09-22 14:55lorenzofidalgoPriorityurgent => immediate
2016-09-23 10:47jorge-garciaStatusnew => scheduled
2016-09-23 10:47jorge-garciaAssigned ToRetail => jorge-garcia
2016-09-28 11:50hgbotCheckin
2016-09-28 11:50hgbotNote Added: 0090343
2016-09-28 11:50hgbotStatusscheduled => resolved
2016-09-28 11:50hgbotResolutionopen => fixed
2016-09-28 11:50hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b57385efc7794027cd79ad0f954a0e4525265e20 [^]
2016-09-28 11:50hgbotCheckin
2016-09-28 11:50hgbotNote Added: 0090344
2016-09-30 13:16marvintmReview Assigned To => marvintm
2016-09-30 13:16marvintmStatusresolved => closed
2016-11-11 08:49hgbotCheckin
2016-11-11 08:49hgbotNote Added: 0091352
2016-11-11 08:50hgbotCheckin
2016-11-11 08:50hgbotNote Added: 0091360
2016-11-11 08:51hgbotCheckin
2016-11-11 08:51hgbotNote Added: 0091364
2016-11-11 08:51hgbotStatusclosed => resolved
2016-11-11 08:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b57385efc7794027cd79ad0f954a0e4525265e20 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/7c08268959f6bc11a90cd19a82689e3c5af5940d [^]
2016-11-11 08:52hgbotCheckin
2016-11-11 08:52hgbotNote Added: 0091369
2016-11-11 14:24migueldejuanaReview Assigned Tomarvintm => migueldejuana
2016-11-11 14:24migueldejuanaNote Added: 0091401
2016-11-11 14:24migueldejuanaStatusresolved => closed
2016-11-16 09:36lorenzofidalgoSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13764#r13764
2016-11-21 16:30hgbotCheckin
2016-11-21 16:30hgbotNote Added: 0091710
2016-11-21 19:15hgbotCheckin
2016-11-21 19:15hgbotNote Added: 0091721
2016-11-24 12:52hgbotCheckin
2016-11-24 12:52hgbotNote Added: 0091778

Notes
(0090343)
hgbot   
2016-09-28 11:50   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b57385efc7794027cd79ad0f954a0e4525265e20
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 23 11:17:23 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b57385efc7794027cd79ad0f954a0e4525265e20 [^]

Fixed issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

If the creation of a new order is forced, the sequence number must be updated
correctly.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0090344)
hgbot   
2016-09-28 11:50   
Repository: tools/automation/pi-mobile
Changeset: fe18f0fdae2acf4fd56120ccdbade18f301ddd4a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fe18f0fdae2acf4fd56120ccdbade18f301ddd4a [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---
(0091352)
hgbot   
2016-11-11 08:49   
Repository: retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal
Changeset: fda289a0a3c41e7061cad2610c9c93e9f8e677dd
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 23 11:17:23 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/org.openbravo.retail.posterminal/rev/fda289a0a3c41e7061cad2610c9c93e9f8e677dd [^]

Fixed issue 34070, backport of issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

If the creation of a new order is forced, the sequence number must be updated
correctly.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091360)
hgbot   
2016-11-11 08:50   
Repository: retail/backports/3.0RR16Q2.4/pi-mobile
Changeset: f9f5fe09439c19e9f338839687697e42bf69050e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/pi-mobile/rev/f9f5fe09439c19e9f338839687697e42bf69050e [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---
(0091364)
hgbot   
2016-11-11 08:51   
Repository: retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal
Changeset: 7c08268959f6bc11a90cd19a82689e3c5af5940d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 23 11:17:23 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/org.openbravo.retail.posterminal/rev/7c08268959f6bc11a90cd19a82689e3c5af5940d [^]

Fixed issue 34058, backport of issue 34069: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

If the creation of a new order is forced, the sequence number must be updated
correctly.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0091369)
hgbot   
2016-11-11 08:52   
Repository: retail/backports/3.0RR16Q3.3/pi-mobile
Changeset: fde1171803762f3453b8f29712dc99ea0ce65c3b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.3/pi-mobile/rev/fde1171803762f3453b8f29712dc99ea0ce65c3b [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---
(0091401)
migueldejuana   
2016-11-11 14:24   
Tested and reviewed
(0091710)
hgbot   
2016-11-21 16:30   
Repository: retail/backports/3.0RR16Q2.4/pi-mobile
Changeset: f9f5fe09439c19e9f338839687697e42bf69050e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.4/pi-mobile/rev/f9f5fe09439c19e9f338839687697e42bf69050e [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---
(0091721)
hgbot   
2016-11-21 19:15   
Repository: tools/automation/pi-mobile
Changeset: f9f5fe09439c19e9f338839687697e42bf69050e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f9f5fe09439c19e9f338839687697e42bf69050e [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/common/selenium/javascript/TestId.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---
(0091778)
hgbot   
2016-11-24 12:52   
Repository: tools/automation/pi-mobile
Changeset: fde1171803762f3453b8f29712dc99ea0ce65c3b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 27 11:39:57 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fde1171803762f3453b8f29712dc99ea0ce65c3b [^]

Verifies issue 34058: If deleteCurrent function forces to create a new order
the document Sequence is wrongly generated

Added test I34058_WrongDocSequenceWithDeleteCurrent.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/documentno/I34058_WrongDocSequenceWithDeleteCurrent.java
---