Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034057Openbravo ERPA. Platformpublic2016-09-22 13:132016-12-16 18:38
Reporternataliag 
Assigned ToNaroaIriarte 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034057: Wrong Tabulation Order in form fields in Organization window
DescriptionWhen you try to use tabulation in the Organization window using the form view and starting in "Search Key" field instead of jumping to next field(Name), it goes to the tab below (Information).
Steps To Reproduce1- Login in the application and go to "Organization" window.
2- Select one of the records and open it using the "click to open the record in a form" button.
3- Press tab button. The tab focus disappears.
4- Press again tab button. Now the tabulator is in the lower tab,"Information".
5- Pressing again the tab button, it returns up, to the "Name" field.
6- If you continue tabulating, in the rest of fields it goes well until pressing the tab button after the tabulator being in audit section. Then there are some strange behaviors again.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034051 closed NaroaIriarte Wrong Tabulation Order in form fields 
related to defect 0021380 closed alostale When the first focus field is a drop down list, the content of the field should be selected 
related to defect 0021381 closed dbaz Focus is lost after a record is saved in form view, resulting in incorrect operation of keyboards 
related to defect 0021420 closed dbaz [KS] CTRL+O does not consistently work 
related to defect 00223903.0MP19 closed AugustoMauch Tab key does not work correctly in grid view 
related to defect 00221233.0MP20 closed AugustoMauch UI looses focus when entering filter in grid mode 
related to defect 0030401 acknowledged Triage Platform Base Tab Key looses focus in GL Item 
related to defect 00213073.0MP15 closed dbaz The focus oes not move for the following field from a field using a column with text reference 
related to defect 00282313.0PR15Q2 closed AugustoMauch Focus is placed automatically on the last field under some circumnstances 
related to defect 00283963.0PR15Q2 closed AugustoMauch Focus is placed automatically on the field group (if any) having all the fields in read only mode 
related to defect 0029687 closed dbaz Is not possible to set the hour 12 in DateTime fields 
related to defect 00229033.0MP21 closed AugustoMauch Focus is lost when changing the images in Client window 
related to defect 0031705 closed caristu a date used to filter on a grid dissapears after enter it 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-22 13:13nataliagNew Issue
2016-09-22 13:13nataliagAssigned To => platform
2016-09-22 13:13nataliagModules => Core
2016-09-22 13:13nataliagTriggers an Emergency Pack => No
2016-09-22 13:15nataliagRelationship addedrelated to 0034051
2016-09-23 08:32caristuNote Added: 0090181
2016-09-29 09:29alostaleStatusnew => acknowledged
2016-10-10 11:12egoitzIssue Monitored: egoitz
2016-10-10 11:14egoitzResolution time => 1476914400
2016-10-13 11:56NaroaIriarteStatusacknowledged => scheduled
2016-10-13 11:56NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-10-20 18:12caristuNote Edited: 0090181bug_revision_view_page.php?bugnote_id=0090181#r13430
2016-10-20 18:12caristuNote Edited: 0090181bug_revision_view_page.php?bugnote_id=0090181#r13431
2016-10-21 12:14caristuNote Edited: 0090181bug_revision_view_page.php?bugnote_id=0090181#r13443
2016-10-21 12:52NaroaIriarteNote Added: 0090762
2016-10-24 09:17NaroaIriarteRelationship addedrelated to 0021380
2016-10-24 09:17NaroaIriarteRelationship addedrelated to 0021381
2016-10-24 09:18NaroaIriarteRelationship addedrelated to 0021420
2016-10-24 09:20NaroaIriarteRelationship addedrelated to 0022390
2016-10-24 09:31NaroaIriarteRelationship addedrelated to 0022123
2016-10-24 09:38hgbotCheckin
2016-10-24 09:38hgbotNote Added: 0090804
2016-10-24 09:38hgbotStatusscheduled => resolved
2016-10-24 09:38hgbotResolutionopen => fixed
2016-10-24 09:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/23168c38ed78f1cec09e30577356cfe1ae79193c [^]
2016-10-24 09:48NaroaIriarteRelationship addedrelated to 0030401
2016-10-24 09:52NaroaIriarteRelationship addedrelated to 0021307
2016-10-24 10:06NaroaIriarteRelationship addedrelated to 0028231
2016-10-24 10:07NaroaIriarteRelationship addedrelated to 0028396
2016-10-24 10:08NaroaIriarteRelationship addedrelated to 0029687
2016-10-24 10:13NaroaIriarteRelationship addedrelated to 0022903
2016-10-24 10:18NaroaIriarteRelationship addedrelated to 0031705
2016-10-24 11:09hgbotCheckin
2016-10-24 11:09hgbotNote Added: 0090809
2016-10-24 11:45NaroaIriarteReview Assigned To => alostale
2016-10-28 09:23alostaleNote Added: 0090977
2016-10-28 09:23alostaleStatusresolved => closed
2016-10-28 09:23alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092549
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092550

Notes
(0090181)
caristu   
2016-09-23 08:32   
(edited on: 2016-10-21 12:14)
Note that in this case the behavior regarding the first focused field when opening a record in form view using the "click to open the record in a form" button is different from the behavior when using a double-click: when using double-click the first focused element is the field where we made the double click.

For this reason, if we open the record in form view using double-click and clicking on the description field the problem is not reproducible, because the tabIndex assigned to this field is higher than the tabIndex assigned to the child tab element.

Nevertheless, by opening the record with "click to open the record in a form" or double-clicking on the search key field the problem can be reproduced as the tabIndex assigned to that field is the same as the one assigned to the child tab element.
(0090762)
NaroaIriarte   
2016-10-21 12:52   
The fix of this issue is now pushed to try.
(0090804)
hgbot   
2016-10-24 09:38   
Repository: erp/devel/pi
Changeset: 23168c38ed78f1cec09e30577356cfe1ae79193c
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Fri Oct 21 12:25:34 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/23168c38ed78f1cec09e30577356cfe1ae79193c [^]

Fixed issue 34057: The focus' behavior was not the expected.

In some windows, in form view, the focus was not working fine when using the tab key. In some cases the focus was jumping from a field to the child tab bar instead to the following focusable field, and after, to the field.

The problem was that the tabIndex of the child tab bar was the same than the tabIndex of the field which was expected to be focused.
This is caused because the tabIndex of the child tab bar is not being updated when the formitems are created, and that is the reason because the tabIndexes are overlapped.

To fix this, the "prepareViewForm" of the "ob-standard-view" class has been modified, now it forces to update the child tab bar tabIndex and it gives to it a higher value than the values of the tabIndexes of the parent elements.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090809)
hgbot   
2016-10-24 11:09   
Repository: erp/devel/pi
Changeset: 25c6ca652d57d9b0feccb1fac1e841620a8d522f
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Oct 24 11:08:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/25c6ca652d57d9b0feccb1fac1e841620a8d522f [^]

Related to issue 34057: The comment has been improved.

The comment has been improved to be clearer.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090977)
alostale   
2016-10-28 09:23   
code reviewed

tested both in form and grid views
(0092549)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092550)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test