Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034052Retail ModulesWeb POSpublic2016-08-12 09:522016-10-13 09:31
Reportermigueldejuana 
Assigned Tomigueldejuana 
PriorityhighSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q3.2Fixed in VersionRR16Q3.2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket42478
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034052: It is still possible to press twice Done or Layaway buttons
DescriptionClients like Superdoña or Laeuropea are still having this problem from time to time.
We added a enyo.$.scrim.show(); but it is not enough. We have to research and find a way to avoid this double click.
Steps To ReproduceSometimes...

- Login
- Add a product
- Add exact payment
- Press Done twice
- ERROR: 2 Orders are send, one with all attributes initialized to null
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033695 closed migueldejuana It is still possible to press twice Done or Layaway buttons 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-22 11:11migueldejuanaTypedefect => backport
2016-09-22 11:11migueldejuanaTarget Version => RR16Q3.2
2016-09-23 09:55hgbotCheckin
2016-09-23 09:55hgbotNote Added: 0090191
2016-09-23 09:55hgbotCheckin
2016-09-23 09:55hgbotNote Added: 0090192
2016-09-23 09:55hgbotStatusscheduled => resolved
2016-09-23 09:55hgbotResolutionopen => fixed
2016-09-23 09:55hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8288cc5de0f0c485a69011eceeaddd7d5ba8e55e [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal/rev/477e6bb1b1a2af653b1cf019121b70cbec5aff08 [^]
2016-09-26 23:19guilleaerStatusresolved => closed
2016-09-26 23:19guilleaerFixed in Version => RR16Q3.2
2016-10-13 09:31hgbotCheckin
2016-10-13 09:31hgbotNote Added: 0090545

Notes
(0090191)
hgbot   
2016-09-23 09:55   
Repository: retail/backports/3.0RR16Q3.2/pi-mobile
Changeset: e3205c851f0aee33c10abab9afeeb94c32664df9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 23 09:54:49 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.2/pi-mobile/rev/e3205c851f0aee33c10abab9afeeb94c32664df9 [^]

Related issue 0034052: It is still possible to press twice Done or Layaway buttons

- Add time to wait until Done button can be pressed again
- Add wait to avoid pressing Done twice in one second
- Ensure that Done button is disabled after doing a sale

---
M src-test/org/openbravo/test/mobile/common/selenium/testhelpers/TestActionsHelper.java
M src-test/org/openbravo/test/mobile/common/selenium/utils/OBConstants.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/SALa010_CreateSale.java
---
(0090192)
hgbot   
2016-09-23 09:55   
Repository: retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal
Changeset: 477e6bb1b1a2af653b1cf019121b70cbec5aff08
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 23 09:52:40 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.2/org.openbravo.retail.posterminal/rev/477e6bb1b1a2af653b1cf019121b70cbec5aff08 [^]

Fixed issue 0034052: It is still possible to press twice Done or Layaway buttons

- Block Done button during 1 second to avoid double click
- Delete current before setting to false calculateReceiptLock in order to do not trigger any receipt event when clearing the order
- Avoid calling updatePending or checkValidPayment when we are processing the receipt (after pressing Done button)
- Change message from info to error to be able to track it better

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0090545)
hgbot   
2016-10-13 09:31   
Repository: tools/automation/pi-mobile
Changeset: e3205c851f0aee33c10abab9afeeb94c32664df9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 23 09:54:49 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e3205c851f0aee33c10abab9afeeb94c32664df9 [^]

Related issue 0034052: It is still possible to press twice Done or Layaway buttons

- Add time to wait until Done button can be pressed again
- Add wait to avoid pressing Done twice in one second
- Ensure that Done button is disabled after doing a sale

---
M src-test/org/openbravo/test/mobile/common/selenium/testhelpers/TestActionsHelper.java
M src-test/org/openbravo/test/mobile/common/selenium/utils/OBConstants.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/SALa010_CreateSale.java
---