Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034051Openbravo ERPA. Platformpublic2016-09-22 11:032016-12-16 18:39
Reporternataliag 
Assigned ToNaroaIriarte 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034051: Wrong Tabulation Order in form fields
DescriptionTabulation in form views seems to prioritize fields of type image and jump to this type of fields instead of following the pertinent order.
Steps To Reproduce1- Login in the application and go to "User" window.
2- Select one of the records and open it in record form.
3- Open the "More Information" section and close the record.
4- Open again the last record in record form, now the "more information" section should appear open.
5- Tabulator is in "Name" field. Press once tab button and it changes to "Username" field.
6- Press again tabulator and you can see that it disappears. If you press enter button the image field is opened(tabulator has jump from "Username" field to "Image" field in the "More information" section).
7- Close the image popup and press tab button again. Now it returns to "First Name" field. The correct order of fields should have been: Name->Username->First Name.... But is has been: Name->Username->Image->First Name...
8- Now if you continue tabulating the order of the rest of fields is ok.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034658 closed inigosanchez The focus is lost when navigating through the "Product" window with the tab key. 
related to defect 0034057 closed NaroaIriarte Wrong Tabulation Order in form fields in Organization window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-22 11:03nataliagNew Issue
2016-09-22 11:03nataliagAssigned To => platform
2016-09-22 11:03nataliagModules => Core
2016-09-22 11:03nataliagTriggers an Emergency Pack => No
2016-09-22 13:15nataliagRelationship addedrelated to 0034057
2016-09-23 08:26caristuNote Added: 0090180
2016-09-23 08:37caristuNote Edited: 0090180bug_revision_view_page.php?bugnote_id=0090180#r13167
2016-09-23 08:37caristuNote Edited: 0090180bug_revision_view_page.php?bugnote_id=0090180#r13168
2016-09-29 09:30alostaleStatusnew => acknowledged
2016-11-15 15:24heccamIssue Monitored: heccam
2016-11-22 15:47NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-11-22 15:47NaroaIriarteStatusacknowledged => scheduled
2016-11-25 09:51hgbotCheckin
2016-11-25 09:51hgbotNote Added: 0091815
2016-11-25 09:51hgbotStatusscheduled => resolved
2016-11-25 09:51hgbotResolutionopen => fixed
2016-11-25 09:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a7f3c703cb83b402be682c7626b87c3c005a61ee [^]
2016-11-25 09:58NaroaIriarteReview Assigned To => alostale
2016-11-25 10:55alostaleNote Added: 0091822
2016-11-25 10:55alostaleStatusresolved => closed
2016-11-25 10:55alostaleFixed in Version => 3.0PR17Q1
2016-11-30 17:35NaroaIriarteRelationship addedrelated to 0034658
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092658

Notes
(0090180)
caristu   
2016-09-23 08:26   
(edited on: 2016-09-23 08:37)
After tabulating on "Username" field, the focus is acquired not by the Image field but by the upload button of the field itself.

This is happening because this button has a tabIndex which is between the tabIndex values of the Username field and the Firstname field.

The solution for this issue must set the tabIndex value properly for the button.
(0091815)
hgbot   
2016-11-25 09:51   
Repository: erp/devel/pi
Changeset: a7f3c703cb83b402be682c7626b87c3c005a61ee
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Nov 24 16:01:47 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a7f3c703cb83b402be682c7626b87c3c005a61ee [^]

Fixed issue 34051: The tab key was not focusing properly in some circumstances

The fields were not correctly focused when using the tab key. If there was an image in the form, the focus was jumping to it when it was supposed not to.
The problems seems to be in the canvas item. The tab index was not being properly set.
To fix this the "ob-formitem-image.js" has been modifyed, now, the "canFocus" property has been set to true for the image canvas.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-image.js
---
(0091822)
alostale   
2016-11-25 10:55   
code reviewed
Tested: now the focus moves correctly and it is possible to set it in icon to upload new images
(0092658)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test