Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034043Openbravo ERPA. Platformpublic2016-09-21 09:542016-09-29 23:30
Reporterinigosanchez 
Assigned Toinigosanchez 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034043: There is a restriction when extending a callout from another callout and the same combo is updated.
DescriptionThere is a restriction when extending a callout from another callout and the same combo is updated. Related with "Extend a SimpleCallout" feature [1] a restriccition is found. The problem is detected when a combo is updated in a parent callout and in the child callout is updated too (E.g. substraction a value in the combo).


[1].http://wiki.openbravo.com/wiki/How_to_create_a_callout_that_extends_from_another_callout [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 00323663.0PR16Q4 closed inigosanchez callout invocation ineficiencies 
related to defect 0033960 closed caristu "Warehouse" field goes blank when filling "Business Partner" field in a Purchase Order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-21 09:54inigosanchezNew Issue
2016-09-21 09:54inigosanchezAssigned To => inigosanchez
2016-09-21 09:54inigosanchezModules => Core
2016-09-21 09:54inigosanchezTriggers an Emergency Pack => No
2016-09-21 10:08inigosanchezStatusnew => scheduled
2016-09-21 13:57hgbotCheckin
2016-09-21 13:57hgbotNote Added: 0090134
2016-09-21 15:24inigosanchezNote Added: 0090136
2016-09-22 09:53hgbotCheckin
2016-09-22 09:53hgbotNote Added: 0090149
2016-09-22 09:53hgbotStatusscheduled => resolved
2016-09-22 09:53hgbotResolutionopen => fixed
2016-09-22 09:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ed3d9ac528b1b2db3844cc22d0c7a631b43f618a [^]
2016-09-22 09:54inigosanchezReview Assigned To => caristu
2016-09-23 08:17alostaleRelationship addedrelated to 0032366
2016-09-23 08:33alostaleRelationship addedrelated to 0033960
2016-09-23 18:22hudsonbotCheckin
2016-09-23 18:22hudsonbotNote Added: 0090212
2016-09-28 10:26caristuNote Added: 0090335
2016-09-28 15:52hgbotCheckin
2016-09-28 15:52hgbotNote Added: 0090348
2016-09-28 16:14hgbotCheckin
2016-09-28 16:14hgbotNote Added: 0090350
2016-09-29 00:02hudsonbotCheckin
2016-09-29 00:02hudsonbotNote Added: 0090363
2016-09-29 00:02hudsonbotCheckin
2016-09-29 00:02hudsonbotNote Added: 0090364
2016-09-29 10:38hgbotCheckin
2016-09-29 10:38hgbotNote Added: 0090372
2016-09-29 13:12caristuNote Added: 0090373
2016-09-29 13:12caristuStatusresolved => closed
2016-09-29 13:12caristuFixed in Version => 3.0PR16Q4
2016-09-29 23:30hudsonbotCheckin
2016-09-29 23:30hudsonbotNote Added: 0090393

Notes
(0090134)
hgbot   
2016-09-21 13:57   
Repository: erp/mods/org.openbravo.client.application.examples
Changeset: 5e28d6f5aaf266e80f0fcd41efd664343a1756b4
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Sep 21 13:56:31 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.client.application.examples/rev/5e28d6f5aaf266e80f0fcd41efd664343a1756b4 [^]

Related to issue 34043: Added combo examples in callout examples.

---
M src/org/openbravo/client/application/examples/callouts/OBEXAPP_Assets_Desc.java
M src/org/openbravo/client/application/examples/callouts/OBEXAPP_Assets_Name.java
---
(0090136)
inigosanchez   
2016-09-21 15:24   
Added new section in wiki[1] related this issue.


[1].-http://wiki.openbravo.com/wiki/How_to_create_a_callout_that_extends_from_another_callout#Working_with_combos [^]
(0090149)
hgbot   
2016-09-22 09:53   
Repository: erp/devel/pi
Changeset: ed3d9ac528b1b2db3844cc22d0c7a631b43f618a
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Sep 21 18:18:53 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ed3d9ac528b1b2db3844cc22d0c7a631b43f618a [^]

Fixes issue 34043: There is a restriction when extending a callout

There was a restriction when extending a callout from another callout and the same combo was updated.

This problem is fixed and now it is allows to delete any entry of a combo previously updated. Besides it
has been improve how to manage combo entries by using a map. It has been improve some comments and
variable names too.

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0090212)
hudsonbot   
2016-09-23 18:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/25f7de2ab346 [^]
Maturity status: Test
(0090335)
caristu   
2016-09-28 10:26   
Some improvements to be done. Code review:

https://docs.google.com/spreadsheets/d/18l2biKWeG6iGDIPqO6VuYQ_TtP_6YxyQU4KSrPvQlJ8/edit#gid=0 [^]
(0090348)
hgbot   
2016-09-28 15:52   
Repository: erp/devel/pi
Changeset: 4eaae49d7b7ec61225d6f7cc45ab17483af59176
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Sep 28 15:50:27 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4eaae49d7b7ec61225d6f7cc45ab17483af59176 [^]

Related to issue 34043: Code review improvements

-Improve comments.
-It is take into account special case in addSelect() method: Combo not defined properly.

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0090350)
hgbot   
2016-09-28 16:14   
Repository: erp/devel/pi
Changeset: 8b2d570732a8bcb4e26d7401f8874d52c9b41caf
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Wed Sep 28 16:11:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b2d570732a8bcb4e26d7401f8874d52c9b41caf [^]

Related to issue 34043: Update name of method.

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0090363)
hudsonbot   
2016-09-29 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2cd54ee6264a [^]
Maturity status: Test
(0090364)
hudsonbot   
2016-09-29 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2cd54ee6264a [^]
Maturity status: Test
(0090372)
hgbot   
2016-09-29 10:38   
Repository: erp/devel/pi
Changeset: cfba396452d557b5fbf0d531d0733a89a587548d
Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com>
Date: Thu Sep 29 10:36:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cfba396452d557b5fbf0d531d0733a89a587548d [^]

Related to issue 34043: Added context information for error log

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0090373)
caristu   
2016-09-29 13:12   
Code review + tested OK
(0090393)
hudsonbot   
2016-09-29 23:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f5481831914 [^]
Maturity status: Test