Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034021Openbravo ERPZ. Otherspublic2016-09-19 18:192016-09-29 00:02
Reportermaite 
Assigned ToSanjota 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034021: Concurrency problem: is possible to process same transaction document more than one time when accessing from different sessions
DescriptionIn case 2 users access to Transactions tabs from different sessions (different browser persons, for example), both of them will be able to process the transaction in case not refresh is performed
Steps To Reproduce1. Access any financial account window, transactions tab and create new record selecting any gl item and setting any amount
2. Open another browser session with different person and access same transaction register
3. Click "Process" button using this browser. Transaction will be processed and Financial Account's current balance will be updated
4. Using the other browser (without refreshing the screen) run "Process" button from same transaction. Realize that Financial Account's current balance will be updated again, causing inconsistency as Current Balance <> Initial Balance +- Processed Transactions
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0035137 closed AtulOpenbravo Concurrency problem: current balance wrongly calculated when 2 transactions are processed at same time 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-19 18:19maiteNew Issue
2016-09-19 18:19maiteAssigned To => Triage Finance
2016-09-19 18:19maiteModules => Advanced Payables and Receivables Mngmt
2016-09-19 18:19maiteResolution time => 1475445600
2016-09-19 18:19maiteTriggers an Emergency Pack => No
2016-09-19 18:20maiteIssue Monitored: networkb
2016-09-19 18:31heccamIssue Monitored: heccam
2016-09-22 14:06aferrazAssigned ToTriage Finance => Sanjota
2016-09-27 13:38SanjotaStatusnew => scheduled
2016-09-27 13:56SanjotaNote Added: 0090301
2016-09-28 09:53hgbotCheckin
2016-09-28 09:53hgbotNote Added: 0090328
2016-09-28 09:53hgbotStatusscheduled => resolved
2016-09-28 09:53hgbotResolutionopen => fixed
2016-09-28 09:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24cf2ca5a3c4d474eb78c04bf780ae646247bd1a [^]
2016-09-28 09:54aferrazReview Assigned To => aferraz
2016-09-28 09:54aferrazNote Added: 0090331
2016-09-28 09:54aferrazStatusresolved => closed
2016-09-28 09:54aferrazFixed in Version => 3.0PR16Q4
2016-09-28 09:54aferrazNote Edited: 0090301bug_revision_view_page.php?bugnote_id=0090301#r13256
2016-09-29 00:02hudsonbotCheckin
2016-09-29 00:02hudsonbotNote Added: 0090359
2017-02-02 13:32maiteRelationship addedrelated to 0035137

Notes
(0090301)
Sanjota   
2016-09-27 13:56   
(edited on: 2016-09-28 09:54)
1. Access any financial account window, transactions tab and create new record selecting any gl item and setting any amount
2. Open another browser session with different person and access same transaction register
3. Click "Process" button using this browser. Transaction will be processed and Financial Account's current balance will be updated
4. Using the other browser (without refreshing the screen) run "Process" button from same transaction.
   Observe that balance is not updated in financial account.
(0090328)
hgbot   
2016-09-28 09:53   
Repository: erp/devel/pi
Changeset: 24cf2ca5a3c4d474eb78c04bf780ae646247bd1a
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Tue Sep 27 17:14:31 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/24cf2ca5a3c4d474eb78c04bf780ae646247bd1a [^]

Fixes issue 34021: Fixes to Concurrency problem with processing of transaction

Fix to Concurrency problem: is possible to process same transaction document more than one time when accessing from different sessions.
Fix: Along with filter on process button name, included status of the transaction as filter to process the transaction

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_TransactionProcess.java
---
(0090331)
aferraz   
2016-09-28 09:54   
Code review + Testing OK
(0090359)
hudsonbot   
2016-09-29 00:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2cd54ee6264a [^]
Maturity status: Test