0034016: OrderLoader should raise an error if cashup pointed by the order does not exists

Openbravo Issue Tracking System - Retail Modules
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0034016	Retail Modules	Web POS	public	2016-09-19 12:07	2016-09-19 12:07

Reporter	guilleaer
Assigned To	Retail
Priority	normal	Severity	minor	Reproducibility	always
Status	new	Resolution	open
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version
Merge Request Status
Review Assigned To
OBNetwork customer	No
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0034016: OrderLoader should raise an error if cashup pointed by the order does not exists
Description	OrderLoader should raise an error if the cashup id of the jsonorder does not exists in the system
Steps To Reproduce	1. Create an order 2. add a product 3. Using dev toosl put a breakpoint just when the cashup_id is set just before send order to backend 4. pay the order 5. when the code stops in the breakpoint, just execute this code in the developer tools: receipt.set('obposAppCashup', '00AA23'); And then resume the execution. 6. ERROR: Order is processed whithout errors. Cashup field of the order is null
Proposed Solution	in orderloader class, in method verifyCashupStatus add the following code - if (cashUp != null && cashUp.isProcessedbo()) { + if (cashUp == null) { + throw new OBException("The cashup related to this order does not exists"); + } else if (cashUp != null && cashUp.isProcessedbo()) {
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2016-09-19 12:07	guilleaer	New Issue
2016-09-19 12:07	guilleaer	Assigned To	=> Retail
2016-09-19 12:07	guilleaer	OBNetwork customer	=> No
2016-09-19 12:07	guilleaer	Triggers an Emergency Pack	=> No

There are no notes attached to this issue.