Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034009Retail ModulesWeb POSpublic2016-09-16 09:232016-09-26 12:00
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034009: Web POS is invoicing orders which are not supposed to be invoiced
DescriptionThe OrderLoader API contains a flag called "notInvoiceInCashup". This flag can be set to force the Cashup process not to invoice some particular receipt.

This flag is not accessible directly by the UI, but is used indirectly by the Loyalty module, to prevent orders paid with loyalty points from being invoiced.

The problem is that this flag is not being saved correctly in the order when creating the order in the backend in one specific case (when synchronizing back an order previously loaded from the backend). As the flag is not set, the cashup then creates an invoice for this orders, and this is not correct.
Steps To Reproduce- Install the Loyalty module, and one compatible loyalty implementation.
- Create a layaway in the Web POS. Click on "Layaway this receipt button".
- Load the layaway back into the Web POS. Pay it fully with Loyalty points.
- Execute the cashup. Verify that the order was invoiced as part of the cashup invoice. This is not correct.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0033890 closed Retail Paid orders without payments are correctly processed in the backend 
related to defect 0034084 new Retail Pending test to be developed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-16 09:23marvintmNew Issue
2016-09-16 09:23marvintmAssigned To => Retail
2016-09-16 09:23marvintmTriggers an Emergency Pack => No
2016-09-16 09:24hgbotCheckin
2016-09-16 09:24hgbotNote Added: 0090019
2016-09-16 09:24hgbotStatusnew => resolved
2016-09-16 09:24hgbotResolutionopen => fixed
2016-09-16 09:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/595941ec56c854c9792e5ada5422de1698eb457e [^]
2016-09-19 09:19marvintmAssigned ToRetail => marvintm
2016-09-20 09:56marvintmResolution time => 1474927200
2016-09-26 10:24guilleaerReview Assigned To => guilleaer
2016-09-26 10:24guilleaerStatusresolved => closed
2016-09-26 10:24guilleaerFixed in Version => RR16Q4
2016-09-26 10:42guilleaerRelationship addedrelated to 0034084
2016-09-26 12:00hgbotCheckin
2016-09-26 12:00hgbotNote Added: 0090254
2016-09-26 12:01guilleaerNote Deleted: 0090254
2016-09-30 09:40marvintmRelationship addedhas duplicate 0033890

Notes
(0090019)
hgbot   
2016-09-16 09:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 595941ec56c854c9792e5ada5422de1698eb457e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Sep 16 09:23:54 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/595941ec56c854c9792e5ada5422de1698eb457e [^]

Fixed issue 34009. NotInvoiceOnCashup flag will be properly set in case the order is either a partially paid or fully paid layaway.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---