Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033978Retail ModulesWeb POSpublic2016-09-14 08:562016-09-22 12:36
Reportermarvintm 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033978: Taxes in the cashup invoice are not calculated properly if the tax is marked as document level
DescriptionSince 16Q2, the Web POS can calculate taxes at document level. This works correctly in the client side, when computing taxes for individual orders.

However, in the cashup, there is currently a problem in the way the taxes at header level are computed. These taxes should be calculated by summing the taxes at header level from the orders, and instead, they are being calculated by summing the taxes at line level. This can lead to inconsistencies derived from the fact that rounding is different if done in this way.
Steps To Reproduce- Configure taxes to be calculated at document level.
- Log in the Web POS. Create some orders. Do the cashup.
- Verify that the taxes computed at header level for the generated invoice do not sum the same amount as the taxes at header level of the orders. This is wrong.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0033979RR16Q3.2 closed marvintm Taxes in the cashup invoice are not calculated properly if the tax is marked as document level 
depends on backport 0033980RR16Q2.3 closed marvintm Taxes in the cashup invoice are not calculated properly if the tax is marked as document level 
related to defect 0034084 new Retail Pending test to be developed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-14 08:56marvintmNew Issue
2016-09-14 08:56marvintmAssigned To => Retail
2016-09-14 08:56marvintmTriggers an Emergency Pack => No
2016-09-14 08:56marvintmAssigned ToRetail => marvintm
2016-09-14 08:56marvintmStatusnew => scheduled
2016-09-15 18:52hgbotCheckin
2016-09-15 18:52hgbotNote Added: 0090004
2016-09-15 18:52hgbotStatusscheduled => resolved
2016-09-15 18:52hgbotResolutionopen => fixed
2016-09-15 18:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12aee61a591e0d5cb5f69e28448c0648094fbb13 [^]
2016-09-20 09:50guilleaerReview Assigned To => guilleaer
2016-09-20 09:50guilleaerStatusresolved => closed
2016-09-20 09:50guilleaerFixed in Version => RR16Q4
2016-09-22 12:25hgbotCheckin
2016-09-22 12:25hgbotNote Added: 0090161
2016-09-22 12:25hgbotStatusclosed => resolved
2016-09-22 12:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12aee61a591e0d5cb5f69e28448c0648094fbb13 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.3/org.openbravo.retail.posterminal/rev/9e8e576b00fda93aa7979b1bbb37993752706bb8 [^]
2016-09-22 12:36migueldejuanaStatusresolved => closed
2016-09-26 23:14guilleaerRelationship addedrelated to 0034084

Notes
(0090004)
hgbot   
2016-09-15 18:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 12aee61a591e0d5cb5f69e28448c0648094fbb13
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Sep 15 18:51:16 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/12aee61a591e0d5cb5f69e28448c0648094fbb13 [^]

Fixed issue 33978. Taxes configured to be calculated at document level will be computed correctly.
The root cause of the problem was that the taxes at document level of the invoice generated during the cashup were computed by summing the taxes from the orders at line level, and this was not correct. Now the taxes at document level of the invoice are computed by summing the taxes at document level of the orders.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---
(0090161)
hgbot   
2016-09-22 12:25   
Repository: retail/backports/3.0RR16Q2.3/org.openbravo.retail.posterminal
Changeset: 9e8e576b00fda93aa7979b1bbb37993752706bb8
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Sep 22 12:24:42 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.3/org.openbravo.retail.posterminal/rev/9e8e576b00fda93aa7979b1bbb37993752706bb8 [^]

Fixed issue 33978. Taxes configured to be calculated at document level will be computed correctly.
The root cause of the problem was that the taxes at document level of the invoice generated during the cashup were computed by summing the taxes from the orders at line level, and this was not correct. Now the taxes at document level of the invoice are computed by summing the taxes at document level of the orders.

---
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor_data.xsql
---