Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033977Openbravo ERPZ. Otherspublic2016-09-13 17:462016-09-29 23:30
Reportermaite 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket43643
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033977: "Set new currency" process is not converting credit properly when more than one credit payment exists for this business partner
DescriptionFollowing procedure is automatically performed when running "set new currency" process (http://wiki.openbravo.com/wiki/How_to_convert_credit_to_a_different_currency [^]) but error is faced in point 3) when generating credit in new currency
Steps To Reproduce1. Access Payment Out window, create record for Bebidas Alegres, Generated Credit=100. Add details and process using "leave credit to be used later" option.
2. Access Payment Out window, create record for Bebidas Alegres, Generated Credit=800. Add details and process using "leave credit to be used later" option.
3. Access Bebidas Alegres business partner and run process "Set new currency", set USD currency, uncheck option "use default rate" and set rate=18. Select any gl item and run
4. Access Payment Out window again and realize that payments generating credit in USD currency has same amount, that is 14400 USD (instead of 1800USD and 14400USD respectively)

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034003 closed markmm82 Set New Currency process warning needs to be modified 
related to defect 0034098 closed markmm82 Not possible to change once more Business Partner currency if it has already been changed. 
related to defect 0034301 closed markmm82 "Set new currency" process error when converting credit already generated in multicurrency payment 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-13 17:46maiteNew Issue
2016-09-13 17:46maiteAssigned To => Triage Finance
2016-09-13 17:46maiteOBNetwork customer => Yes
2016-09-13 17:46maiteModules => Advanced Payables and Receivables Mngmt
2016-09-13 17:46maiteSupport ticket => 43643
2016-09-13 17:46maiteResolution time => 1475532000
2016-09-13 17:46maiteTriggers an Emergency Pack => No
2016-09-13 17:46maiteIssue Monitored: networkb
2016-09-15 11:05psanjuanNote Added: 0089972
2016-09-15 11:05psanjuanNote Edited: 0089972bug_revision_view_page.php?bugnote_id=0089972#r13105
2016-09-15 12:03psanjuanNote Edited: 0089972bug_revision_view_page.php?bugnote_id=0089972#r13106
2016-09-15 12:11psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13108#r13108
2016-09-15 12:11psanjuanNote Edited: 0089972bug_revision_view_page.php?bugnote_id=0089972#r13109
2016-09-15 13:55psanjuanRelationship addedrelated to 0034002
2016-09-15 14:06psanjuanRelationship addedrelated to 0034003
2016-09-15 14:06aferrazRelationship deletedrelated to 0034002
2016-09-15 14:08aferrazAssigned ToTriage Finance => markmm82
2016-09-15 16:44markmm82Statusnew => scheduled
2016-09-20 17:02markmm82Note Added: 0090118
2016-09-26 11:05psanjuanNote Added: 0090247
2016-09-26 11:10psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13186
2016-09-26 11:19psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13187
2016-09-26 11:21psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13188
2016-09-26 11:25psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13189
2016-09-27 10:00psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13223
2016-09-27 10:00psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13224
2016-09-27 10:00psanjuanNote Added: 0090284
2016-09-27 10:16psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13226
2016-09-27 10:19psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13227
2016-09-27 10:22psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13228
2016-09-27 10:24psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13229
2016-09-27 10:28psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13230
2016-09-27 10:57psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13231
2016-09-27 11:25psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13232
2016-09-27 11:25psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13233
2016-09-27 11:43psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13234
2016-09-27 11:44psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13235
2016-09-27 11:50psanjuanNote Added: 0090291
2016-09-27 12:00psanjuanNote Added: 0090292
2016-09-27 12:03psanjuanNote Edited: 0090292bug_revision_view_page.php?bugnote_id=0090292#r13237
2016-09-27 12:03psanjuanNote Deleted: 0090292
2016-09-27 12:07psanjuanNote Added: 0090294
2016-09-27 12:17psanjuanNote Deleted: 0090294
2016-09-27 12:24psanjuanNote Added: 0090298
2016-09-27 12:28psanjuanNote Edited: 0090298bug_revision_view_page.php?bugnote_id=0090298#r13239
2016-09-27 12:34psanjuanNote Edited: 0090298bug_revision_view_page.php?bugnote_id=0090298#r13240
2016-09-27 12:36psanjuanNote Edited: 0090298bug_revision_view_page.php?bugnote_id=0090298#r13241
2016-09-27 12:36psanjuanNote Added: 0090299
2016-09-27 12:40psanjuanNote Edited: 0090299bug_revision_view_page.php?bugnote_id=0090299#r13243
2016-09-27 12:44psanjuanNote Edited: 0090299bug_revision_view_page.php?bugnote_id=0090299#r13244
2016-09-27 12:49psanjuanNote Edited: 0090299bug_revision_view_page.php?bugnote_id=0090299#r13245
2016-09-27 12:51psanjuanNote Added: 0090300
2016-09-27 12:57psanjuanRelationship addedrelated to 0034098
2016-09-29 15:46psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13273
2016-09-29 15:52psanjuanNote Edited: 0090284bug_revision_view_page.php?bugnote_id=0090284#r13274
2016-09-29 15:55psanjuanNote Edited: 0090247bug_revision_view_page.php?bugnote_id=0090247#r13275
2016-09-29 16:00psanjuanNote Edited: 0090291bug_revision_view_page.php?bugnote_id=0090291#r13277
2016-09-29 16:02psanjuanNote Edited: 0090291bug_revision_view_page.php?bugnote_id=0090291#r13278
2016-09-29 16:06psanjuanNote Edited: 0090298bug_revision_view_page.php?bugnote_id=0090298#r13279
2016-09-29 16:09psanjuanNote Edited: 0090299bug_revision_view_page.php?bugnote_id=0090299#r13280
2016-09-29 16:11psanjuanNote Deleted: 0090300
2016-09-29 16:16psanjuanNote Added: 0090380
2016-09-29 16:17psanjuanNote Edited: 0090291bug_revision_view_page.php?bugnote_id=0090291#r13285
2016-09-29 16:18psanjuanNote Added: 0090381
2016-09-29 16:24psanjuanNote Edited: 0090381bug_revision_view_page.php?bugnote_id=0090381#r13287
2016-09-29 16:36psanjuanNote Edited: 0090381bug_revision_view_page.php?bugnote_id=0090381#r13288
2016-09-29 16:37psanjuanNote Edited: 0090381bug_revision_view_page.php?bugnote_id=0090381#r13289
2016-09-29 16:40psanjuanNote Edited: 0090381bug_revision_view_page.php?bugnote_id=0090381#r13290
2016-09-29 16:45psanjuanNote Added: 0090383
2016-09-29 16:46psanjuanNote Added: 0090384
2016-09-29 18:29hgbotCheckin
2016-09-29 18:29hgbotNote Added: 0090387
2016-09-29 18:29hgbotStatusscheduled => resolved
2016-09-29 18:29hgbotResolutionopen => fixed
2016-09-29 18:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/90f3a0050b3c840e15e428e0e4ec2af0ff5d9db5 [^]
2016-09-29 18:29hgbotCheckin
2016-09-29 18:29hgbotNote Added: 0090388
2016-09-29 18:30aferrazReview Assigned To => aferraz
2016-09-29 18:30aferrazNote Added: 0090389
2016-09-29 18:30aferrazStatusresolved => closed
2016-09-29 18:30aferrazFixed in Version => 3.0PR16Q4
2016-09-29 23:30hudsonbotCheckin
2016-09-29 23:30hudsonbotNote Added: 0090397
2016-09-29 23:30hudsonbotCheckin
2016-09-29 23:30hudsonbotNote Added: 0090398
2016-10-26 10:02maiteRelationship addedrelated to 0034301

Notes
(0089972)
psanjuan   
2016-09-15 11:05   
(edited on: 2016-09-15 12:11)
Issue verified.
(0090118)
markmm82   
2016-09-20 17:02   
Test Plan:
1. Access Payment Out window, create record for Bebidas Alegres, Generated Credit=100. Add details and process using "leave credit to be used later" option.
2. Access Payment Out window, create record for Bebidas Alegres, Generated Credit=800. Add details and process using "leave credit to be used later" option.
3. Access Bebidas Alegres business partner and run process "Set new currency", set USD currency, uncheck option "use default rate" and set rate=18. Select any gl item and run
4. Access Payment Out window again and realize that new payments generating credit in USD currency exists. At top of the records inside the grid you will find:
  Currency : USD
  Paid (Financial Account): 800.00
  Exchange rate: 18
  Generated Credit: 14400.00

  Currency : USD
  Paid (Financial Account): 100.00
  Exchange rate: 18
  Generated Credit: 1800.00

It is correct.
(0090247)
psanjuan   
2016-09-26 11:05   
(edited on: 2016-09-29 15:55)
Test Plan

Test Case 1 - Set New Currency process by using system conversion rate.

As F&B Internation Group Admin role, go to C/L Item window. Create a new one with below setup:
name = Currency Conversion
In the accounting tab enter the account 8255 for F&B Internation Group USA Dollar, and the account 66800 for F&B España EUR ledger account

As F&B International Group Admin role, go to Financial Account window, search by "Cuenta de Banco", navigate to "Payment Method" tab, select "Transferencia" Payment Method and change it to allow making/receiving payments in other currencies than financial account currency (EUR)

As F&B International Group Admin role, go to Business Partner window.
Create a new supplier with below setup, for F&B España:
Search Key = Commercial Name = Supplier Credit 01
BP Category = Supplier

Go to Vendor/Creditor tab and check "Vendor" check-box. Select "Tarifa Bebidas Alegres" as purchase price list, "Transferencia" as PO Payment Method, "30 days" as PO Payment Terms and "Cuenta de Banco" as PO Financial Account. Save it.

Go to Location/Address and enter a location in Spain. Save it.

Go to Payment Out window and create a new one for F&B España and for this business partner "Supplier Credit 01".
Go to Generated Credit field and enter 100.00. Check currency shown is EUR.

Press Add detail and select "Process Made Payment(s)" action regarding document and "Leave the credit to be used later" as overpayment action. Press Done.

Go back to business partner window and refresh. Check "Current Balance" shown for "Supplier Credit 01" is 100.00

Go to Payment Out window and create another one for F&B España and for this business partner "Supplier Credit 01".
Go to Generated Credit field and enter 800.00. Check currency shown is EUR.

Press Add detail and select "Process Made Payment(s)" action regarding document and "Leave the credit to be used later" as overpayment action. Press Done.

Go back to business partner window and refresh. Check "Current Balance" shown for "Supplier Credit 01" is 900.00

Go to Conversion Rates window and check EUR to USD exchange rate for the period: from 01-07-2016 to 30-09-2016 (current date is 26-09-2016) EUR to USD conversion rate is 1.13

Go to business partner window and select "Supplier Credit 01". Run "Set New Currency" process.
In the new window, select USD in the field Currency, keep Use Default conversion rate check and select the G/L Item just created. Press Done.

Verify that Business Partner currency balance is now 1017.00 (900*1.13) which is correct. The currency shown is USD, while it keeps Tarifa Bebidas Alegres purchase price list.

Go to payment out window and verify that some new payments have been created after "Credit Payment" on:

Payment 510 - GL item: Currency Conversion Amount 800.00 EUR
Payment 511 - Refunded payment 10 Amount -800.00 EUR
Payment 512 - GL item: Currency Conversion Amount 100.00 EUR
Payment 513 - Refunded payment 12 Amount -100.00 EUR

and finally two more payments in USD

Payment 514 - GL item : Currency Conversion payment for an amount = 0.00 - Paid (Financial Account) = 800.00 EUR - Generated credit 904.00 USD - currency USD - Exchange Rate = 0.884956 (904.00 USD x 0.884956 = 800.00 EUR

Payment 515 - GL item : Currency Conversion payment for an amount = 0.00 - Paid (Financial Account) = 100.00 EUR - Generated credit 113.00 USD - currency USD - Exchange Rate = 0.884956 (113.00 USD x 0.884956 = 100.00 EUR

This is correct.

Repeat same scenario as above for a Customer business partner.

Repeat same scenario as above for a Vendor & a Customer business partner having 3 generated credits.
(0090284)
psanjuan   
2016-09-27 10:00   
(edited on: 2016-09-29 15:52)
Test Case 2 - Set New Currency process by using a specific conversion rate.

As F&B International Group Admin role, go to Business Partner window.
Create a new supplier with below setup, for F&B España:
Search Key = Commercial Name = Supplier Credit 02
BP Category = Supplier

Go to Vendor/Creditor tab and check "Vendor" check-box. Select "Tarifa Bebidas Alegres" as purchase price list, "Transferencia" as PO Payment Method, "30 days" as PO Payment Terms and "Cuenta de Banco" as PO Financial Account. Save it.

Go to Location/Address and enter a location in Spain. Save it.

Go to Payment Out window and create a new one for F&B España and for this business partner "Supplier Credit 02".
Go to Generated Credit field and enter 100.00. Check currency shown is EUR.

Press Add detail and select "Process Made Payment(s)" action regarding document and "Leave the credit to be used later" as overpayment action. Press Done.

Go back to business partner window and refresh. Check "Current Balance" shown for "Supplier Credit 02" is 100.00

Go to Payment Out window and create another one for F&B España and for this business partner "Supplier Credit 02".
Go to Generated Credit field and enter 800.00. Check currency shown is EUR.

Press Add detail and select "Process Made Payment(s)" action regarding document and "Leave the credit to be used later" as overpayment action. Press Done.

Go back to business partner window and refresh. Check "Current Balance" shown for "Supplier Credit 02" is 900.00

Go to business partner window and select "Supplier Credit 02".
Run "Set New Currency" process.

In the new window, select USD in the field Currency.
Remove "Use Default conversion rate" and enter a conversion rate = 18.00, in the field "Conversion Rate" select the G/L Item just created. Press Done.

Verify that Business Partner currency balance is now 16200.00 (900.00*18.00) which is correct. The currency shown is USD, while it keeps Tarifa Bebidas Alegres purchase price list.

Go to payment out window and verify that some new payments have been created after "Credit Payment" on:

Payment 518 - GL item: Currency Conversion Amount 800.00 EUR
Payment 519 - Refunded payment 18 Amount -800.00 EUR
Payment 520 - GL item: Currency Conversion Amount 100.00 EUR
Payment 521 - Refunded payment 20 Amount -100.00 EUR

and finally two more payments in USD

Payment 523 - GL item : Currency Conversion payment for an amount = 0.00 - Paid 800.00 EUR - Generated credit 14400.00 USD - Currency USD - Exchange Rate = 0.05556 (14400.00 USD x 0.05556) = 800.00 EUR.

Payment 523 - GL item : Currency Conversion payment for an amount = 0.00 - Paid 100.00 EUR - Generated credit 1800.00 USD - Currency USD - Exchange Rate = 0.05556 (1800.00 USD x 0.05556) = 100.00 EUR.

This is correct.

Repeat same scenario as above for a Customer business partner.

Repeat same scenario as above for a Vendor & a Customer business partner having 3 generated credits.
(0090291)
psanjuan   
2016-09-27 11:50   
(edited on: 2016-09-29 16:17)
Test Case 3 - Use of the generated credit exchanged into another currency.

As F&B Internation Group Admin role, go to price list window.
Once there, create a new purchase price list in USD. Select any product and enter a USD price of 5.50 for instance.

Select any of the supplier business partner created above.
Go to Purchase Invoice window. Create a new purchase invoice for the business partner (Supplier Credit 01 for instance). Select the price list in USD.

Go to lines, add a new one and select the product. Enter any invoiced quantity.
Complete the invoice. Press OK.

Check that Select Credit Payments window shows the two credits in USD of this supplier for amounts of 113.00 and 904.00. Select first one and press "Use Credit".

Verify that Payment Complete = Yes.

Write down Total Gross Amount = 66.55 USD and total net amount = 55.00 USD

Go to Business Partner window, search by the partner "Suplier Credit 01" and check that current balance shown is 950.45 (1017.00-66.55)


Repeat same test as above by using a Price List in EUR. Check that Select Credit Payments window is not shown.

Repeat same test as above for a customer business partner.
(0090298)
psanjuan   
2016-09-27 12:24   
(edited on: 2016-09-29 16:06)
Test Case 4 - Business Partner currency USD, set to EUR by using system conversion rate.

As F&B International Group Admin role go to Business Partner window.
Create a new customer for F&B España with below setup:
Name = Customer USA 01
Price List = Tarifa en dolares (create a sales price list in USD)
Payment Method = Transferencia
Payment terms = 30 days
Financial Account = Cuenta de Banco (EUR currency)
Enter a location in United States.

Save

Go to Payment In window and create a credit for this new customer with below data:
Currency = USD
Amount = 100.00 (USD)
Received (Financial Account) = 88.50 (EUR)
Exchange Rate = 0.884956 (system conversion rate USD to EUR)
Press Add Details, do not select anything but just process the payment and leave the credit to be used later. Press Done.

Go to business partner window and check current balance is -100.00 (USD) this is OK.

Go to Payment In window and create a credit for this new customer with below data:
Currency = USD
Amount = 800.00 (USD)
Received (Financial Account) = 707.96 (EUR)
Exchange Rate = 0.884956 (system conversion rate USD to EUR)
Press Add Details, do not select anything but just process the payment and leave the credit to be used later. Press Done.

Go to business partner window and check current balance is -900.00 (USD) this is OK.

Run Set New Currency process. Select EUR currency, use default conversion rate and select a G/L item. Press Done.

Check Customer balance is now -796.46 (900 USD * 0.884956). This is correct.

Go to Payment In window and check that additional payments have been created for the customer:

Payment 250 - GL item currency conversion - USD - Amount 100
Payment 251 - refunded payment 250 - USD - Amount -100
Payment 252 - GL item currency conversion - USD - Amount 800
Payment 253 - refunded payment 252 - USD - Amount -800

And two additional payment in EUR.
Payment 254 - Generated Credit 88.50 EUR (100.00 USD *0.884956)
Payment 255 - Generated Credit 707.96 EUR (800.00 USD * 0.884956)

All of this is correct.

Repeat same test as above for a supplier.
(0090299)
psanjuan   
2016-09-27 12:36   
(edited on: 2016-09-29 16:09)
Test Case 5 - Business Partner currency USD, set to EUR by using as specifi conversion rate.

As F&B International Group Admin role go to Business Partner window.
Create a new customer for F&B España with below setup:
Name = Customer USA 02
Price List = Tarifa en dolares (create a sales price list in USD)
Payment Method = Transferencia
Payment terms = 30 days
Financial Account = Cuenta de Banco (EUR currency)
Enter a location in United States.

Save

Go to Payment In window and create a credit for this new customer with below data:
Currency = USD
Amount = 100.00 (USD)
Received (Financial Account) = 88.50 (EUR)
Exchange Rate = 0.884956 (system conversion rate USD to EUR)
Press Add Details, do not select anything but just process the payment and leave the credit to be used later. Press Done.

Go to business partner window and check current balance is -100.00 (USD) this is OK.

Go to Payment In window and create a credit for this new customer with below data:
Currency = USD
Amount = 800.00 (USD)
Received (Financial Account) = 707.96 (EUR)
Exchange Rate = 0.884956 (system conversion rate USD to EUR)
Press Add Details, do not select anything but just process the payment and leave the credit to be used later. Press Done.

Go to business partner window and check current balance is -900.00 (USD) this is OK.

Run Set New Currency process. Select EUR currency, use a specific exchange rate = 18, select a G/L item. Press Done.

Check Customer balance is now -16200.00 (900 USD * 18). This is correct.

Go to Payment In window and check that additional payments have been created for the customer:

Payment 258 - GL item currency conversion - USD - Amount 100
Payment 259 - refunded payment 258 - USD - Amount -100
Payment 260 - GL item currency conversion - USD - Amount 800
Payment 261 - refunded payment 260 - USD - Amount -800

And two additional payment in EUR.
Payment 262 - Generated Credit 1800.00 EUR (100.00 USD *18)
Payment 263 - Generated Credit 14400.00 EUR (800.00 USD * 18)

All of this is correct.

Repeat same test as above for a supplier.
(0090380)
psanjuan   
2016-09-29 16:16   
Test Case 6 - Use of the generated credit exchanged into another currency

Go to Sales Invoice window, select any of the supplier business partner created above (test 04), for instance Customer USA 02. Select a price list in EUR (Tarifa de Ventas).

Go to lines, add a new one and select "Cerveza Ale 0.5L", invoiced quantity = 10, net unit price = 2.04, line net amount = 20.40 EUR
Complete the invoice. Press OK.

Check that Select Credit Payments window shows the two credits in EUR of this cusomer for amounts of 1800.00 and 14400.00. Select first one and press "Use Credit".

Verify that Payment Complete = Yes.

Write down Total Gross Amount = 20.40 EUR = total net amount

Go to Business Partner window, search by the partner "Suplier Credit 01" and check that current balance shown is -16179.60 (-16200+20.40)


Repeat same test as above by using a Price List in USD. Check that Select Credit Payments window is not shown.

Repeat same test as above for a supplier business partner.
(0090381)
psanjuan   
2016-09-29 16:18   
(edited on: 2016-09-29 16:40)
Test Case 7 - Set New currency process, set to a given amount. BP currency EUR.

Go to Business Partner window and create a new one named "Customer Amount". Set is as a customer. Select a EUR Price List, for instance "Tarifa de Ventas".

Go to payment in window, and create a new record. Select the business partner. Enter 100.00 in the field amount. Press Add details. Do not select anything but just process the payment and leave the credit to be used later.

Enter another credit for an amount of 800.00 EUR for the same customer.

Go to business partner window and check that customer balance is -900.00 EUR.

Run set New currency process by entering below data:
Currency = USD
Check Set Amount = Yes
Foreign Amount = -500
G/L iten = Currency Conversion

Verify that customer current balance is -500.00, and customer currency = USD.

Go to Payment in and verify that some new payments have been created for the customer:

Payment 323 - GL Item currency conversion payment in EUR for 100.00
Payment 324 - Refund payment 323 in EUR for -100.00
Payment 325 - GL Item currency conversion payment in EUR for 800.00
Payment 326 - Refund payment 325 in EUR for -800.00

and two additional payments in USD.
Payment 327*R - Currency USD - Received (Financial Account) = 100.00 EUR - Generated Credit = 55.56 USD (100.00 EUR * 500.00 USD/900.00 EUR) - exchange rate = 1.79999 (55.56 USD * 1.79999 USDtoEUR) = 100.00 EUR

Payment 328*R - Currency USD - Received (Financial Account) = 800.00 EUR - Generated Credit = 444.44 USD (800.00 EUR * 500.00 USD/900.00 EUR) - exchange rate = 1.79999 (444.44 USD * 1.79999 USDtoEUR) = 800.00 EUR

Repeat same test for a supplier
(0090383)
psanjuan   
2016-09-29 16:45   
Test Case 7 - Set New currency process, set to a given amount. BP currency USD.

Go to Business Partner window and create a new one named "Customer USA Amount". Set is as a customer. Select a USD Price List.

Go to payment in window, and create a new record. Select the business partner. Enter 100.00 in the field amount, currency USD. Press Add details. Do not select anything but just process the payment and leave the credit to be used later.

Enter another credit for an amount of 800.00 USD for the same customer.

Go to business partner window and check that customer balance is -900.00 USD.

Run set New currency process by entering below data:
Currency = EUR
Check Set Amount = Yes
Foreign Amount = -500
G/L iten = Currency Conversion

Verify that customer current balance is -500.00, and customer currency = EUR.

Go to Payment in and verify that some new payments have been created for the customer:

Payment 331 - GL Item currency conversion payment in USD for 100.00
Payment 332 - Refund payment 331 in USD for -100.00
Payment 333 - GL Item currency conversion payment in USD for 800.00
Payment 334 - Refund payment 333 in USD for -800.00

and two additional payments in EUR.

Payment 335*R - Currency EUR - Generated Credit = 55.56 EUR (100.00 USD * 500.00 EUr/900.00 USD)

Payment 336*R - Currency EUr - Renerated Credit = 444.44 EUR (800.00 USD * 500.00 EUR/900.00 USD)

Repeat same test for a supplier
(0090384)
psanjuan   
2016-09-29 16:46   
Test plan above verified.
Issue can be closed.
(0090387)
hgbot   
2016-09-29 18:29   
Repository: erp/devel/pi
Changeset: 90f3a0050b3c840e15e428e0e4ec2af0ff5d9db5
Author: Mark <markmm82 <at> gmail.com>
Date: Mon Sep 26 11:39:54 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/90f3a0050b3c840e15e428e0e4ec2af0ff5d9db5 [^]

Fixes issue 33977: "Set new currency" process is converting credit properly

When the "Set new currency" process is configured to do not use a default rate and a manually rate is introduced, it is used for recalculate the generic credit instead the current conversion rate. Also, when more than one credit payment exists for the business partner, the process was generating the new entries with the last original value of the generated credit of the payment, and it caused that all generated credits were the same. Now, the generated credit is always recalculated with the original generated credit and rate of the process.

---
M src/org/openbravo/common/actionhandler/SetNewBPCurrency.java
---
(0090388)
hgbot   
2016-09-29 18:29   
Repository: erp/devel/pi
Changeset: b2f532852843bf2d412a486ef3ede4549e3a3ee0
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Sep 29 11:27:21 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b2f532852843bf2d412a486ef3ede4549e3a3ee0 [^]

Related to issue 33977: Code review improvements

---
M src/org/openbravo/common/actionhandler/SetNewBPCurrency.java
---
(0090389)
aferraz   
2016-09-29 18:30   
Code review + Testing OK
(0090397)
hudsonbot   
2016-09-29 23:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f5481831914 [^]
Maturity status: Test
(0090398)
hudsonbot   
2016-09-29 23:30   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f5481831914 [^]
Maturity status: Test