Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033976Openbravo ERPA. Platformpublic2016-09-13 17:392016-12-16 18:37
Reporterumartirena 
Assigned Toplatform 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033976: Implement Client Side Event Handler Pre Delete Action
DescriptionIt would be nice if it could be possible to execute some actions before deleting a record or several records on an specific tab of the application.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 00332633.0PR16Q4 closed caristu Implement Client Side Event Handler Extensions 
causes defect 0035686 closed inigosanchez It is not possible to delete a record in tree view 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-09-13 17:39umartirenaNew Issue
2016-09-13 17:39umartirenaAssigned To => platform
2016-09-13 17:39umartirenaModules => Core
2016-09-13 17:39umartirenaTriggers an Emergency Pack => No
2016-09-13 17:39umartirenaRelationship addedrelated to 0033263
2016-10-18 14:29hgbotCheckin
2016-10-18 14:29hgbotNote Added: 0090670
2016-10-18 14:29hgbotStatusnew => resolved
2016-10-18 14:29hgbotResolutionopen => fixed
2016-10-18 14:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^]
2016-10-18 14:29hgbotCheckin
2016-10-18 14:29hgbotNote Added: 0090671
2016-10-18 14:29hgbotCheckin
2016-10-18 14:29hgbotNote Added: 0090672
2016-10-18 19:23caristuReview Assigned To => caristu
2016-10-18 19:23caristuIssue Monitored: caristu
2016-10-19 09:30hgbotCheckin
2016-10-19 09:30hgbotNote Added: 0090689
2016-10-20 16:38caristuNote Added: 0090732
2016-10-20 17:57caristuNote Added: 0090735
2016-10-20 17:57caristuStatusresolved => closed
2016-10-20 17:57caristuFixed in Version => 3.0PR17Q1
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092531
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092532
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092533
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092534
2017-04-04 16:23inigosanchezRelationship addedcauses 0035686

Notes
(0090670)
hgbot   
2016-10-18 14:29   
Repository: erp/devel/pi
Changeset: b23043be4cf63ad3ce1fd35047ece43b4530c3bd
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Sep 14 12:10:51 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b23043be4cf63ad3ce1fd35047ece43b4530c3bd [^]

Fixed Issue 33976: Implemented Pre Delete Client Side Event Handler

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-event-handler-registry.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090671)
hgbot   
2016-10-18 14:29   
Repository: erp/devel/pi
Changeset: 86421f90703271582042c89412f50b636484a06d
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Sep 16 15:02:24 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/86421f90703271582042c89412f50b636484a06d [^]

Related ot issue 33976: Code review improvements


1) Take into account if the grid is in tree view or normal view.
2) Name selectedRecords as recordsToDelete.
3) Check if the callback function to be executed is a function. If not, don't execute the action.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090672)
hgbot   
2016-10-18 14:29   
Repository: erp/devel/pi
Changeset: a329a3cb0674993321268b936a473d8e0312aae6
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Fri Sep 16 15:49:50 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a329a3cb0674993321268b936a473d8e0312aae6 [^]

Related to issue 33976: Code review

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090689)
hgbot   
2016-10-19 09:30   
Repository: erp/devel/pi
Changeset: 8b78e2441a235818e4f98ca482c58f27987b021f
Author: Unai Martirena <unai.martirena <at> openbravo.com>
Date: Wed Oct 19 09:28:34 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8b78e2441a235818e4f98ca482c58f27987b021f [^]

Related to issue 33976: Fix wrong function call

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0090732)
caristu   
2016-10-20 16:38   
Updated doc: http://wiki.openbravo.com/wiki/How_to_create_client_event_handler_actions#Pre-delete_Action:_Client_Validation [^]
(0090735)
caristu   
2016-10-20 17:57   
Code review and tested as part of the project[1]

Added a new sample pre-delete action in org.openbravo.platform.ci module[2]


[1] http://wiki.openbravo.com/wiki/Projects:Client_Side_Event_Handlers_Extension_PreDelete [^]
[2] https://code.openbravo.com/erp/mods/org.openbravo.platform.ci/rev/c6389df9c433 [^]
(0092531)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092532)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092533)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092534)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test