0033975: Wrong Net Unit Price and pricestd in order and invoice lines when applying a discount of a percentage with decimals - Openbravo Issue Tracking System

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

ID

Project

Category

View Status

Date Submitted

Last Update

0033975

Openbravo ERP

02. Master data management

public

2016-09-13 13:22

2016-09-29 00:02

Reporter

ngarcia

Assigned To

markmm82

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS

5

OS Version

Product Version

Target Version

Fixed in Version

3.0PR16Q4

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0033975: Wrong Net Unit Price and pricestd in order and invoice lines when applying a discount of a percentage with decimals

Description

Wrong Net Unit Price and pricestd in order and invoice lines when applying a discount of a percentage with decimals

Steps To Reproduce

As group admin role:
   Set the Price Precision of the Currency to 2
   Create a new product
   Add a price of 34.27 to it
   Create a Price Adjustment for that product (Discount and Promotions):
      Discount %: 64.3
      Discount Amount: 0.00
   Create a Sales Order
   Add the previously created product and check the Net Unit Price is updated to 12.34
   Book it and check the Net Unit Price is updated to 12.24
   The correct value should be 12.23
   Repeat the process for sales invoices and also in purchase flow

Proposed Solution

The problem seems to be in calculatePriceActual and calculatePriceStd functions of PriceAdjustment class as the discount percentage is rounded to the price precision after dividing it by 100. Example:

64.3 / 100 = 0.643 -> 0.64

.divide(BigDecimal.valueOf(100), precision, BigDecimal.ROUND_HALF_UP)

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0032544		closed	shivum039	Retail Modules	automatic discounts are applied in backoffice purchase flow
related to	defect	0034103		closed	markmm82	Openbravo ERP	Incorrect prices are calculated in Purchase Orders/Invoices when exists discounts or promotions related to products.

Attached Files

Issue History

Date Modified

Username

Field

Change

2016-09-13 13:22

New Issue

2016-09-13 13:22

Assigned To

=> Triage Finance

2016-09-13 13:22

Modules

=> Core

2016-09-13 13:22

Resolution time

=> 1475532000

2016-09-13 13:22

Triggers an Emergency Pack

=> No

2016-09-13 13:22

Issue Monitored: networkb

2016-09-15 11:16

Assigned To

Triage Finance => markmm82

2016-09-20 17:27

Status

new => scheduled

2016-09-26 13:17

Relationship added

related to 0032544

2016-09-27 17:22

Note Added: 0090306

2016-09-27 17:37

Relationship added

related to 0034103

2016-09-28 09:53

Checkin

2016-09-28 09:53

Note Added: 0090330

2016-09-28 09:53

Status

scheduled => resolved

2016-09-28 09:53

Resolution

open => fixed

2016-09-28 09:53

Fixed in SCM revision

=> http://code.openbravo.com/erp/devel/pi/rev/e94a1240a35856cbe1cafacda5447ed54fef70fc [^]

2016-09-28 10:02

Review Assigned To

=> aferraz

2016-09-28 10:02

Note Added: 0090333

2016-09-28 10:02

Status

resolved => closed

2016-09-28 10:02

Fixed in Version

=> 3.0PR16Q4

2016-09-29 00:02

Checkin

2016-09-29 00:02

Note Added: 0090361

Notes

Test Plan 1:
As group admin role:
   Set the Price Precision of the Currency EUR to 2 if necessary
   Create a new product
      Search key/ Name: Test
   Add two prices of 34.27 to it. For instance for Tarifa Bebidas Alegres and Tarifa de Ventas price lists versions.
   Create a Price Adjustment for that product. Go to Discount and Promotions and add a new record:
      Discount %: 64.3
      Discount Amount: 0.00
      Included Products: Only those defined
   Add the new product in tab Products
   Create a Sales Order header for Alimentos y Supermercados, S.A bp.
   Create a line to the sales order:
     Add the previously created product (Test) and check the Net Unit Price is updated to 12.23.
   Set tax to Ventas exentas, to not apply taxes.
   Remove discounts from Basic Discounts if exists.
   Book it and check the following information is updated in Sales order header and line:
     Sales Order Line:
        Net Unit Price is updated to 12.23
     Sales Order Header:
    Total Gross Amount: 12.23
    Total Net Amount: 12.23
     It is correct, there are not taxes or discounts except applied to the price with the Price adjustment previously created to the product.

Test Plan 2:
As group admin role:
   Set the Price Precision of the Currency EUR to 2 if necessary
   Create a new product
      Search key/ Name: Test-II
   Add two prices of 34.27 to it. For instance for Tarifa Bebidas Alegres and Tarifa de Ventas price lists versions.
   Create a Price Adjustment for that product. Go to Discount and Promotions and add a new record:
      Discount %: 64.3
      Discount Amount: 0.00
      Included Products: Only those defined
   Add the new product in tab Products
   Create a Sales Invoice header for Alimentos y Supermercados, S.A bp.
   Create a line to the invoice:
     Add the previously created product (Test-II) and check the Net Unit Price is updated to 12.23.
   Set tax to Ventas exentas, to not apply taxes.
   Remove discounts from Basic Discounts if exists.
   Complete it and check the following information is updated in header and line:
     Sales Invoice Line:
        Net Unit Price is updated to 12.23
     Sales Invoice Header:
    Total Gross Amount: 12.23
    Total Net Amount: 12.23
     It is correct, there are not taxes or discounts except applied to the price with the Price adjustment previously created for the product.