Notes |
|
(0090892)
|
hgbot
|
2016-10-26 11:52
|
|
Repository: erp/devel/pi
Changeset: d66d2a4148987acab6ef1f586ee019097ef1d1e9
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 19 13:55:25 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d66d2a4148987acab6ef1f586ee019097ef1d1e9 [^]
Fixes issue 33968: Wrong costs calculated with Backdated Transactions
CumStock and CumCost will not be calculated in case there is a cost adjustment.
---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
|
|
|
(0090893)
|
hgbot
|
2016-10-26 11:52
|
|
|
|
(0090894)
|
hgbot
|
2016-10-26 11:52
|
|
Repository: erp/devel/pi
Changeset: 5f40df94e94e554aabc270a079a6a3eb50d86a39
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 19 13:55:25 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f40df94e94e554aabc270a079a6a3eb50d86a39 [^]
Fixes issue 33968: Filter by costing transaction instead of current transaction
Filter by costing transaction instead of current transaction when existsCumulatedStockOnTrxDate or existsCumulatedValuationOnTrxDate in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0090895)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: 2cd8d93344f8f42c5e75a197e81e5459a5d1e27a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 19 14:53:39 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2cd8d93344f8f42c5e75a197e81e5459a5d1e27a [^]
Related to issue 33968: Retrieve costing transaction only once
Retrieve costing transaction only once in CostAdjustmentUtils.getStockOnTransactionDate, CostAdjustmentUtils.getValuedStockOnTransactionDate, CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090896)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: deff2af561180f6db2fd0d6de8b0eae8472f4a23
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Sep 19 13:55:25 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/deff2af561180f6db2fd0d6de8b0eae8472f4a23 [^]
Fixes issue 33968: Add movementdate filter in CostAdjustmentUtils in case BDT
Add movementdate filter in case costing rule allows backdated transactions in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0090897)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: ca6556a420720a7389ce15383cfc299dba71fec9
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 19 14:53:39 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ca6556a420720a7389ce15383cfc299dba71fec9 [^]
Related to issue 33968: Rename movementdate and dateFrom parameters
Rename movementdate and dateFrom parameters to cmvtdate and ctrxdate and use costing transaction trxprocessdate instead of costing starting date in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0090898)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: b6192a72cbba54782546d51450fa4d59125d55cb
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Sep 20 18:27:30 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b6192a72cbba54782546d51450fa4d59125d55cb [^]
Fixes issue 33968: Use getLastCumulatedCosting instead of getProductCost
Use AverageAlgorithm.getLastCumulatedCosting instead of AverageAlgorithm.getProductCost to retrieve last costing entry with cumulated values in CostAdjustmentUtils.getStockOnTransactionDate, CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090899)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: e711b068ea90a2d0ce0dab98b0584103d3d7ecbf
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 19:01:51 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e711b068ea90a2d0ce0dab98b0584103d3d7ecbf [^]
Related to issue 33968: Avoid API change
Add cumcost not null restriction and retrieve unique result in AverageAlgorithm.getLastCumulatedCosting.
Avoid API change by calculating correct date outside the method and removing unneeded transaction parameter in CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock.
Use AverageAlgorithm.getLastCumulatedCosting also in CostAdjustmentUtils.getValuedStockOnTransactionDate.
Call to AverageAlgorithm.getLastCumulatedCosting with movementdate or trxprocessdate depending on areBackdatedTrxFixed in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090900)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: 05a2c5a0d1275bb5e913ac541f39a8b2c195844f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 19:40:33 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/05a2c5a0d1275bb5e913ac541f39a8b2c195844f [^]
Related to issue 33968: Return costing cumulated values if trx is costing trx
Return costing cumulated values if trx is costing trx in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0090901)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: 61f70f49b80946bb3985d8d8a9e06ad2a063caa0
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Sep 20 19:49:10 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/61f70f49b80946bb3985d8d8a9e06ad2a063caa0 [^]
Fixes issue 33968: Truncate costing rule fix backdated from date
Truncate costing rule fix backdated from date when compering it with transaction movement date in CostingServer.java.
---
M src/org/openbravo/costing/CostingServer.java
---
|
|
|
(0090902)
|
hgbot
|
2016-10-26 11:53
|
|
Repository: erp/devel/pi
Changeset: 528ed62798daf0f90915760b595ab67766387417
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 20:05:45 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/528ed62798daf0f90915760b595ab67766387417 [^]
Related to issue 33968: Truncate also transaction movement date
Truncate also transaction movement date when compering it with costing rule fix backdated from date in CostingServer.java.
Truncate also transaction movement date and costing rule fix backdated from date for costing rules with standard algorithm.
---
M src/org/openbravo/costing/CostingServer.java
---
|
|
|
(0090903)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: 353d8721b32b0be15d0ac87ff51757c0b81112b2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Sep 20 20:59:27 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/353d8721b32b0be15d0ac87ff51757c0b81112b2 [^]
Fixes issue 33968: Revert negative adjustment if needed by BDT
Revert negative adjustment when a backdated transaction turns negative stock into positive stock.
---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
|
|
|
(0090904)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: 35bfe769e1e67db563f889a5e538020a29279273
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 21:05:21 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/35bfe769e1e67db563f889a5e538020a29279273 [^]
Related to issue 33968: Move getNegativeStockAdjustments method
Move AverageCostAdjustment.getNegativeStockAdjustments method to the end of the file and add documentation.
---
M src/org/openbravo/costing/AverageCostAdjustment.java
---
|
|
|
(0090905)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: 742ee19c4ecd213930dda39033c6d6df769f9e7f
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Sep 20 20:29:15 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/742ee19c4ecd213930dda39033c6d6df769f9e7f [^]
Fixes issue 33968: Fix rounding issue when cumulate stock has many decimals
Round cumcost and cumstock to currency cost precision before divide them to calculate cost to avoid rounding issues in CostAdjustmentUtils.getStockOnTransactionDate, CostAdjustmentUtils.getValuedStockOnTransactionDate, CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingServer.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090906)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: cd566f557bd63ab0acf520dd2b03d8b3582a24ff
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 20:53:11 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cd566f557bd63ab0acf520dd2b03d8b3582a24ff [^]
Related to issue 33968: Send parameters in order
Send parameters in order, first currency and then costing, to CostAdjustmentUtils.getStockOnTransactionDate and CostingUtils.getCurrentStock.
Round also cumstock and cumcost when transaction is the costing transaction.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090907)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: 14bc76dba26df0ffe3cc99857c362c7f0d5d3f16
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 20 22:20:32 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14bc76dba26df0ffe3cc99857c362c7f0d5d3f16 [^]
Related to issue 33968: Avoid another API change
Use client or organization currency to round cumstock and cumcost, to avoid send currency to CostAdjustmentUtils.getStockOnTransactionDate and CostingUtils.getCurrentStock and avoid the API change.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingServer.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090908)
|
hgbot
|
2016-10-26 11:54
|
|
|
|
(0090909)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: b11822652ce5d76ca59a8625d6d59800f076dcd6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 27 13:24:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b11822652ce5d76ca59a8625d6d59800f076dcd6 [^]
Related to issue 33968: Use cumulated values when movement date is the same
Use also cumulated values in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate methods when trx and ctrx movementdate is the same.
Also, truncate movementdate before comparing it.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
---
|
|
|
(0090910)
|
hgbot
|
2016-10-26 11:54
|
|
|
|
(0090911)
|
hgbot
|
2016-10-26 11:54
|
|
Repository: erp/devel/pi
Changeset: 12db641af792d46852af547b4bdf758b8d56bdac
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 28 13:57:03 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/12db641af792d46852af547b4bdf758b8d56bdac [^]
Related to issue 33968: Make an API change
Add MaterialTransaction trx parameter to CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock methods.
Also, remove product and date unneeded parameters and add areBackdatedTrxFixed parameter to avoid get again the costingRule.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090912)
|
hgbot
|
2016-10-26 11:55
|
|
Repository: erp/devel/pi
Changeset: 45f2a306bf715a5bbc8f53aa1107374fed25078f
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 28 14:12:00 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/45f2a306bf715a5bbc8f53aa1107374fed25078f [^]
Related to issue 33968: Make another API change
Send currency to CostAdjustmentUtils.getStockOnTransactionDate and CostingUtils.getCurrentStock.
---
M src/org/openbravo/costing/AverageAlgorithm.java
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingServer.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090913)
|
hgbot
|
2016-10-26 11:55
|
|
Repository: erp/devel/pi
Changeset: ff578582c72c0fd2c9be588f3d984086c19e5679
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Sep 28 14:16:44 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff578582c72c0fd2c9be588f3d984086c19e5679 [^]
Related to issue 33968: Exclude M+ in case M- also in CostAdjustmentUtils
Exclude M+ in case M- also in CostAdjustmentUtils.getStockOnTransactionDate and CostAdjustmentUtils.getValuedStockOnTransactionDate as it is done in CostingUtils.getCurrentStock and CostingUtils.getCurrentValuedStock.
---
M src/org/openbravo/costing/CostAdjustmentUtils.java
M src/org/openbravo/costing/CostingUtils.java
---
|
|
|
(0090914)
|
hgbot
|
2016-10-26 11:55
|
|
|
|
(0090915)
|
hgbot
|
2016-10-26 11:58
|
|
|
|
(0090918)
|
hgbot
|
2016-10-26 12:49
|
|
|
|
(0090919)
|
hgbot
|
2016-10-26 12:49
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|