Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033939Retail ModulesWeb POSpublic2016-09-09 12:542016-12-16 08:41
Reporterumartirena 
Assigned Tojorge-garcia 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033939: SER QA 1790 Wrong remaining to pay amount when paying with multicurrency
DescriptionWrong remaining to pay amount when paying with multicurrency
Steps To ReproduceIn https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1#login: [^]

 * Click on "Layaway this Receipt"
 * Add a product: "Avalanche transceiver"
 * Go to payment window
 * Pay 100 in USA Cash
 * Click on cash payment method and see that remaining to pay is 74.42€
 * Click on Layaway, it will be synchronized to the backend.
 * Retrieve the layaway
 * Go to payments window. Realize that remaining to pay is 74.43€, which is wrong.
Proposed SolutionDon't recalculate payments coming from backend.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0031279 closed mario_castello [SERQA 332] When opening a ticket payed with USACash, the paid amount isn't correctly loaded 
depends on backport 0034712RR16Q4 closed jorge-garcia SER QA 1790 Wrong remaining to pay amount when paying with multicurrency 
Attached Filesdiff 33939posterminal.diff (2,911) 2016-10-04 11:28
https://issues.openbravo.com/file_download.php?file_id=9888&type=bug
diff 33939test.diff (4,907) 2016-10-04 11:29
https://issues.openbravo.com/file_download.php?file_id=9889&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-09-09 12:54umartirenaNew Issue
2016-09-09 12:54umartirenaAssigned To => Retail
2016-09-09 12:54umartirenaTriggers an Emergency Pack => No
2016-09-09 12:54umartirenaRelationship addedrelated to 0031279
2016-09-09 13:34umartirenaSummaryWrong remaining to pay amount when paying with multicurrency => SER QA 1774 Wrong remaining to pay amount when paying with multicurrency
2016-09-12 13:25umartirenaResolution time => 1474581600
2016-09-21 17:00VictorVillarResolution time1474581600 => 1475100000
2016-09-21 17:00VictorVillarSummarySER QA 1774 Wrong remaining to pay amount when paying with multicurrency => SER QA 1790 Wrong remaining to pay amount when paying with multicurrency
2016-09-26 10:55VictorVillarResolution time1475100000 => 1475445600
2016-09-27 11:48jorge-garciaStatusnew => scheduled
2016-09-27 11:48jorge-garciaAssigned ToRetail => jorge-garcia
2016-10-04 11:28jorge-garciaFile Added: 33939posterminal.diff
2016-10-04 11:29jorge-garciaFile Added: 33939test.diff
2016-10-20 10:51hgbotCheckin
2016-10-20 10:51hgbotNote Added: 0090715
2016-10-20 10:51hgbotStatusscheduled => resolved
2016-10-20 10:51hgbotResolutionopen => fixed
2016-10-20 10:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef307311193872c449bf72e21bd70b7329244913 [^]
2016-10-20 10:51hgbotCheckin
2016-10-20 10:51hgbotNote Added: 0090716
2016-10-20 16:00jorge-garciaNote Added: 0090724
2016-10-20 16:00jorge-garciaStatusresolved => new
2016-10-20 16:00jorge-garciaResolutionfixed => open
2016-10-26 09:05jorge-garciaStatusnew => scheduled
2016-10-27 08:41hgbotCheckin
2016-10-27 08:41hgbotNote Added: 0090935
2016-10-27 09:09jorge-garciaStatusscheduled => resolved
2016-10-27 09:09jorge-garciaFixed in Version => RR17Q1
2016-10-27 09:09jorge-garciaResolutionopen => fixed
2016-10-27 12:57marvintmReview Assigned To => marvintm
2016-10-27 12:57marvintmStatusresolved => closed
2016-12-09 12:16OrekariaStatusclosed => new
2016-12-09 12:16OrekariaResolutionfixed => open
2016-12-09 12:16OrekariaFixed in VersionRR17Q1 =>
2016-12-09 12:16OrekariaStatusnew => scheduled
2016-12-09 12:17OrekariaStatusscheduled => resolved
2016-12-09 12:17OrekariaFixed in Version => RR17Q1
2016-12-09 12:17OrekariaResolutionopen => fixed
2016-12-09 12:17OrekariaStatusresolved => closed
2016-12-09 14:57hgbotCheckin
2016-12-09 14:57hgbotNote Added: 0092245
2016-12-09 14:57hgbotCheckin
2016-12-09 14:57hgbotNote Added: 0092247
2016-12-09 15:20hgbotCheckin
2016-12-09 15:20hgbotNote Added: 0092261
2016-12-16 08:41hgbotCheckin
2016-12-16 08:41hgbotNote Added: 0092453

Notes
(0090715)
hgbot   
2016-10-20 10:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ef307311193872c449bf72e21bd70b7329244913
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 19 09:55:28 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ef307311193872c449bf72e21bd70b7329244913 [^]

Fixed issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The solution is to not recalculate the value paid in other currency. For that,
it’s necessary to use the data stored in the transaction amount from the
payment.

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0090716)
hgbot   
2016-10-20 10:51   
Repository: tools/automation/pi-mobile
Changeset: a67a2fcbc816fd4bf23d2a8297812b50c1759878
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:39:50 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a67a2fcbc816fd4bf23d2a8297812b50c1759878 [^]

Verifies issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

Added test I33939_WrongRemainingAmtWithMultiCurrency.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I33939_WrongRemainingAmtWithMultiCurrency.java
---
(0090724)
jorge-garcia   
2016-10-20 16:00   
The test CancelAndRplcOfCancelAndRplc has an annotation associated @TestAnnotations(waitFixOf = 33939) and it's failing in try-retail
(0090935)
hgbot   
2016-10-27 08:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1e66343cb52ad4945906eaf605a4561372e3137d
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 21 13:45:58 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1e66343cb52ad4945906eaf605a4561372e3137d [^]

Related to issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The financial account selected to use in cancel and replace has changed. Now the
query searches for those financial account with the same currency as defined at
organization level.

The second change use the previous flow to generate the information of the
payments in case the order is a cancel and replace ticket. In the rest of the
cases, the information of the payments are read directly from the real payment
(in it’s original currency).

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0092245)
hgbot   
2016-12-09 14:57   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 199b31927b19b08d377cf8e8d817d87990e10130
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 19 09:55:28 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/199b31927b19b08d377cf8e8d817d87990e10130 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The solution is to not recalculate the value paid in other currency. For that,
it’s necessary to use the data stored in the transaction amount from the
payment.

---
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0092247)
hgbot   
2016-12-09 14:57   
Repository: retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal
Changeset: 3f15d8c4c8ae388d65b438e945007854fb829b4b
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Oct 21 13:45:58 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/org.openbravo.retail.posterminal/rev/3f15d8c4c8ae388d65b438e945007854fb829b4b [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

The financial account selected to use in cancel and replace has changed. Now the
query searches for those financial account with the same currency as defined at
organization level.

The second change use the previous flow to generate the information of the
payments in case the order is a cancel and replace ticket. In the rest of the
cases, the information of the payments are read directly from the real payment
(in it’s original currency).

---
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0092261)
hgbot   
2016-12-09 15:20   
Repository: retail/backports/3.0RR16Q4/pi-mobile
Changeset: 61ef72900beea36ddba860d12d0901f941874338
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:39:50 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q4/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

Added test I33939_WrongRemainingAmtWithMultiCurrency.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I33939_WrongRemainingAmtWithMultiCurrency.java
---
(0092453)
hgbot   
2016-12-16 08:41   
Repository: tools/automation/pi-mobile
Changeset: 61ef72900beea36ddba860d12d0901f941874338
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Oct 03 17:39:50 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/61ef72900beea36ddba860d12d0901f941874338 [^]

Fixed issue 34712, backport of issue 33939: SER QA 1790 Wrong remaining to pay amount when paying
with multicurrency

Added test I33939_WrongRemainingAmtWithMultiCurrency.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I33939_WrongRemainingAmtWithMultiCurrency.java
---