Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033887 | Openbravo ERP | Z. Others | public | 2016-09-02 12:06 | 2016-09-20 02:11 |
|
| Reporter | maite | |
| Assigned To | markmm82 | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0PR16Q4 | |
| Merge Request Status | |
| Review Assigned To | aferraz |
| OBNetwork customer | |
| Web browser | |
| Modules | Advanced Payables and Receivables Mngmt |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033887: GL Item accounting dimensions information should be maintained when posting Payment documents |
| Description | In case Payment document has business partner set in payment's header and GL Item line is included setting different business partner, then accounting entry is generated for header's business partner instead of line's business partner |
| Steps To Reproduce | 1. Access Sales Invoice window and select any invoice set as Paid=NO
2. Run "Add payment" process, add glitem line setting different business partner that invoice's partner
3. Access created payment in and run "Post" process. Review Accounting tab and realize that gl item amount is referencing invoice's header business partner instead of business partner set when adding gl item line |
| Proposed Solution | accounting dimensions information of gl item lines should be maintained when posting the payment |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-09-02 12:06 | maite | New Issue | |
| 2016-09-02 12:06 | maite | Assigned To | => Triage Finance |
| 2016-09-02 12:06 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2016-09-02 12:06 | maite | Resolution time | => 1474063200 |
| 2016-09-02 12:06 | maite | Triggers an Emergency Pack | => No |
| 2016-09-02 12:07 | maite | Issue Monitored: networkb | |
| 2016-09-08 10:55 | aferraz | Assigned To | Triage Finance => markmm82 |
| 2016-09-08 16:34 | markmm82 | Status | new => scheduled |
| 2016-09-15 16:39 | markmm82 | Note Added: 0089991 | |
| 2016-09-19 12:54 | hgbot | Checkin | |
| 2016-09-19 12:54 | hgbot | Note Added: 0090060 | |
| 2016-09-19 12:54 | hgbot | Status | scheduled => resolved |
| 2016-09-19 12:54 | hgbot | Resolution | open => fixed |
| 2016-09-19 12:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fa17d173e3ce254713c882210c5b6593c399385c [^] |
| 2016-09-19 12:54 | hgbot | Checkin | |
| 2016-09-19 12:54 | hgbot | Note Added: 0090061 | |
| 2016-09-19 12:57 | aferraz | Review Assigned To | => aferraz |
| 2016-09-19 12:57 | aferraz | Note Added: 0090062 | |
| 2016-09-19 12:57 | aferraz | Status | resolved => closed |
| 2016-09-19 12:57 | aferraz | Fixed in Version | => 3.0PR16Q4 |
| 2016-09-20 02:11 | hudsonbot | Checkin | |
| 2016-09-20 02:11 | hudsonbot | Note Added: 0090094 | |
| 2016-09-20 02:11 | hudsonbot | Checkin | |
| 2016-09-20 02:11 | hudsonbot | Note Added: 0090095 | |
|
Notes |
|
|
|
1. Access Sales Invoice window and select any invoice set as Paid=NO
2. Run "Add payment" process, add glitem line setting different business partner that invoice's partner
3. Access created payment in and run "Post" process. Review Accounting tab and realize that gl item amount is referencing business partner set when adding gl item line instead of invoice's header business partner |
|
|
|
(0090060)
|
|
hgbot
|
|
2016-09-19 12:54
|
|
Repository: erp/devel/pi
Changeset: fa17d173e3ce254713c882210c5b6593c399385c
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Sep 14 19:39:08 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/fa17d173e3ce254713c882210c5b6593c399385c [^]
Fixes issue 33887: GLItem accounting dimensions maintained when posting Payment
In case Payment document has business partner set in payment's header and GL Item line is included setting different business partner, then accounting entry is generated for line's business partner instead of header's business partner.
---
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
|
|
|
|
(0090061)
|
|
hgbot
|
|
2016-09-19 12:54
|
|
Repository: erp/devel/pi
Changeset: 7237a9b65b09c6e8faa0939273c998c576e84f03
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 19 12:53:30 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7237a9b65b09c6e8faa0939273c998c576e84f03 [^]
Related to issue 33887: Code review improvements
- Remove unnecessary parenthesis.
- Add paymentDetail.getFINPaymentScheduleDetailList().get(0).getOrderPaymentSchedule() != null check to avoid NPE.
---
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|