Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0033884 | Openbravo ERP | 04. Warehouse management | public | 2016-09-02 11:34 | 2016-12-20 20:31 |
|
| Reporter | lorenzofidalgo | |
| Assigned To | alekosmp86 | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | pi | |
| Target Version | | Fixed in Version | 3.0PR17Q1 | |
| Merge Request Status | |
| Review Assigned To | markmm82 |
| OBNetwork customer | |
| Web browser | Mozilla Firefox |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0033884: Warning is shown using "Manage Reservation" feature |
| Description | Manage Reservation feature, shown through "Enable Stock Reservation" preference, show the following warning message when is used:
"WARN org.openbravo.client.application.process.BaseProcessActionHandler - Process Manage Reservation Pick and Edit is marked as Grid Legacy, you should consider migrating it to prevent parameter conversion"
Each time "Manage Reservation" process is clicked or something related is clicked, that Warning message is being shown.
Currently, this is showing the automated tests as Unstable.
|
| Steps To Reproduce | 0-It is required to test it in localhost with Eclipse capturing the warning messages of the localhost ERP to check the warning message.
1-Login ERP as Openbravo and go to "Preference" window. Create a new record with the following values:
--
Value: Y
Property: "Enable Stock Reservations".
Visible at User: QAAdmin.
--
Save the record.
2-Logout and login as QAAdmin.
3-Go to "Sales Order" window and create a new record. Complete that record and add a new Line.
4-Book the just created "Sales Order".
5-Select the just created Line (Line tab).
6-Realise "Manage Reservation" process is shown. Click it and check Eclipse ERP console is showing "WARN org.openbravo.client.application.process.BaseProcessActionHandler - Process Manage Reservation Pick and Edit is marked as Grid Legacy, you should consider migrating it to prevent parameter conversion".
7-Besides, in the just shown Popup, click "DONE" and realise the message is shown again.
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0031426 | RR16Q1 | closed | guilleaer | Retail Modules | Warn is shown in log when Process POS Terminal Unlink is used | | related to | feature request | 0025995 | 3.0PR14Q3 | closed | AugustoMauch | Openbravo ERP | Parameter Windows Phase III |
|
| Attached Files |  ManageReservationGridLegacy.png (193,352) 2016-09-02 11:34
https://issues.openbravo.com/file_download.php?file_id=9775&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2016-09-02 11:34 | lorenzofidalgo | New Issue | |
| 2016-09-02 11:34 | lorenzofidalgo | Assigned To | => Triage Finance |
| 2016-09-02 11:34 | lorenzofidalgo | File Added: ManageReservationGridLegacy.png | |
| 2016-09-02 11:34 | lorenzofidalgo | Web browser | => Mozilla Firefox |
| 2016-09-02 11:34 | lorenzofidalgo | Modules | => Core |
| 2016-09-02 11:34 | lorenzofidalgo | Triggers an Emergency Pack | => No |
| 2016-09-02 11:34 | lorenzofidalgo | Relationship added | related to 0031426 |
| 2016-12-14 15:33 | aferraz | Web browser | Mozilla Firefox => Mozilla Firefox |
| 2016-12-14 15:33 | aferraz | Assigned To | Triage Finance => platform |
| 2016-12-14 15:42 | alostale | Relationship added | related to 0025995 |
| 2016-12-14 15:49 | alostale | Note Added: 0092359 | |
| 2016-12-14 15:50 | alostale | Assigned To | platform => Triage Finance |
| 2016-12-15 09:02 | aferraz | Assigned To | Triage Finance => alekosmp86 |
| 2016-12-15 16:51 | alekosmp86 | Status | new => scheduled |
| 2016-12-19 16:51 | alekosmp86 | Note Added: 0092788 | |
| 2016-12-20 10:22 | psanjuan | Note Added: 0092828 | |
| 2016-12-20 10:44 | psanjuan | Note Added: 0092830 | |
| 2016-12-20 10:54 | psanjuan | Note Edited: 0092788 | bug_revision_view_page.php?bugnote_id=0092788#r14067 |
| 2016-12-20 10:58 | psanjuan | Note Edited: 0092830 | bug_revision_view_page.php?bugnote_id=0092830#r14069 |
| 2016-12-20 11:06 | psanjuan | Note Edited: 0092830 | bug_revision_view_page.php?bugnote_id=0092830#r14070 |
| 2016-12-20 11:06 | psanjuan | Note Added: 0092832 | |
| 2016-12-20 15:22 | hgbot | Checkin | |
| 2016-12-20 15:22 | hgbot | Note Added: 0092858 | |
| 2016-12-20 15:22 | hgbot | Status | scheduled => resolved |
| 2016-12-20 15:22 | hgbot | Resolution | open => fixed |
| 2016-12-20 15:22 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ccb0950a744693fd08675f2f245e6f9fa49c82f5 [^] |
| 2016-12-20 15:29 | markmm82 | Review Assigned To | => markmm82 |
| 2016-12-20 15:29 | markmm82 | Note Added: 0092859 | |
| 2016-12-20 15:29 | markmm82 | Status | resolved => closed |
| 2016-12-20 15:29 | markmm82 | Fixed in Version | => 3.0PR17Q1 |
| 2016-12-20 20:31 | hudsonbot | Checkin | |
| 2016-12-20 20:31 | hudsonbot | Note Added: 0092876 | |
|
Notes |
|
|
|
When implementing 3rd phase of parameter windows, process definition was extended to support multiple parameters, before process definitions allowed a single grid parameter.
To support backwards compatibility old processes where flagged as isgridlegacy, when they are executed this warn is logged. The idea was to allow a smooth transition to new format.
These processes should be adapted to receive parameters in the new format so that they can be unflagged.
The list of process definitions to be checked is:
select name from obuiapp_process where isgridlegacy ='Y' order by 1
CopyProcessPlanVersion
Create Purchase Order Lines
Doubtful Debt Pick and Edit
Grant Portal Access
Manage Prereservation Pick and Edit
Manage Reservation Pick and Edit
Manage Stock Reservation Pick and Edit
Manage Variants
Modify Payment In Plan
Modify Payment Out Plan
Open Close Periods
Reserved Good Movement Pick and Edit
RM Receipt Pick and Edit Lines
RM Shipment Pick and Edit Lines
Set New Currency
UpdateInvariants |
|
|
|
(0092788)
|
|
alekosmp86
|
2016-12-19 16:51
(edited on: 2016-12-20 10:54) |
|
Test Plan 1 ("Manage Reservation Pick and Edit" and "Manage Stock Reservation Pick and Edit")
Log in as F&B International Group Admin
Go to Preference screen
Create a new record
Organization: *
Property: Enable Stock Reservation
Value: Y
Save the record
Log out and log back in
Go to Sales Order screen
Create a new record
Organization: F&B Espana - Region Norte
BP: Hoteles Buenas Noches S.A
Save the record
Go to Lines tab
Add a new record
Product: Limonada 0,5L
Ordered Quantity: 10
Tax: Ventas exentas
Save the record
Book the order
Back in the Lines tab, select the line just created.
Notice the "Manage Reservation" button is shown. Click on it. Go to Eclipse IDE and notice there's no warning shown in the console.
Test Plan 2 ("Manage Variants")
Log in as F&B International Group Admin
Go to Product Characteristics screen
Create a new record
Organization: *
Name: Color
Variant: checked
Save the record
Go to Value tab
Create a new record
Name: Red
Save the record
Create a new record
Name: Blue
Save the record
Go to Product screen
Create a new record
Organization: *
Search Key/Name: Test Product
IsGeneric: checked
Save the record
Go to Characteristics tab
Create a new record
Characteristic: Color (previously created)
Variant: checked
Save the record
Run "Create Variants" process. Once the variants are created, run "Manage Variants" process. Select all the characteristics listed and click "Done".
Go to Eclipse IDE, notice there's no warning message in console.
Test Plan 3 ("Create Purchase Order Lines")
Log in as F&B International Group Admin
Go to Purchase Order screen
Create a new record
Organization: F&B España - Region Norte
BP: Bebidas Alegres S.A
Save the record
Go to Lines tab
Run "Create Lines" process
Select "Cerveza Ale 0,5L"
Fill Ordered Quantity field with value 10
Click Done.
Go to Eclipse IDE, notice there's no warning message in console.
Test Plan 4 ("Reserved Good Movement Pick and Edit")
Log in as F&B International Group Admin
Go to Sales Order screen
Create a new record
Organization: F&B Espana - Region Norte
BP: Hoteles Buenas Noches S.A
Save the record
Go to Lines tab
Add a new record
Product: Limonada 0,5L
Ordered Quantity: 10
Tax: Ventas exentas
Save the record
Book the order
Back in the Lines tab, select the line just created.
Click on the "Manage Reservation" button. A stock reservation is created for this product.
Go to Stock Reservation screen
Select the record with the previous product.
Run the "Goods Movement" process.
Select a line with Reserved Quantity > 0. Define a new Storage Bin.
Enter a Movement Quantity. Click Done.
Go to Eclipse IDE, notice there's no warning message in console.
|
|
|
|
|
|
|
|
(0092830)
|
|
psanjuan
|
2016-12-20 10:44
(edited on: 2016-12-20 11:06) |
|
Test Plan 5 - Open Close Periods
Go to Open/Close Period Control window.
Select US Calendar and 2014 Year.
Select Jan-14 period. Click Close Period button.
Select the option Close.
Verify that the period is closed.
Go to Eclipse and verify that no warning is shown.
Select Jan-14 period. Click Close Period button.
Select the option Open.
Verify that the period is open.
Go to Eclipse and verify that no warning is shown.
Test Plan 6 - Set New Currency
Go to Business partner window and create a new one with below setup for F&B España:
Search Key = Name = Customer Test
Go to Customer tab and enter below data:
Price List = Tarifa de Ventas
Payment Method = Transferencia
Payment Terms = 30 days
Financial account = Cuenta de Banco
Go to Location tab and enter a location in Spain.
Go to payment in window and enter a credit payment in for the customer of 100.00 EUR.
Go back to business partner window and press on Set New Currency process.
Check that the currency shown is EUR. Change it to USD.
Remove the check "Use Default conversion rate". Enter a Rate of 1.5, for instance. Select any G/L item.
Press Done.
Verify customer balance has changed to -150.00
Go to Eclipse and verify that no warning is shown.
|
|
|
|
|
Test plan above verified.
Issue can be closed. |
|
|
|
(0092858)
|
|
hgbot
|
|
2016-12-20 15:22
|
|
Repository: erp/devel/pi
Changeset: ccb0950a744693fd08675f2f245e6f9fa49c82f5
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Fri Dec 16 10:32:07 2016 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/ccb0950a744693fd08675f2f245e6f9fa49c82f5 [^]
Fixes issue 33884: Warning is shown using "Manage Reservation" feature
When using the Manage Reservation feature, shown through "Enable Stock Reservation"
preference, the following warning message was shown:
"WARN org.openbravo.client.application.process.BaseProcessActionHandler - Process
Manage Reservation Pick and Edit is marked as Grid Legacy, you should consider
migrating it to prevent parameter conversion". The problem is that this process is
flagged as "islegacygrid" which is an option to support backward compatibility with
old processes. Currently, the Manage Reservation feature and the other ones requested
in the issue description have been adapted to receive parameters in the new format,
this means that they have been unflagged, and the way to get the values from the grid
in its respective ActionHandler class has been updated. Before the change, the grid lines'
data was taken from the "_selection" array in the json sent to the actionhandler, now
the method was changed so the data is now taken from the "_params" object, which
has a "grid" property, in which is stored the "_selection" array, which effectively
have the selected lines of the grid. The following processes have been adapted:
CopyProcessPlanVersion
Create Purchase Order Lines
Doubtful Debt Pick and Edit
Grant Portal Access
Manage Prereservation Pick and Edit
Manage Reservation Pick and Edit
Manage Stock Reservation Pick and Edit
Manage Variants
Modify Payment In Plan
Modify Payment Out Plan
Open Close Periods
Reserved Good Movement Pick and Edit
RM Receipt Pick and Edit Lines
RM Shipment Pick and Edit Lines
Set New Currency
UpdateInvariants
---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/DoubtFulDebtPickEditLines.java
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/common/actionhandler/ManagePrereservationActionHandler.java
M src/org/openbravo/common/actionhandler/ManageReservationActionHandler.java
M src/org/openbravo/common/actionhandler/OrderCreatePOLines.java
M src/org/openbravo/common/actionhandler/RMInOutPickEditLines.java
M src/org/openbravo/common/actionhandler/RMShipmentPickEditLines.java
M src/org/openbravo/common/actionhandler/ReservedGoodMovementActionHandler.java
M src/org/openbravo/materialmgmt/actionhandler/ManageVariants.java
---
|
|
|
|
|
|
|
|
|
|