Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033877Openbravo ERP02. Master data managementpublic2016-09-01 18:452018-02-22 17:22
ngarcia 
AtulOpenbravo 
immediateminoralways
closedfixed 
5
 
3.0PR16Q4 
aferraz
Core
Production - QA Approved
2016-04-14
3.0PR16Q3
https://code.openbravo.com/erp/devel/pi/rev/51adf3f34dbe [^]
No
0033877: Accounting default values not transferred from BP Category to Business Partner if the schema is assigned to a child organization
Accounting default values not transferred from BP Category to Business Partner if the schema is assigned to a child organization
As group admin role:
   Check 'Customer - Tier 1' Business Partner Category has Accounting defined for F&B España, S.A. US/A/Euro and F&B International Group US/A/US Dollar general ledgers
   Create a Business Partner for *
   Check no records are created in Customer - Accounting tab. This is wrong.
   Create a Business Partner for F&B International Group
   Check only the record associated to F&B International Group US/A/US Dollar is created. This is wrong
No tags attached.
depends on backport 00338913.0PR16Q3.2 closed AtulOpenbravo Accounting default values not transferred from BP Category to Business Partner if the schema is assigned to a child organization 
caused by defect 0032424 closed AtulOpenbravo New Account not created for Business Partner for organization F&B US, Inc. but works with F&B España, S.A 
related to design defect 0034847 new malsasua Unhomogeneous behavior when business partner is created: customer and employee accounting defaults 
Issue History
2016-09-01 18:45ngarciaNew Issue
2016-09-01 18:45ngarciaAssigned To => Triage Finance
2016-09-01 18:45ngarciaModules => Core
2016-09-01 18:45ngarciaResolution time => 1474495200
2016-09-01 18:45ngarciaTriggers an Emergency Pack => No
2016-09-01 18:46ngarciaRelationship addedcaused by 0032424
2016-09-01 18:53ngarciaIssue Monitored: networkb
2016-09-01 19:05heccamIssue Monitored: heccam
2016-09-02 14:42aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-09-02 14:43aferrazRegression level => Production - QA Approved
2016-09-02 14:43aferrazRegression date => 2016-04-14
2016-09-02 14:43aferrazRegression introduced in release => 3.0PR16Q3
2016-09-02 14:43aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/51adf3f34dbe [^]
2016-09-02 14:44aferrazStatusnew => scheduled
2016-09-04 20:47AtulOpenbravoNote Added: 0089718
2016-09-05 11:33psanjuanNote Added: 0089737
2016-09-05 12:09psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13041
2016-09-05 12:14psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13042
2016-09-05 12:15psanjuanNote Edited: 0089718bug_revision_view_page.php?bugnote_id=0089718#r13044
2016-09-05 12:17psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13045
2016-09-05 12:26psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13048
2016-09-05 12:29psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13049
2016-09-05 12:30psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13050
2016-09-05 12:30psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13051
2016-09-05 12:31psanjuanNote Edited: 0089737bug_revision_view_page.php?bugnote_id=0089737#r13052
2016-09-05 12:34psanjuanNote Added: 0089743
2016-09-05 12:39hgbotCheckin
2016-09-05 12:39hgbotNote Added: 0089745
2016-09-05 12:39hgbotStatusscheduled => resolved
2016-09-05 12:39hgbotResolutionopen => fixed
2016-09-05 12:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b1bad782acb0640abe719238c5d79820abfecde6 [^]
2016-09-05 12:40aferrazReview Assigned To => aferraz
2016-09-05 12:40aferrazNote Added: 0089746
2016-09-05 12:40aferrazStatusresolved => closed
2016-09-05 12:40aferrazFixed in Version => 3.0PR16Q4
2016-09-05 20:59hudsonbotCheckin
2016-09-05 20:59hudsonbotNote Added: 0089765
2016-10-07 20:46rqueraltaNote Added: 0090507
2017-01-04 09:58aferrazRelationship addedrelated to 0034847
2018-02-22 17:22hgbotCheckin
2018-02-22 17:22hgbotNote Added: 0102611

Notes
(0089718)
AtulOpenbravo   
2016-09-04 20:47   
(edited on: 2016-09-05 12:15)
Test Plan

- Login as Group Admin role:
- Check 'Customer - Tier 1' Business Partner Category has Accounting defined for F&B España, S.A. US/A/Euro and F&B International Group US/A/US Dollar general ledgers
- Create a Business Partner for * Organization.
- Check both the records associated to F&B International Group US/A/US Dollar and F&B España, S.A. US/A/Euro are created in Customer - Accounting tab.
- Create a Business Partner for F&B International Group Organization.
- Check both the records associated to F&B International Group US/A/US Dollar and F&B España, S.A. US/A/Euro are created.

Repeat Test Plan II for https://issues.openbravo.com/view.php?id=32424 [^]

(0089737)
psanjuan   
2016-09-05 11:33   
(edited on: 2016-09-05 12:31)
Test Plan:
Go to Organization window and check that:

* F&B International Group org is related to General Ledger "F&B International Group/USA Dollar".
* Children org "F&B US" is not related to any other general ledger but inherited one from its parent.
Same applies to its children org East and West
* Children org "F&B España" is related to another General Ledger "F&B España Euro", therefore this org has two general ledger related.
Same applies to its children org Norte and Sur.

* Go to the two General Ledgers (General Ledger configuration) and check both have set all default accounts.

* Go to Business Partner Category.
- Create a new one for F&B España, named "España". Check it inherits default ledger accounts from the two general ledgers in the accounting tab.
 Same applies to Norte and Sur organizations, while creating them..
- Create a new one for F&B US, named "US". Check it only inherits one that is the one related to F&B International Group USA dollar.
Same applies to East and West organizations, while creating them..
- Create a new one for (*) org. Check it inherits default ledger accounts from the two general ledgers in the accounting tab

Go to Business Partne window:

- Create a Business Partner for * Organization. Select BP Category created for *.
- Check both two records have been associated in the Accounting tab, one for each general ledger F&B International Group US/A/US Dollar and F&B España, S.A.

- Create a Business Partnr for * organization. Select the BP created for East org.
- Check there is only one records associated in the Accounting tab, one for each general ledger F&B International Group US/A/US Dollar.

- Create a Business Partner for F&B International Group Organization. Select Customer Tier 1 BP Category, created for F&B International.
- Check both two records have been associated in the Accounting tab, one for each general ledger F&B International Group US/A/US Dollar and F&B España, S.A.

- Create a Business Partner for F&B España Norte. Add the BP Category created for this organization.
- Check both two records have been associated in the Accounting tab, one for each general ledger F&B International Group US/A/US Dollar and F&B España, S.A.

- Create a Business Partner for East organization. Add the BP Category created for this organization.
- Check there is only one records associated in the Accounting tab, one for each general ledger F&B International Group US/A/US Dollar.

(0089743)
psanjuan   
2016-09-05 12:34   
Test plan above verified.
Issue can be code reviewed and closed.
(0089745)
hgbot   
2016-09-05 12:39   
Repository: erp/devel/pi
Changeset: b1bad782acb0640abe719238c5d79820abfecde6
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Sep 05 00:11:51 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b1bad782acb0640abe719238c5d79820abfecde6 [^]

Fixes issue 33877: Accounting default values not transferred from child orgs

While creating default accounting configuration for business partner, schema configuration is also checked for child organization if no configurartion exists for org or its parent org.

Default accounts will be created retrieving first the accounting schema of current organization, then from parent organizations and then from children organizations.

For example, in case we have different accounting schemas for F&B International, F&B España and F&B España Norte, when creating a business partner for each of these organizations the order will be the following:
F&B International: F&B International - F&B España - F&B España Norte
F&B España: F&B España - F&B International - F&B España Norte
F&B España Norte: F&B España Norte - F&B España - F&B International

---
M src-db/database/model/triggers/C_BPARTNER_TRG.xml
---
(0089746)
aferraz   
2016-09-05 12:40   
Code review OK
(0089765)
hudsonbot   
2016-09-05 20:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/87094da4670c [^]
Maturity status: Test
(0090507)
rqueralta   
2016-10-07 20:46   
Test Cases in Test Link

Url: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10183 [^]
Url: https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-10184 [^]
(0102611)
hgbot   
2018-02-22 17:22   
Repository: tools/automation/int
Changeset: f108478ccdf3d6500a6ec6e12ac0cf1a0c6f5e36
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Sun Oct 30 09:24:23 2016 -0400
URL: http://code.openbravo.com/tools/automation/int/rev/f108478ccdf3d6500a6ec6e12ac0cf1a0c6f5e36 [^]

Related to issue 33877: Added some automated tests

---
M src-test/com/openbravo/test/integration/erp/data/financial/accounting/setup/accountingschema/DefaultsData.java
M src-test/com/openbravo/test/integration/erp/data/generalsetup/enterprise/organization/OrganizationData.java
M src-test/com/openbravo/test/integration/erp/gui/financial/accounting/setup/generalledgerconfiguration/GeneralLedgerConfigurationTab.java
M src-test/com/openbravo/test/integration/erp/gui/financial/accounting/setup/generalledgerconfiguration/GeneralLedgerConfigurationWindow.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/BusinessPartnerWindow.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/CustomerTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/VendorCreditorTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartnersetup/businesspartnercategory/BusinessPartnerCategoryTab.java
M src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartnersetup/businesspartnercategory/BusinessPartnerCategoryWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/PRO_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/SAL_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/BusinessPartner.java
M src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartnersetup/businesspartnercategory/AccountingClassicScript.java
A src-test/com/openbravo/test/integration/erp/gui/financial/accounting/setup/generalledgerconfiguration/DefaultsTab.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/CustomerAccountingTab.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartner/VendorAccountingTab.java
A src-test/com/openbravo/test/integration/erp/gui/masterdata/businesspartnersetup/businesspartnercategory/AccountingTab.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/procurement/testsuites/PRO_Regressions/PRORegression33877.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/sales/testsuites/SAL_Regressions/SALRegression33877.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/CustomerAccountingClassicScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/CustomerAccountingScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorAccountingClassicScript.java
A src-test/com/openbravo/test/integration/erp/testscripts/masterdata/businesspartner/VendorAccountingScript.java
---