Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033860Retail ModulesWeb POSpublic2016-08-31 11:062016-09-19 18:55
Reporterairaceburu 
Assigned Tojorge-garcia 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in releaseRR16Q2
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033860: Sequence number is getting incremented when empty bills are deleted through end session
DescriptionSequence number is getting incremented when empty bills are deleted through end session with "Web POS Save Removed Tickets" preference set to 'Y'.

This is because that empty bill is also getting synchronized during end session and set as deleted in the ERP.
Steps To ReproduceLog in to Openbravo
Set "Web POS Save Removed Tickets" preference to 'Y'
Log in to Web POS
Complete a ticket
Write down the sequence number (The one of the new empty bill)
End Session
Log in again
(Notice that the sequence number has been incremented)
(If you log in to Openbravo and browse to the sales order window you will see the empty bill synchronized with the "Deleted" flag set to 'Y')
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0033861RR16Q3.2 closed jorge-garcia Sequence number is getting incremented when empty bills are deleted through end session 
depends on backport 0033862RR16Q2.3 closed jorge-garcia Sequence number is getting incremented when empty bills are deleted through end session 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-31 11:06airaceburuNew Issue
2016-08-31 11:06airaceburuAssigned To => Retail
2016-08-31 11:06airaceburuRegression introduced in release => RR16Q2.2
2016-08-31 11:06airaceburuTriggers an Emergency Pack => No
2016-08-31 11:17guillermogilResolution time => 1472767200
2016-08-31 11:17guillermogilRegression introduced in releaseRR16Q2.2 => RR16Q2
2016-08-31 11:17guillermogilPrioritynormal => immediate
2016-08-31 11:27jorge-garciaStatusnew => scheduled
2016-08-31 11:27jorge-garciaAssigned ToRetail => jorge-garcia
2016-09-12 08:47hgbotCheckin
2016-09-12 08:47hgbotNote Added: 0089889
2016-09-12 08:47hgbotStatusscheduled => resolved
2016-09-12 08:47hgbotResolutionopen => fixed
2016-09-12 08:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b27cd8263b018c8663a29ab1aef6350e56a01f27 [^]
2016-09-12 08:47hgbotCheckin
2016-09-12 08:47hgbotNote Added: 0089890
2016-09-13 13:40hgbotCheckin
2016-09-13 13:40hgbotNote Added: 0089916
2016-09-19 18:55marvintmReview Assigned To => marvintm
2016-09-19 18:55marvintmStatusresolved => closed

Notes
(0089889)
hgbot   
2016-09-12 08:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b27cd8263b018c8663a29ab1aef6350e56a01f27
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 06 17:42:41 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b27cd8263b018c8663a29ab1aef6350e56a01f27 [^]

Fixed issue 33860: Sequence number is getting incremented when empty bills
are deleted through end session

When a logout is done, in the standard flow, all the tickets present in that
moment are deleted even if the receipt has no lines and is completely new.

This is a problem when the preference to Save Delete Tickets is active.

The solution, is to delete all the tickets with a document sequence lower than
the last ticket with lines.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0089890)
hgbot   
2016-09-12 08:47   
Repository: tools/automation/pi-mobile
Changeset: a2a1f6504e090f80de92f2c858e1f8e08d89926f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 06 17:36:59 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a2a1f6504e090f80de92f2c858e1f8e08d89926f [^]

Verifies issue 33860: Sequence number is getting incremented when empty bills
are deleted through end session

Added test I33860_DontDeleteOrderWhenLogout.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33860_DontDeleteOrderWhenLogout.java
---
(0089916)
hgbot   
2016-09-13 13:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2521158b0fa33aa8edcb4f9e27d0ad9388abf9e9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 12 16:34:06 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2521158b0fa33aa8edcb4f9e27d0ad9388abf9e9 [^]

Related to issue 33860: Sequence number is getting incremented when empty bills
are deleted through end session

Delete some useless code.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---