Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033850Openbravo ERPA. Platformpublic2016-08-30 09:332016-12-16 18:38
ReporterJONHM 
Assigned ToNaroaIriarte 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket43440
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033850: Addresses are not filtered if region is not set
DescriptionIn Location/Address tab of [Business Partner] widow, the addresses are not filtered if region isn't set.
Steps To Reproduce1- Log in the ERP with the "F&B Admin" role.
2- Go to "Business Partner" window and select any record.
3- Go to the "Location/Address" subtab and create a new record.
4- Click on the "Location/Address" field amplifier.
5- Fill every record instead of "Region" and save the record.
6- In the "Location/Address" filter, write the name of the newly created location.
7- Realize that the filter is not working and the message "No items to show" is shown.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-30 09:33JONHMNew Issue
2016-08-30 09:33JONHMAssigned To => platform
2016-08-30 09:33JONHMOBNetwork customer => Yes
2016-08-30 09:33JONHMModules => Core
2016-08-30 09:33JONHMSupport ticket => 43440
2016-08-30 09:33JONHMTriggers an Emergency Pack => No
2016-09-06 13:06heccamIssue Monitored: heccam
2016-10-18 14:10alostaleStatusnew => acknowledged
2016-10-26 13:07NaroaIriarteAssigned Toplatform => NaroaIriarte
2016-11-16 16:53hgbotCheckin
2016-11-16 16:53hgbotNote Added: 0091606
2016-11-16 16:53hgbotStatusacknowledged => resolved
2016-11-16 16:53hgbotResolutionopen => fixed
2016-11-16 16:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/089aa21df4fb76296bd8a9c163ebb6ce85069288 [^]
2016-11-16 17:06NaroaIriarteReview Assigned To => alostale
2016-11-16 17:06NaroaIriarteSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=13787#r13787
2016-11-25 09:43alostaleNote Added: 0091814
2016-11-25 09:43alostaleStatusresolved => closed
2016-11-25 09:43alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:38hudsonbotCheckin
2016-12-16 18:38hudsonbotNote Added: 0092636

Notes
(0091606)
hgbot   
2016-11-16 16:53   
Repository: erp/devel/pi
Changeset: 089aa21df4fb76296bd8a9c163ebb6ce85069288
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Mon Nov 14 13:26:18 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/089aa21df4fb76296bd8a9c163ebb6ce85069288 [^]

Fixed issue 33850: The Location/Address filter was not working fine

The location/Address filter of the Location/Address subtab of the "Business Partner" tab was not working fine when trying to filter by Location/Addresses which had not a Region defined.
The problem was in the generated query, there was a concatenation with the region name, and when the region was null, all the result was null.
To fix this problem the coalesce funtion has been added to the query in the cases where it was not added. Now, if the value is null, as it is the case, the empty string will be get in the concatenation.

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0091814)
alostale   
2016-11-25 09:43   
code reviewed - tested: working both in Oracle and PostgreSQL
(0092636)
hudsonbot   
2016-12-16 18:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test