Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033831ModulesRemittancepublic2016-08-26 19:102016-09-13 15:41
Reportermarkmm82 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customer
Regression introduced in release
Summary0033831: It is necessary a refactor of some files in Remittance module to avoid warnings
DescriptionSome java class files in Remittance module are supressing warnings. It is necessary a refactor of this files to avoid warnings and replace the use of deprecated methods instead of ignoring them. This is the case of DocREMRemittance.java, DocREMRemittanceCancel.java and REM_RemittanceProcess.java.
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-26 19:10markmm82New Issue
2016-08-26 19:10markmm82Assigned To => markmm82
2016-08-26 19:11markmm82Statusnew => scheduled
2016-08-30 14:37psanjuanNote Added: 0089553
2016-08-30 15:53psanjuanNote Edited: 0089553bug_revision_view_page.php?bugnote_id=0089553#r12982
2016-08-30 15:54psanjuanNote Added: 0089555
2016-09-12 13:12hgbotCheckin
2016-09-12 13:12hgbotNote Added: 0089897
2016-09-13 10:02hgbotCheckin
2016-09-13 10:02hgbotNote Added: 0089905
2016-09-13 10:02hgbotStatusscheduled => resolved
2016-09-13 10:02hgbotResolutionopen => fixed
2016-09-13 10:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/5aaa168730192c7c894537ce0cdab8ad882613a9 [^]
2016-09-13 10:02hgbotCheckin
2016-09-13 10:02hgbotNote Added: 0089906
2016-09-13 10:02hgbotCheckin
2016-09-13 10:02hgbotNote Added: 0089907
2016-09-13 10:04aferrazReview Assigned To => aferraz
2016-09-13 10:04aferrazNote Added: 0089908
2016-09-13 10:04aferrazStatusresolved => closed
2016-09-13 15:41hudsonbotCheckin
2016-09-13 15:41hudsonbotNote Added: 0089919

Notes
(0089553)
psanjuan   
2016-08-30 14:37   
(edited on: 2016-08-30 15:53)
It has been verified:
- purchase related remittance complete flow including an order and an invoice.
- sales related remittance complete flow, including an order and an invoice.
- sales related remittance for discount complete flow, incluing and order and an invoice.
- Multi-currency remittance

Test Plan 1
1- Go to sales order and create a new one for F&B España, BP Alimentos. Select Remittance payment method.
2- Go to lines and select any product. Enter 100 units as ordered quantity, and change unit price to 1.00. Select any tax rate exempt for instance: Ventas exentas. Remove discounts if exists.
3- Change if needed Invoice Terms to Immediate.
4- Book the order therefore total gross amount of the order is 100.00.
5- Go to create a new Sales Invoice, select Remittance payment method and create a new one from the order just created.
6- Complete the invoice. Do not use credit if any.
7- Go to Remittance window. Create a new one by selecting Printable Remittance and by entering an expected date = 31-12-2016. Enter a Name.
8- Press Select Orders or Invoices and select the invoice just created. Process.
9- Click to the "process" button to process the remittance.
10- Notice the process is successfully.

Repeat same test as above for negative invoices. Repeat same test as above for negative invoices, and for orders. Settle and Protest the remittance. Check Undo. Posting check.

Test Plan 2
1- Go to purchase order and create a new one for F&B España, BP Bebidas Alegres. Select Remittance payment method.
2- Go to lines and select any product. Enter 100 units as ordered quantity, and change unit price to 1.00. Select any tax rate exempt for instance: Compras exentas. Remove discounts if exists.
3- Book the order therefore total gross amount of the order is 100.00.
4- Go to Purchase Invoice, select Remittance payment method and create a new one from the order just created.
5- Complete the invoice. Do not use credit if any.
6- Go to Remittance window. Create a new one by selecting Printable Remittance and by entering an expected date = 31-12-2016. Enter a Name.
7- Press Select Orders or Invoices and select the invoice just created.
8- Change the selection from Payment In to Payment Out and check that the invoice created is already selected. Process.
9- Click to the "process" button to process the remittance.
10- Notice the process is successfull and no error message is shown.

Repeat same test as above for negative invoices, and for orders. Settle and Protest the remittance. Check Undo. Posting check.
(0089555)
psanjuan   
2016-08-30 15:54   
Test plan above verified.

Issue can be code reviewed and closed.
(0089897)
hgbot   
2016-09-12 13:12   
Repository: erp/devel/pi
Changeset: 03bb4bfa60a1a6a08663df60aae224e255e8fc7a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 12 10:24:52 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/03bb4bfa60a1a6a08663df60aae224e255e8fc7a [^]

Related to issue 33831: Duplicate getPaymentDetailWriteOffAndAmount method

Duplicate getPaymentDetailWriteOffAndAmount method using List<String> as parameter instead of List<FIN_PaymentDetail>, in order to improve performance.

---
M src/org/openbravo/erpCommon/ad_forms/AcctServer.java
---
(0089905)
hgbot   
2016-09-13 10:02   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 5aaa168730192c7c894537ce0cdab8ad882613a9
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Aug 25 12:29:47 2016 -0400
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/5aaa168730192c7c894537ce0cdab8ad882613a9 [^]

Fixes issue 33831: Suppress warnings in Remittance module

Removed all warnings in DocREMRemittance.java, DocREMRemittanceCancel.java and REM_RemittanceProcess.java files of Remittance module. Changes includes:

Changes in DocREMRemittance.java:
- Replaced use of deprecated method getOrderedPaymentDetailList(Payment payment) with getOrderedPaymentDetailList(String paymentId) of FIN_Utility class.

Changes in DocREMRemittanceCancel.java changes:
- Replaced use of deprecated method setInvoice(Invoice invoice) with setInvoiceId(String invoiceId) of DocLine_FINPayment class.
- Replaced use of deprecated method setOrder(Order order) with setOrderId(String orderId) of DocLine_FINPayment class.

Changes in REM_RemittanceProcess.java changes:
- Removed all @SuppressWarnings("hiding") and @SuppressWarnings({ "hiding", "unchecked" }) annotations.
- Renamed some variables named "error" with "err", to avoid "The local variable error is hiding a field from type REM_RemittanceProcess" warnings.
- Renamed some variables named "line" with "remLine", to avoid "The local variable line is hiding a field from type REM_RemittanceProcess" warnings.
- Renamed the remittance param of createGroupedPayments method from "remittance" to "remittanceParam", and assigned it value to a local variable named "remmitance" to avoid "The parameter remittance should not be assigned" warning.

---
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0089906)
hgbot   
2016-09-13 10:02   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: b9ecd638d1bf3e788bead34dbc9bc9e5fed344c2
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Sep 12 11:57:19 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/b9ecd638d1bf3e788bead34dbc9bc9e5fed344c2 [^]

Related to issue 33831: Code review improvements

- Apply proper code format.
- Remove unused serialVersionUID variable in REM_Instruction_BPAccount.java, REM_PaymentMethod_Disccount.java and REM_RemittanceType_FinAccount.java.
- Avoid loop to convert List<String> into List<FIN_PaymentDetail> and use AcctServer.getPaymentDetailIdWriteOffAndAmount instead of AcctServer.getPaymentDetailIdWriteOffAndAmount method in DocREMRemittance.java.
- Rename HashMap<String, String> rem variable as "remHash", Remittance remittance variable as "rem" and Remittance remittanceParam parameter as "remittance" in REM_RemittanceProcess.java.
- Add @SuppressWarnings("unchecked") to List<String> lines = remitanceLineQuery.list(); in REM_RemittanceProcess.java.

---
M src/org/openbravo/module/remittance/ad_callouts/REM_Instruction_BPAccount.java
M src/org/openbravo/module/remittance/ad_callouts/REM_PaymentMethod_Disccount.java
M src/org/openbravo/module/remittance/ad_callouts/REM_RemittanceType_FinAccount.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0089907)
hgbot   
2016-09-13 10:02   
Repository: erp/mods/org.openbravo.module.remittance
Changeset: 922331ff80a393839f9d9ebea961b8bf4ddd7ca6
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 13 10:00:48 2016 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.module.remittance/rev/922331ff80a393839f9d9ebea961b8bf4ddd7ca6 [^]

Related to issue 33831: Update module dependency

---
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
---
(0089908)
aferraz   
2016-09-13 10:04   
Code review + Testing OK
(0089919)
hudsonbot   
2016-09-13 15:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/107ac99e99f3 [^]
Maturity status: Test