Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033813Openbravo ERPZ. Otherspublic2016-08-25 14:522016-09-13 15:41
Reportermaite 
Assigned ToAtulOpenbravo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q4Fixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket43381
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033813: Wrong payment date when voiding an unpaid invoice
DescriptionPayment's date should be reversed invoice's date instead of original invoice's date
Steps To Reproduce1. Access Sales Invoice window, filter by Paid=No and select any invoice. Run VOID process
2. Access Payment Plan tab and navigate to created payment
3. Realize that payment in document has been created using original invoice's date instead of reversed invoice's date

NOTE: if you post this payment, prepayment account will be used when it does not make sense
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by defect 00309713.0PR16Q1 closed aferraz When voiding an unpaid invoice, payment schedule details should be canceled instead of deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-25 14:52maiteNew Issue
2016-08-25 14:52maiteAssigned To => Triage Finance
2016-08-25 14:52maiteOBNetwork customer => Yes
2016-08-25 14:52maiteModules => Advanced Payables and Receivables Mngmt
2016-08-25 14:52maiteSupport ticket => 43381
2016-08-25 14:52maiteResolution time => 1473804000
2016-08-25 14:52maiteTriggers an Emergency Pack => No
2016-08-25 14:53maiteIssue Monitored: networkb
2016-08-25 14:53maiteAssigned ToTriage Finance => maite
2016-08-25 14:53maiteRelationship addedcaused by 0030971
2016-08-25 14:53maiteAssigned Tomaite => Triage Finance
2016-08-25 15:22aferrazAssigned ToTriage Finance => AtulOpenbravo
2016-08-26 08:32ngarciaNote Added: 0089427
2016-08-26 08:33ngarciaNote Edited: 0089427bug_revision_view_page.php?bugnote_id=0089427#r12906
2016-08-26 08:36ngarciaNote Deleted: 0089427
2016-08-26 09:01ngarciaIssue Monitored: ngarcia
2016-09-09 05:21AtulOpenbravoStatusnew => scheduled
2016-09-12 06:17AtulOpenbravoNote Added: 0089888
2016-09-13 10:45hgbotCheckin
2016-09-13 10:45hgbotNote Added: 0089909
2016-09-13 10:45hgbotStatusscheduled => resolved
2016-09-13 10:45hgbotResolutionopen => fixed
2016-09-13 10:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6669151c52480375aca29d7ea08340477ce468ae [^]
2016-09-13 10:47aferrazReview Assigned To => aferraz
2016-09-13 10:47aferrazNote Added: 0089910
2016-09-13 10:47aferrazStatusresolved => closed
2016-09-13 10:47aferrazFixed in Version => 3.0PR16Q4
2016-09-13 15:41hudsonbotCheckin
2016-09-13 15:41hudsonbotNote Added: 0089920

Notes
(0089888)
AtulOpenbravo   
2016-09-12 06:17   
Test Plan
- Access Sales Invoice window, filter by Paid=No and select any invoice. Run VOID process.
- Access Payment Plan tab and navigate to created payment.
- Realize that payment in document has been created using original reversed invoice's date instead of invoice's date.
- Check posting of this payment, prepayment account is not used.
(0089909)
hgbot   
2016-09-13 10:45   
Repository: erp/devel/pi
Changeset: 6669151c52480375aca29d7ea08340477ce468ae
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Fri Sep 09 14:11:17 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6669151c52480375aca29d7ea08340477ce468ae [^]

Fixes issue 33813: Wrong payment date when voiding an unpaid invoice

If voidDate is not null (Purchase Invoice), voidDate, which is the reversed invoice's date, will be taken as dummy payment's date.
If voidDate is null (Sales Invoice), new Date(), which is the reversed invoice's date, will be taken as dummy payment's date instead of invoice.getInvoiceDate(), which was the original invoice's date.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0089910)
aferraz   
2016-09-13 10:47   
Code review + Testing OK
(0089920)
hudsonbot   
2016-09-13 15:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/107ac99e99f3 [^]
Maturity status: Test