Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033809Openbravo ERPA. Platformpublic2016-08-12 17:242016-08-25 15:20
Reportershuehner 
Assigned Toaferraz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3.1Fixed in Version3.0PR16Q3.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033809: Double query in PricelistVersionFilterExpression (product selector)
DescriptionThe PriceListVersionFilterExpression has following code which does 2 db queries

    OBCriteria<PriceListVersion> plVersionCrit = OBDal.getInstance().createCriteria(
        PriceListVersion.class);
    plVersionCrit.add(Restrictions.eq(PriceListVersion.PROPERTY_PRICELIST, priceList));
    plVersionCrit.add(Restrictions.le(PriceListVersion.PROPERTY_VALIDFROMDATE, date));
    if (plVersionCrit.count() > 0) {
      plVersionCrit.addOrderBy(PriceListVersion.PROPERTY_VALIDFROMDATE, false);
      return plVersionCrit.list().get(0);
    }

Filter m_pricelist_version by m_pricelist_id and validfrom<='some value'

First query does a count of matching rows.
Then order by validfrom desc is added and a 2nd query is done to retrieve the 'newest' row.

The count query is not really an optimization as it forces same effort on db.
As there is a m_pricelist_id + name unique constraint those filter criteria combination is indexed anyway.

Additionally that query should get a "limit 1" constraint as it only uses 1 row of result anyway.

Without that and many pricelistversion matches the filter criteria lots of rows are loaded into memory without good reason.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033705 closed shuehner Double query in PricelistVersionFilterExpression (product selector) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-25 14:25aferrazTypedefect => backport
2016-08-25 14:25aferrazTarget Version => 3.0PR16Q3.1
2016-08-25 15:14aferrazAssigned Toshuehner => aferraz
2016-08-25 15:14hgbotCheckin
2016-08-25 15:14hgbotNote Added: 0089403
2016-08-25 15:14hgbotStatusscheduled => resolved
2016-08-25 15:14hgbotResolutionopen => fixed
2016-08-25 15:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8057375243880a2830c0537f24d037f675879b66 [^] => http://code.openbravo.com/erp/backports/3.0PR16Q3.1/rev/5af04a4df445d10aa9a3a4f12de35f44783ebb92 [^]
2016-08-25 15:20caristuNote Added: 0089405
2016-08-25 15:20caristuStatusresolved => closed
2016-08-25 15:20caristuFixed in Version => 3.0PR16Q3.1

Notes
(0089403)
hgbot   
2016-08-25 15:14   
Repository: erp/backports/3.0PR16Q3.1
Changeset: 5af04a4df445d10aa9a3a4f12de35f44783ebb92
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Aug 25 15:14:16 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q3.1/rev/5af04a4df445d10aa9a3a4f12de35f44783ebb92 [^]

Fixed issue 33809. Avoid double query with .count() + .list(). Add limit 1 to query

Query did .count() + then retrieve 1 record after adding extra order by.

This change removes the count as it only adds extra overhead and directly
does the real .list() query.
As the code only uses single row of result add extra limit 1 to reduce
number of result rows loaded into memory if many match the filter.
Simply code to use .uniqueResult() instead of .list().get(0)

---
M src/org/openbravo/erpCommon/info/PriceListVersionFilterExpression.java
---
(0089405)
caristu   
2016-08-25 15:20   
Code reviewed