Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033804Retail ModulesStoreServerpublic2016-08-25 13:082016-09-16 08:51
ReporterioritzCia 
Assigned ToioritzCia 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS30OS Version14.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033804: [Store server] Import export store, orgs not in natural tree should not export Customer Search Key Sequence
DescriptionWhen exporting the store, the dataset should be defined so that the stores not belonging to the natural tree of the organization being exported, do not export the Customer Search Key Sequence
Steps To Reproduce-In a multiserver environment in the central server, configure in an organization not in the natural tree of the organization to be exported, Customer Search Key Sequence so that the sequence belongs to the organization not belonging to the natural org tree
-Export the store
-Import the store
-Importing fails due to a foreign key fail
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-25 13:08ioritzCiaNew Issue
2016-08-25 13:08ioritzCiaAssigned To => ioritzCia
2016-08-25 13:08ioritzCiaResolution time => 1472767200
2016-08-25 13:08ioritzCiaTriggers an Emergency Pack => No
2016-08-25 13:26hgbotCheckin
2016-08-25 13:26hgbotNote Added: 0089394
2016-08-25 13:26hgbotStatusnew => resolved
2016-08-25 13:26hgbotResolutionopen => fixed
2016-08-25 13:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb3941e213763a8cdf06b53c07318ca91430f8d1 [^]
2016-08-25 13:49ioritzCiaReview Assigned To => mtaal
2016-08-26 09:33hgbotCheckin
2016-08-26 09:33hgbotNote Added: 0089431
2016-08-26 09:34AugustoMauchNote Added: 0089432
2016-08-26 09:34AugustoMauchStatusresolved => new
2016-08-26 09:34AugustoMauchResolutionfixed => open
2016-08-26 13:36hgbotCheckin
2016-08-26 13:36hgbotNote Added: 0089464
2016-08-26 13:36hgbotStatusnew => resolved
2016-08-26 13:36hgbotResolutionopen => fixed
2016-08-26 13:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb3941e213763a8cdf06b53c07318ca91430f8d1 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization.but/rev/19666d21c98d8e6da2a2fef2e091578ecacac97a [^]
2016-08-29 17:53hgbotCheckin
2016-08-29 17:53hgbotNote Added: 0089516
2016-08-29 17:56mtaalReview Assigned Tomtaal => AugustoMauch
2016-08-29 17:56mtaalNote Added: 0089517
2016-09-15 16:31dmitry_mezentsevNote Added: 0089989
2016-09-16 08:51AugustoMauchNote Added: 0090008
2016-09-16 08:51AugustoMauchStatusresolved => closed

Notes
(0089394)
hgbot   
2016-08-25 13:26   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: cb3941e213763a8cdf06b53c07318ca91430f8d1
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Thu Aug 25 13:15:07 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb3941e213763a8cdf06b53c07318ca91430f8d1 [^]

Fixes issue 33804: Export store, org entity avoid Customer Search Key Sequence
- For organizations to be exported that are not in the natural org tree of the store to be exported, the column Customer Search Key Sequence is not exported anymore, as it can belong to organizations not in the natural tree and can give foreign key errors when exporting. For these organizations in the store, this column is not needed.

---
M src-db/database/sourcedata/AD_DATASET_COLUMN.xml
---
(0089431)
hgbot   
2016-08-26 09:33   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 24417c09a14232653b6f32d4504c1700e61125de
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Aug 26 09:31:22 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/24417c09a14232653b6f32d4504c1700e61125de [^]

Related with issue 33804: Backs out the previous changeset

The ad_dataset_column defined in the previous changeset references an entry in ad_column_id that is not present in the current module, or in any module that the current module depends on.

Most probably this change needs to be done in another module.

---
M src-db/database/sourcedata/AD_DATASET_COLUMN.xml
---
(0089432)
AugustoMauch   
2016-08-26 09:34   
Backed out and reopened because it was causing referencial integrity problems. The ad_dataset_column defined in the previous changeset references an entry in ad_column_id that is not present in the current module, or in any module that the current module depends on.
(0089464)
hgbot   
2016-08-26 13:36   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization.but
Changeset: 19666d21c98d8e6da2a2fef2e091578ecacac97a
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Fri Aug 26 13:33:01 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization.but/rev/19666d21c98d8e6da2a2fef2e091578ecacac97a [^]

Fixes issue 33804: Export store, org entity avoid Customer Search Key Sequence
- For organizations to be exported that are not in the natural org tree of the store to be exported, the column Customer Search Key Sequence is not exported anymore, as it can belong to organizations not in the natural tree and can give foreign key errors when exporting. For these organizations in the store, this column is not needed.
- Export done to org.openbravo.retail.storeserver.synchronization.but as the field belongs to org.openbravo.retail.configuration.but branch

---
A src-db/database/sourcedata/AD_DATASET_COLUMN.xml
---
(0089516)
hgbot   
2016-08-29 17:53   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 1d56ef7a668bb6909388ff5775442c8458729b58
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 29 17:53:37 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/1d56ef7a668bb6909388ff5775442c8458729b58 [^]

Related to issue 33804: [Store server] Import export store, orgs not in natural tree should not export Customer Search Key Sequence
Also make sure the customer ad_sequence reference is ignored at runtime by checking for unfullfilled references.

---
M src-db/database/sourcedata/STRSYNC_SYNCHRONIZEDTABLE.xml
---
(0089517)
mtaal   
2016-08-29 17:56   
One thing which was not handled in the original commit is that also at runtime the customer key sequence can be changed. If this happen (and is set to an 'illegal' value) then a sync error will occur in the master data channel.

Therefore also the synchronized table has to be set to handle it. It is not possible to use exclude columns as for the store org it should still be send to the store. For other orgs the value should be ignored.

As we only have one sync table for all organizations without where clause the choice was made to set the special 'clear references' option.
(0089989)
dmitry_mezentsev   
2016-09-15 16:31   
Not closed for 20 days!
Please take an action.
(0090008)
AugustoMauch   
2016-09-16 08:51   
Code reviewed and verified