Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033796Retail ModulesWeb POSpublic2016-08-24 16:092019-01-07 16:45
Reporterumartirena 
Assigned Tomario_castello 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033796: [SER QA 1654] Check Stock button is not available for a 'Non Stocked' product that has 'Show Stock Screen' selected
DescriptionCheck Stock button is not available for a 'Non Stocked' product that has 'Show Stock Screen' selected in Openbravo Backend.
With this configuration when the product is added to a ticket for the first time the Stock Screen is displayed. But after adding it to the ticked the button "Check Stock" does not appear in edit lines section.
Steps To ReproduceCreate a Non Stocked product in Openbravo backend. Set "Show Stock Screen" to Y.
Add a price and add to the assortment of an Store.

Open Web POS.
Search the product and add to the ticket. Realize that Stock Screen is displayed.
Click on "Add to Receipt".
Go to Edit lines area. Realize that "Check Stock" button is not displayed.
Proposed SolutionThe logical solution in this case could be to hide the Stock Screen window for all Non Stocked products.
But for example "BUT" client uses this window for Non Stocked products as they use another external system to work with the Stock, but they still want to see the Stock there.
My proposal is not to attend to the "Stocked" property, but only to "Show Stock Screen", and if this property is configured to Y then always show the window and the button in edit lines.
Additional Information
Tags​SER QA
Relationships
Attached Filesdiff issue33796.diff (1,476) 2016-09-30 12:32
https://issues.openbravo.com/file_download.php?file_id=9877&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-08-24 16:09umartirenaNew Issue
2016-08-24 16:09umartirenaAssigned To => Retail
2016-08-24 16:09umartirenaOBNetwork customer => No
2016-08-24 16:09umartirenaTriggers an Emergency Pack => No
2016-08-24 16:28umartirenaFile Added: issue33796.diff
2016-09-30 12:32umartirenaFile Deleted: issue33796.diff
2016-09-30 12:32umartirenaFile Added: issue33796.diff
2016-09-30 14:01adrianromeroOBNetwork customerNo => Yes
2016-09-30 14:01adrianromeroResolution time => 1476396000
2016-09-30 14:01adrianromeroSummaryCheck Stock button is not available for a 'Non Stocked' product that has 'Show Stock Screen' selected in Openbravo Backend => [SER QA 1654] Check Stock button is not available for a 'Non Stocked' product that has 'Show Stock Screen' selected
2016-09-30 14:02adrianromeroTag Attached: ​SER QA
2016-10-03 11:45adrianromeroNote Added: 0090451
2016-10-05 17:10mario_castelloAssigned ToRetail => mario_castello
2016-10-05 17:10mario_castelloStatusnew => acknowledged
2016-10-05 22:03mario_castelloStatusacknowledged => scheduled
2016-10-15 18:35hgbotCheckin
2016-10-15 18:35hgbotNote Added: 0090599
2016-10-15 18:35hgbotStatusscheduled => resolved
2016-10-15 18:35hgbotResolutionopen => fixed
2016-10-15 18:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f6c740d98dba1fe442eca95523c4d9b8984a97b [^]
2016-10-18 18:13guilleaerReview Assigned To => guilleaer
2016-10-18 18:13guilleaerStatusresolved => closed
2016-10-18 18:13guilleaerFixed in Version => RR16Q4
2018-09-07 20:39hgbotCheckin
2018-09-07 20:39hgbotNote Added: 0106643
2019-01-07 16:45hgbotCheckin
2019-01-07 16:45hgbotNote Added: 0108845

Notes
(0090451)
adrianromero   
2016-10-03 11:45   
Attached proposal passes successfully try-retail: https://ci.openbravo.com/view/try-retail/job/try-ret-init/5776/ [^]
(0090599)
hgbot   
2016-10-15 18:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4f6c740d98dba1fe442eca95523c4d9b8984a97b
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Oct 06 10:47:21 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f6c740d98dba1fe442eca95523c4d9b8984a97b [^]

Fixed issue 33796: Show button check stock for products in edit view

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0106643)
hgbot   
2018-09-07 20:39   
Repository: tools/automation/pi-mobile
Changeset: 16f7a6b8addc8b07afb5b12e9bc8fb469521b418
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Thu Sep 06 11:25:11 2018 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/16f7a6b8addc8b07afb5b12e9bc8fb469521b418 [^]

Related to issue 33796: added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/products/I33796_VerifyStockButtonForNonStockedProduct.java
---
(0108845)
hgbot   
2019-01-07 16:45   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 28bbfd3444ad51e48b9131fe54d48897a4129041
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Dec 26 14:11:11 2018 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/28bbfd3444ad51e48b9131fe54d48897a4129041 [^]

Related to issue 33796: added sampledata for test

---
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---