0033788: OrderLoader.createShipmentLines query to m_locator could be optimized away

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033788

Retail Modules

Web POS

public

2016-08-24 10:50

2018-03-16 14:45

Reporter

shuehner

Assigned To

Sandrahuguet

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR18Q2

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033788: OrderLoader.createShipmentLines query to m_locator could be optimized away

Description

Split out part mentioned as note already in issue 33157

createShipmentLines has following code near the end of the function:

        if (pendingQty.compareTo(BigDecimal.ZERO) != 0) {
          // still qty to ship or return: let's use the bin with highest prio
          hqlWhereClause = " l where l.warehouse = :warehouse order by l.relativePriority, l.id";
          OBQuery<Locator> queryLoc = OBDal.getInstance()
              .createQuery(Locator.class, hqlWhereClause);
          queryLoc.setNamedParameter("warehouse", warehouse);
          queryLoc.setMaxResult(1);

That query very similar to one done earlier (see issue 33139).
That earlier query does search with any specified order just to check if it can find 'any' m_locator entries in current warehouse.

This query searched for 1 with highest relativePriority.

By adding orderBy that first query its result could be reused to also serve in this code here and the extra query removed.

Note: That would add some small overhead to that first query by forcing 'order by relativePriority,id limit 2'

Steps To Reproduce

Proposed Solution

Additional Information