Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0033776Openbravo ERP09. Financial managementpublic2016-08-23 23:162017-07-13 11:12
Sanjota 
Sanjota 
normalmajorhave not tried
closedfixed 
5
 
3.0PR16Q4 
aferraz
Core
No
0033776: Business partner being null in Payment scheduledetails
Business partner being null in Payment scheduledetails.
1)Login with QA testing admin role.
2)Create sales Invoice
3)Complete the invoice
4)Create paymentIn(In Awaiting Execution status) record by Clicking "add payment" button.
To create paymentIn in Awaiting Execution status, setup Execution Type=Automatic and "Deferred" checkbox to be selected in financial account assigned to payment method used in sales Invoice.
Follow the wiki http://wiki.openbravo.com/wiki/Payment_Out#Voiding_a_payment [^]
5) GO to PaymentIn window, Open the created record, click on "Reactive button" and void the record.
6) Check In the backend there will be 2 PSD records that belongs to created Invoice
  a) 1 with Iscancelled ='Y' and bpartner being set to bpartner of Invoice.
  b) another with Iscancelled ='N' and bpartner_id=null
7)Click on add payment of the sales invoice to add pending payment and create PaymentIn record.
8)Go to paymentIn window, open newly created paymentIn record, complete it by clicking the button "Execute payment"
9)Check In the backend as well as in Payment details of the sales Invoice window, there will be 2 PSD records that belongs to created Invoice but 1 record still with bpartner=null
No tags attached.
related to defect 0033671 closed mario_castello Retail Modules FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner 
blocks defect 0033629 closed alostale Openbravo ERP slow order/invoice grid population in Add Payment 
causes defect 0035377 closed aferraz Openbravo ERP Modulescript required to fix data related with issue 33776 
Issue History
2016-08-23 23:16SanjotaNew Issue
2016-08-23 23:16SanjotaAssigned To => Triage Finance
2016-08-23 23:16SanjotaModules => Core
2016-08-23 23:16SanjotaTriggers an Emergency Pack => No
2016-08-23 23:17SanjotaRelationship addedblocks 0033629
2016-08-24 11:03SanjotaAssigned ToTriage Finance => Sanjota
2016-08-24 11:03SanjotaStatusnew => scheduled
2016-08-24 11:52SanjotaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12890#r12890
2016-08-24 13:07SanjotaNote Added: 0089339
2016-08-24 13:07SanjotaDescription Updatedbug_revision_view_page.php?rev_id=12895#r12895
2016-08-24 13:07SanjotaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12896#r12896
2016-09-06 09:54hgbotCheckin
2016-09-06 09:54hgbotNote Added: 0089770
2016-09-06 09:54hgbotStatusscheduled => resolved
2016-09-06 09:54hgbotResolutionopen => fixed
2016-09-06 09:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/97dc0931fbfb337e1e6af1ef6ef37849661e9c7f [^]
2016-09-06 10:23hgbotCheckin
2016-09-06 10:23hgbotNote Added: 0089772
2016-09-06 10:32aferrazReview Assigned To => aferraz
2016-09-06 10:32aferrazNote Added: 0089775
2016-09-06 10:32aferrazStatusresolved => closed
2016-09-06 10:32aferrazFixed in Version => 3.0PR16Q4
2016-09-06 14:42hudsonbotCheckin
2016-09-06 14:42hudsonbotNote Added: 0089781
2016-09-07 14:20hudsonbotCheckin
2016-09-07 14:20hudsonbotNote Added: 0089803
2016-09-07 14:20hudsonbotCheckin
2016-09-07 14:20hudsonbotNote Added: 0089804
2017-02-28 12:25maiteRelationship addedcauses 0035377
2017-07-13 11:12ngarciaRelationship addedrelated to 0033671

Notes
(0089339)
Sanjota   
2016-08-24 13:07   
Test Plan:
Setup Execution Type=Automatic and "Deferred" checkbox to be selected in financial account assigned to payment method(to be used in sales Invoice).
--For Sales Invoice
1)Login with QA testing admin role.
2)Create sales Invoice
3)Complete the invoice
4)Create paymentIn(In Awaiting Execution status) record by Clicking "add payment" button.
5) GO to PaymentIn window, Open the created record, click on "Reactive button" and void the record.
6) Check In the backend there will be 2 PSD records that belongs to created Invoice
  a) 1 with Iscancelled ='Y' and bpartner being set to bpartner of Invoice.
  b) another with Iscancelled ='N' and bpartner_id also set to Bpartner of Invoice
7)Click on add payment of the sales invoice to add pending payment and create new PaymentIn record.
8)Go to paymentIn window, open newly created paymentIn record, complete it by clicking the button "Execute payment"
9)Check In the backend as well as in Payment details of the sales Invoice window, there will be 2 PSD records that belongs to created Invoice both with bpartner being set to Bpartner of Invoice.

--For Purchase Invoice
1)Login with QA testing admin role.
2)Create purchase Invoice
3)Complete the invoice
4)Create paymentOut(In Awaiting Execution status) record by Clicking "add payment" button.
5) GO to PaymentOut window, Open the created record, click on "Reactive button" and void the record.
6) Check In the backend there will be 2 PSD records that belongs to created Invoice
  a) 1 with Iscancelled ='Y' and bpartner being set to bpartner of Invoice.
  b) another with Iscancelled ='N' and bpartner_id also set to Bpartner of Invoice
7)Click on add payment of the purchase invoice to add pending payment and create new Paymentout record.
8)Go to paymentOut window, open newly created paymentOut record, complete it by clicking the button "Execute payment"
9)Check In the backend as well as in Payment details of the Purchase Invoice window, there will be 2 PSD records that belongs to created Invoice both with bpartner being set to Bpartner of Invoice.

--For Sales Order
1)Login with QA testing admin role.
2)Create sales Order
3)Book the Order
4)Create paymentIn(In Awaiting Execution status) record by Clicking "add payment" button.
5) GO to PaymentIn window, Open the created record, click on "Reactive button" and void the record.
6) Check In the backend there will be 2 PSD records that belongs to created Order
  a) 1 with Iscancelled ='Y' and bpartner being set to bpartner of order.
  b) another with Iscancelled ='N' and bpartner_id also set to Bpartner of order
7)Click on add payment of the sales order to add pending payment and create new PaymentIn record.
8)Go to paymentIn window, open newly created paymentIn record, complete it by clicking the button "Execute payment"
9)Check In the backend as well as in Payment details of the sales order window, there will be 2 PSD records that belongs to created order both with bpartner being set to Bpartner of order.

--For Purchase order
1)Login with QA testing admin role.
2)Create purchase order
3)Book the order
4)Create paymentOut(In Awaiting Execution status) record by Clicking "add payment" button.
5) GO to PaymentOut window, Open the created record, click on "Reactive button" and void the record.
6) Check In the backend there will be 2 PSD records that belongs to created order
  a) 1 with Iscancelled ='Y' and bpartner being set to bpartner of order.
  b) another with Iscancelled ='N' and bpartner_id also set to Bpartner of order
7)Click on add payment of the purchase order to add pending payment and create new Paymentout record.
8)Go to paymentOut window, open newly created paymentOut record, complete it by clicking the button "Execute payment"
9)Check In the backend as well as in Payment details of the Purchase order window, there will be 2 PSD records that belongs to created order both with bpartner being set to Bpartner of order.
(0089770)
hgbot   
2016-09-06 09:54   
Repository: erp/devel/pi
Changeset: 97dc0931fbfb337e1e6af1ef6ef37849661e9c7f
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Wed Aug 24 12:58:54 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/97dc0931fbfb337e1e6af1ef6ef37849661e9c7f [^]

Fixes issue 33776: Business partner being null in Payment scheduledetails

Set the Bpartner of payment scheduledetails to the bpartner of Invoice or order
Details: Set Bpartner for newly created merged Payment Scheduledetails when the fin_payment is made void.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentProcess.java
---
(0089772)
hgbot   
2016-09-06 10:23   
Repository: erp/devel/pi
Changeset: 7a6f2a5786c1834e466cf5dce72fecd78622e5b5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Sep 06 10:17:03 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7a6f2a5786c1834e466cf5dce72fecd78622e5b5 [^]

Related to issue 33776: Update PSD in QA client sampledata

Update c_bpartner_id of PSD in QA client sampledata, updated by UpdateBpPaymentLine modulescript.
c_bpartner_id column was null due to issue 33776.

---
M referencedata/sampledata/QA_Testing/FIN_PAYMENT_SCHEDULEDETAIL.xml
---
(0089775)
aferraz   
2016-09-06 10:32   
Code review + Testing OK
(0089781)
hudsonbot   
2016-09-06 14:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/a8a02720da0e [^]
Maturity status: Test
(0089803)
hudsonbot   
2016-09-07 14:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f6f6845fdec4 [^]
Maturity status: Test
(0089804)
hudsonbot   
2016-09-07 14:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f6f6845fdec4 [^]
Maturity status: Test