Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033774Openbravo ERP01. General setuppublic2016-08-23 17:572016-08-31 10:33
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033774: Accidental double queries in Initial Org Setup
DescriptionRunning initial org setup with some accounting schema module installed (and used in the setup) runs some double query
Steps To Reproducewith debugging code from: https://issues.openbravo.com/view.php?id=33767 [^]
Install some accounting schema module (i.e. france)
In initial Org setup use:
- currency: eur
- mark the installed accounting schema
and create an organization.

see debugging output shown during the process
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to feature request 0033767 closed platform Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object 
related to design defect 0036898 new Triage Finance Performance issues when using DAL 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-23 17:57shuehnerNew Issue
2016-08-23 17:57shuehnerAssigned To => Triage Finance
2016-08-23 17:57shuehnerModules => Core
2016-08-23 17:57shuehnerTriggers an Emergency Pack => No
2016-08-23 17:57shuehnerTag Attached: page data grid
2016-08-23 17:57shuehnerTag Attached: Performance
2016-08-23 17:57shuehnerRelationship addedrelated to 0033767
2016-08-23 22:00shuehnerTag Detached: page data grid
2016-08-24 14:11hgbotCheckin
2016-08-24 14:11hgbotNote Added: 0089341
2016-08-24 14:11hgbotStatusnew => resolved
2016-08-24 14:11hgbotResolutionopen => fixed
2016-08-24 14:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/af6e72d059cd2fd7bafd60538bcc14ccba6648e3 [^]
2016-08-24 14:12hgbotCheckin
2016-08-24 14:12hgbotNote Added: 0089343
2016-08-24 14:13shuehnerReview Assigned To => aferraz
2016-08-24 14:59shuehnerAssigned ToTriage Finance => shuehner
2016-08-24 22:47hudsonbotCheckin
2016-08-24 22:47hudsonbotNote Added: 0089368
2016-08-31 10:33aferrazNote Added: 0089584
2016-08-31 10:33aferrazStatusresolved => closed
2016-08-31 10:33aferrazFixed in Version => 3.0PR16Q4
2017-09-19 18:47markmm82Relationship addedrelated to 0036898

Notes
(0089341)
hgbot   
2016-08-24 14:11   
Repository: erp/devel/pi
Changeset: af6e72d059cd2fd7bafd60538bcc14ccba6648e3
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 23 17:58:45 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/af6e72d059cd2fd7bafd60538bcc14ccba6648e3 [^]

Fixed 33774. Fixed accidental double query by not calling .list() twice

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0089343)
hgbot   
2016-08-24 14:12   
Repository: erp/devel/pi
Changeset: a8163cc557bbfe154a5c2e94c30e1c618a8a2b69
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Aug 24 13:54:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a8163cc557bbfe154a5c2e94c30e1c618a8a2b69 [^]

Issue 33774. Apply review feedback, change .size() > 0 to !isEmpty()

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0089368)
hudsonbot   
2016-08-24 22:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/badbe5df5566 [^]
Maturity status: Test
(0089584)
aferraz   
2016-08-31 10:33   
Code review OK