Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033773Openbravo ERP01. General setuppublic2016-08-23 17:332016-08-31 10:31
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033773: Accidental double queries in Initial Client Setup
DescriptionUsing Initial Client setup shows some accidental double queries for
- ad_language table
- ad_dataset table
Steps To Reproducewith debugging code from https://issues.openbravo.com/view.php?id=33767 [^]

With System Administrator role
Run 'Initial Client setup' and let it create the client.
Observe debugging output
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to feature request 0033767 closed platform Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object 
related to design defect 0036898 new Triage Finance Performance issues when using DAL 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-23 17:33shuehnerNew Issue
2016-08-23 17:33shuehnerAssigned To => Triage Finance
2016-08-23 17:33shuehnerModules => Core
2016-08-23 17:33shuehnerTriggers an Emergency Pack => No
2016-08-23 17:33shuehnerRelationship addedrelated to 0033767
2016-08-23 17:33shuehnerTag Attached: Performance
2016-08-24 14:11hgbotCheckin
2016-08-24 14:11hgbotNote Added: 0089340
2016-08-24 14:11hgbotStatusnew => resolved
2016-08-24 14:11hgbotResolutionopen => fixed
2016-08-24 14:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e508c5662e3375afcfc4b60e3550fa09d39ab330 [^]
2016-08-24 14:11hgbotCheckin
2016-08-24 14:11hgbotNote Added: 0089342
2016-08-24 14:13shuehnerReview Assigned To => aferraz
2016-08-24 14:59shuehnerAssigned ToTriage Finance => shuehner
2016-08-24 22:47hudsonbotCheckin
2016-08-24 22:47hudsonbotNote Added: 0089367
2016-08-31 10:31aferrazNote Added: 0089583
2016-08-31 10:31aferrazStatusresolved => closed
2016-08-31 10:31aferrazFixed in Version => 3.0PR16Q4
2017-09-19 18:47markmm82Relationship addedrelated to 0036898

Notes
(0089340)
hgbot   
2016-08-24 14:11   
Repository: erp/devel/pi
Changeset: e508c5662e3375afcfc4b60e3550fa09d39ab330
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Aug 23 17:34:51 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e508c5662e3375afcfc4b60e3550fa09d39ab330 [^]

Fixed 33773. Avoid double query by not calling .list() twice

First case reading from ad_language can be simplified to single .uniqueResult
call as filters are unique.

2nd case just saves list() result to avoid 2nd call easily.

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0089342)
hgbot   
2016-08-24 14:11   
Repository: erp/devel/pi
Changeset: 197fb66d7ceaeb08f79963b048986d7e4fa08b5b
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Aug 24 13:51:59 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/197fb66d7ceaeb08f79963b048986d7e4fa08b5b [^]

Issue 33773. Apply review feedback replace .size() >0 with !isEmpty()

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0089367)
hudsonbot   
2016-08-24 22:47   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/badbe5df5566 [^]
Maturity status: Test
(0089583)
aferraz   
2016-08-31 10:31   
Code review OK