0033748: [SERQA 1304] Approval not granted if the user has more than one preference allowing an action

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033748

Retail Modules

Web POS

public

2016-06-16 13:24

2016-08-19 10:29

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q2.2

Fixed in Version

RR16Q2.2

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033748: [SERQA 1304] Approval not granted if the user has more than one preference allowing an action

Description

If a user has different preferences granting approval for an action (e.g. one configured for the specific user and one configured for its role), if the user tries to approve that action, the system doesn't allow it.

Steps To Reproduce

Using livebuilds:
Login in backend and go to the preference window.
Configure the following preferences:
Web POS Delete Line Approval, value:Y, Visible at user: Openbravo.
Web POS Delete Line Approval, value:Y, Visible at role: The White Valley Group Admin
Web POS Delete Line Approval, value:N, Visible at user: Vall Blanca Store User.

Login in web pos with user vallblanca.
Create a new ticket, add a line, and try to delete the line.
The Approval Required popup will be shown and Openbravo will be available as Supervisor.
Select Openbravo and write its password. Then click on Approve.
The 'User does not have privileges to approve this action' error will be shown and the line won't be deleted.

Proposed Solution

It is possible to send to the CheckAppoval.java file, which validates the supervisor credentials, several approvals at the same time to validate all of them together.
That process executes a query which filters permissions by role and user. The query is returning the whole preference object, although it only needs the 'property' value. After that, compares the amount of results returned by the query (which may include duplicated preferences), with the amount of approvals requested.

The proposed solution is to make the query return only the 'property' of the preference, and group by that field, so no duplicates are returned.

Additional Information