Openbravo Issue Tracking System - Retail Modules
View Issue Details
0033744Retail ModulesWeb POSpublic2016-08-18 17:262016-09-19 18:22
guilleaer 
mario_castello 
normaltrivialhave not tried
closedfixed 
5
 
RR16Q4 
No
0033744: Module script required to fix wrong data created by 33671
Module script to fix data is required

Wrong data PSD should be updated. You can reuse module script UpdateBpPaymentLine.
It's recommended to modify the update queries to filter by isinvoicepaid = 'N', so it performs faster:

update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_invoice i, fin_payment_schedule ps
                     where ps.fin_payment_schedule_id = fin_payment_schedule_invoice
                     and ps.c_invoice_id = i.c_invoice_id)
where c_bpartner_id is null and fin_payment_schedule_invoice is not null and isinvoicepaid = 'N';


update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_order o, fin_payment_schedule ps
                                                     where ps.fin_payment_schedule_id = fin_payment_schedule_order
                                                     and ps.c_order_id = o.c_order_id)
where c_bpartner_id is null and fin_payment_schedule_order is not null
and fin_payment_schedule_invoice is null and isinvoicepaid = 'N';
N/A
No tags attached.
related to defect 0033671 closed mario_castello Retail Modules FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner 
related to defect 0035377 closed aferraz Openbravo ERP Modulescript required to fix data related with issue 33776 
Issue History
2016-08-18 17:26guilleaerNew Issue
2016-08-18 17:26guilleaerAssigned To => Retail
2016-08-18 17:26guilleaerTriggers an Emergency Pack => No
2016-08-18 17:30guilleaerRelationship addedrelated to 0033671
2016-08-18 17:31mario_castelloAssigned ToRetail => mario_castello
2016-08-18 17:31mario_castelloStatusnew => acknowledged
2016-08-26 16:55hgbotCheckin
2016-08-26 16:55hgbotNote Added: 0089471
2016-08-26 16:55hgbotStatusacknowledged => resolved
2016-08-26 16:55hgbotResolutionopen => fixed
2016-08-26 16:55hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d17d71adc6675b313a246d23180a85017d431906 [^]
2016-08-29 21:37hgbotCheckin
2016-08-29 21:37hgbotNote Added: 0089522
2016-08-29 21:38mario_castelloNote Edited: 0089522bug_revision_view_page.php?bugnote_id=0089522#r12956
2016-09-15 16:39dmitry_mezentsevNote Added: 0089992
2016-09-16 14:46shuehnerNote Added: 0090039
2016-09-19 18:20hgbotCheckin
2016-09-19 18:20hgbotNote Added: 0090078
2016-09-19 18:20hgbotCheckin
2016-09-19 18:20hgbotNote Added: 0090079
2016-09-19 18:22marvintmStatusresolved => closed
2017-06-09 10:28ngarciaRelationship addedrelated to 0035377

Notes
(0089471)
hgbot   
2016-08-26 16:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d17d71adc6675b313a246d23180a85017d431906
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Aug 25 22:11:51 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d17d71adc6675b313a246d23180a85017d431906 [^]

Fixed issue 33744: Added new module script to fix data refer to issue 33671

---
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.class
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744Data.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744_Data.xsql
---
(0089522)
hgbot   
2016-08-29 21:37   
(edited on: 2016-08-29 21:38)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 82d9b9d9a0d1c348eb508d15ad37ee5bb9ef38fe
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Aug 29 09:24:57 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/82d9b9d9a0d1c348eb508d15ad37ee5bb9ef38fe [^]

Related to issue 33744: Fixed problems with java version of modulescript class

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744Data.class
---

(0089992)
dmitry_mezentsev   
2016-09-15 16:39   
Not closed for 20 days!
Please take an action.
(0090039)
shuehner   
2016-09-16 14:46   
Note: This modulescript does not follow up to date coding rules.
As every modulescript should use the Version Restriction to not run at all if not needed.
Instead this modulescript uses the older preferences workaround for this.
(0090078)
hgbot   
2016-09-19 18:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 08b1afebe744bf411eebc17c55cf6251edd1ef7d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Sep 19 18:19:44 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/08b1afebe744bf411eebc17c55cf6251edd1ef7d [^]

Related to issue 33744. Removed unnecessary modulescript.

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744Data.class
---
(0090079)
hgbot   
2016-09-19 18:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fb662f11dea1ef3690ef36ae8bdd3a0b8b23a1b7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Sep 19 18:20:08 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb662f11dea1ef3690ef36ae8bdd3a0b8b23a1b7 [^]

Related to issue 33744. Removed unnecessary modulescript.

---
R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.class
R build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744Data.class
R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.java
R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744_Data.xsql
---