Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033736Openbravo ERPA. Platformpublic2016-08-18 10:242023-12-06 08:21
ReporterJONHM 
Assigned Tocaristu 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0PR16Q4 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033736: "Disable Notes For Read-Only tabs" preference is not working
Description"Disable Notes For Read-Only tabs" is not working
Steps To Reproduce1) Create a new preference "Disable Notes For Read-Only tabs" for the window [Process Monitor], which is a read-only one (see the attached screenshot)
2) Open [Process Monitor] window, open a record and try to add a new note.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0025146 new Triage Platform Base Add the ability to disable the notes in a tab using a preference 
related to feature request 0023824 closed shankarb Add the possibility to make the notes on the window read only if the tab is also readonly 
Attached Filespng disableNotes.png (64,213) 2016-08-18 10:24
https://issues.openbravo.com/file_download.php?file_id=9728&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-08-18 10:24JONHMNew Issue
2016-08-18 10:24JONHMAssigned To => platform
2016-08-18 10:24JONHMFile Added: disableNotes.png
2016-08-18 10:24JONHMModules => Core
2016-08-18 10:24JONHMResolution time => 1474840800
2016-08-18 10:24JONHMTriggers an Emergency Pack => No
2016-08-22 08:33caristuRelationship addedrelated to 0025146
2016-08-22 08:34caristuRelationship addedrelated to 0023824
2016-08-22 09:16caristuAssigned Toplatform => caristu
2016-08-22 09:16caristuStatusnew => acknowledged
2016-08-22 09:16caristuStatusacknowledged => scheduled
2016-08-22 11:37hgbotCheckin
2016-08-22 11:37hgbotNote Added: 0089272
2016-08-22 11:37hgbotStatusscheduled => resolved
2016-08-22 11:37hgbotResolutionopen => fixed
2016-08-22 11:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc2fbf3adc365876f34c7497fe013b40f9f32f3a [^]
2016-08-22 11:38caristuReview Assigned To => AugustoMauch
2016-08-22 11:38caristuIssue Monitored: AugustoMauch
2016-08-22 16:27hudsonbotCheckin
2016-08-22 16:27hudsonbotNote Added: 0089285
2016-08-23 15:34AugustoMauchNote Added: 0089308
2016-08-23 15:34AugustoMauchStatusresolved => closed
2016-08-23 15:34AugustoMauchFixed in Version => 3.0PR16Q4
2023-12-06 08:21dnesemrNote Added: 0157979
2023-12-06 13:22priyamNote Deleted: 0157979

Notes
(0089272)
hgbot   
2016-08-22 11:37   
Repository: erp/devel/pi
Changeset: bc2fbf3adc365876f34c7497fe013b40f9f32f3a
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Aug 22 11:13:39 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bc2fbf3adc365876f34c7497fe013b40f9f32f3a [^]

fixes issue 33736: 'Disable Notes For Read-Only' tabs not working properly

'Disable Notes For Read-Only' preference was not working properly when a window was set in the visibility settings. This is because the window ID was not being retrieved properly within the OBNoteSectionItem class.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js
---
(0089285)
hudsonbot   
2016-08-22 16:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1b4c4167570a [^]
Maturity status: Test
(0089308)
AugustoMauch   
2016-08-23 15:34   
Code reviewed and verified in pi@9bebb4948779