Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033714Openbravo ERP09. Financial managementpublic2016-08-10 09:332016-09-01 11:46
Reportermalsasua 
Assigned Tononofrancisco 
PriorityimmediateSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q3.2Fixed in Version3.0PR16Q3.2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-01-13
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/27ef13611fff [^]
Triggers an Emergency PackNo
Summary0033714: when adding a payment in match statement, the actual payment is 0, and it should be the transaction amount
Descriptionwhen a new payment is created, from match statement process, in the payment form, the actual payment is 0 and it should be the transaction amount
Steps To Reproducein f&b
. go to financial account: Bank - Account 1
 . tab: imported bank statement
   . new record
     new bank statement line
         BP: Be Soft Drinker, Inc.
         Amount out: 100
    . process bank statement
 . click in match statement process: previous bank statement line is displayed
   . click in "add new transaction" -> add new transaction form is displayed
   . click in "add new payment" -> add payment form is displayed:
     the "actual payment" field should be 100 but it is 0
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033666 closed nonofrancisco when adding a payment in match statement, the actual payment is 0, and it should be the transaction amount 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-15 14:51nonofranciscoTypedefect => backport
2016-08-15 14:51nonofranciscoTarget Version => 3.0PR16Q3.1
2016-08-22 14:16aferrazTarget Version3.0PR16Q3.1 => 3.0PR16Q3.2
2016-09-01 11:45hgbotCheckin
2016-09-01 11:45hgbotNote Added: 0089645
2016-09-01 11:45hgbotStatusscheduled => resolved
2016-09-01 11:45hgbotResolutionopen => fixed
2016-09-01 11:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q3.2/rev/3d9434730d35dab8b50476e1d1ff579ac329fa05 [^]
2016-09-01 11:46aferrazReview Assigned To => aferraz
2016-09-01 11:46aferrazNote Added: 0089646
2016-09-01 11:46aferrazStatusresolved => closed
2016-09-01 11:46aferrazFixed in Version => 3.0PR16Q3.2

Notes
(0089645)
hgbot   
2016-09-01 11:45   
Repository: erp/backports/3.0PR16Q3.2
Changeset: 3d9434730d35dab8b50476e1d1ff579ac329fa05
Author: Nono Carballo <nonofce <at> gmail.com>
Date: Tue Aug 16 14:44:35 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q3.2/rev/3d9434730d35dab8b50476e1d1ff579ac329fa05 [^]

Fixes issue 33714: Zero amount instead of withdrawal amount in Add Payment

When creating a payment out with Add Payment process in Financial Account window (from Transaction tab or Match Statement | Add Transaction process), actual payment will be loaded with withdrawal amount.
If transaction withdrawal amount is different than 0, actual payment will be loaded with withdrawal amount but will not be distributed into order/invoices in the grid. If total amount is lower than withdrawal amount, actual payment will not be updated with total amount and we will be able to leave the difference between withdrawal amount and total amount as credit. If total amount is higher than withdrawal amount, actual payment will be updated with total amount and we will be able to pay more amount than withdrawal amount.
If transaction withdrawal amount is 0, actual payment will always be updated with total amount and it will not be possible to generate credit in this payment.

We have reverted changes done in ob-aprm-addPayment.js for issues 33465 and 31392, and we will retrieve bslamount as deposit amount - withdrawal amount also in Transaction tab, as it is done in Add Transaction process.
With this, opening Add Payment from both Transaction tab and Add Transaction process, will have the same behavior as it used to when opening from Add Transaction process in 16Q1 (before fixing issue 31392).

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/TransactionAddPaymentDefaultValues.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0089646)
aferraz   
2016-09-01 11:46   
Code review + Testing OK