0033676: FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033676

Retail Modules

Web POS

public

2016-08-10 10:39

2016-08-19 10:39

Reporter

vmromanos

Assigned To

Retail

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q2.2

Fixed in Version

RR16Q2.2

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033676: FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner

Description

The FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner.

The ERP always sets the business partner information when creating the PSD from an invoice or an order (through extension points on C_Invoice_Post and C_Order_Post). However the POS doesn't fill it.

When the order is directly paid from the POS there is no problem. However, credit orders generated from POS couldn't be paid in the ERP after fixing 0033629, because that fix requires to have the Business Partner information.

Steps To Reproduce

1. Create and pay and order in POS
2. Go to the ERP and search for the associated payment (Sales Order | Payment Plan | Payment Details, and browse to the Payment In window)
3. Inside the Payment In window, go to Lines tab and verify Business Partner field is empty. It should have the order's business partner

Proposed Solution

Modify OrderLoader
Ensure created PSD has set the business partner:
paymentScheduleDetail.setBusinessPartner(order.getBusinessPartner());

Wrong data PSD should be updated. You can reuse module script UpdateBpPaymentLine.
It's recommended to modify the update queries to filter by isinvoicepaid = 'N', so it performs faster:

update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_invoice i, fin_payment_schedule ps
                     where ps.fin_payment_schedule_id = fin_payment_schedule_invoice
                     and ps.c_invoice_id = i.c_invoice_id)
where c_bpartner_id is null and fin_payment_schedule_invoice is not null and isinvoicepaid = 'N';

update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_order o, fin_payment_schedule ps
                                                     where ps.fin_payment_schedule_id = fin_payment_schedule_order
                                                     and ps.c_order_id = o.c_order_id)
where c_bpartner_id is null and fin_payment_schedule_order is not null
and fin_payment_schedule_invoice is null and isinvoicepaid = 'N';

Additional Information