Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033673Retail ModulesWeb POSpublic2016-08-10 10:552016-09-20 15:39
Reporteralostale 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033673: slow population of approvals popup
DescriptionIn instances with high data volumes (ie. 2K users + 20K preferences), the population of approval popup takes too long.
Steps To Reproduce1. In an instance with high volume of data, configure Cash Management window to require approval
2. Click on cash management
  -> check the popup window where users and their images are loaded takes long to be populated. In the concrete instance where it was tested it was 5-8 secs

Verify that the query is only returning useful data (eg: no users that cannot approve the action, no bps, etc)

Verify that the time downloading the data from the server can drop from 1s to 0,1 second if the images are not sent
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0033568 closed ranjith_qualiantech_com Approval is taking too long 
related to defect 0030673RR15Q4 closed mario_castello all approvals of supervisor should be loaded in terminal when one action is approval by this supervisor 
depends on backport 0033740RR16Q3.2 closed Retail slow population of approvals popup 
depends on backport 0033741RR16Q2.3 closed simbu94 slow population of approvals popup 
blocks defect 0033747 new Retail Performance: Images are always retrieved when the approvals are requested from the server 
Attached Filespng Screenshot from 2016-08-18 12:20:20.png (32,460) 2016-08-18 12:21
https://issues.openbravo.com/file_download.php?file_id=9729&type=bug
png

patch issue_33673.patch (6,112) 2016-09-15 20:07
https://issues.openbravo.com/file_download.php?file_id=9829&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-08-10 10:55alostaleNew Issue
2016-08-10 10:55alostaleAssigned To => Retail
2016-08-10 10:55alostaleTriggers an Emergency Pack => No
2016-08-10 10:56alostaleRelationship addedrelated to 0033568
2016-08-10 10:56alostaleRelationship addedrelated to 0030673
2016-08-10 10:57alostaleTag Attached: Performance
2016-08-10 11:01alostaleIssue Monitored: alostale
2016-08-18 12:21OrekariaFile Added: Screenshot from 2016-08-18 12:20:20.png
2016-08-18 12:45OrekariaAssigned ToRetail => simbu94
2016-08-18 12:45OrekariaStatusnew => acknowledged
2016-08-18 13:16OrekariaStatusacknowledged => scheduled
2016-08-18 14:13shuehnerIssue Monitored: shuehner
2016-08-18 14:18OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12862#r12862
2016-08-18 14:19OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12863#r12863
2016-08-18 14:19OrekariaProposed Solution updated
2016-08-18 14:21OrekariaProposed Solution updated
2016-08-18 14:52OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12864#r12864
2016-08-18 14:52OrekariaProposed Solution updated
2016-08-19 09:05OrekariaRelationship addedblocks 0033747
2016-08-29 11:53simbu94File Added: Issue_33673.patch
2016-08-29 11:55simbu94Note Added: 0089492
2016-08-29 13:38simbu94File Deleted: Issue_33673.patch
2016-08-29 13:38simbu94File Added: Issue_33673.patch
2016-08-30 14:20simbu94Assigned Tosimbu94 => Retail
2016-08-30 14:41simbu94File Deleted: Issue_33673.patch
2016-08-30 14:41simbu94File Added: Issue_33673.patch
2016-09-02 23:40hgbotCheckin
2016-09-02 23:40hgbotNote Added: 0089715
2016-09-07 21:26mario_castelloAssigned ToRetail => mario_castello
2016-09-15 20:06mario_castelloFile Deleted: Issue_33673.patch
2016-09-15 20:07mario_castelloFile Added: issue_33673.patch
2016-09-19 22:22hgbotCheckin
2016-09-19 22:22hgbotNote Added: 0090089
2016-09-19 22:22hgbotStatusscheduled => resolved
2016-09-19 22:22hgbotResolutionopen => fixed
2016-09-19 22:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29b079520aae7926bf97d57d8fb8eb [^]
2016-09-20 15:39guilleaerReview Assigned To => guilleaer
2016-09-20 15:39guilleaerNote Added: 0090114
2016-09-20 15:39guilleaerStatusresolved => closed
2016-09-20 15:39guilleaerFixed in Version => RR16Q4

Notes
(0089492)
simbu94   
2016-08-29 11:55   
Time reduced from 4s to 60ms
patch attached(Issue_33673.patch).
(0089715)
hgbot   
2016-09-02 23:40   
Repository: tools/automation/pi-mobile
Changeset: 2eda7fe863ca0a1dd54364cc683182d68308adbc
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Aug 24 10:06:08 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2eda7fe863ca0a1dd54364cc683182d68308adbc [^]

Verifies issue 33673: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33673_CashManagementApproval.java
---
(0090089)
hgbot   
2016-09-19 22:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 200182f3db29b079520aae7926bf97d57d8fb8eb
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Sep 19 08:34:39 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/200182f3db29b079520aae7926bf97d57d8fb8eb [^]

Fixed issue 33673: Modification to improve slow population of approvals popup

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---
(0090114)
guilleaer   
2016-09-20 15:39   
tested also in big customer