Openbravo Issue Tracking System - Retail Modules
View Issue Details
0033670Retail ModulesWeb POSpublic2016-08-10 10:352016-08-18 09:31
Orekaria 
ranjith_qualiantech_com 
normalmajoralways
closedfixed 
5
 
RR16Q4 
guilleaer
No
0033670: discounts.bypaymentmethod is creating wrong cashup data when overpayments are involved
The module org.openbravo.retail.discounts.bypaymentmethod is creating wrong cashup data when overpayments are involved
Install the org.openbravo.retail.discounts.bypaymentmethod
Create a receipt, add a product
Pay the ticket with more money than expected (receiving change)
Start a cashup
Verify that the amounts are wrong
No tags attached.
depends on backport 0033686RR16Q3.2 closed ranjith_qualiantech_com discounts.bypaymentmethod is creating wrong cashup data when overpayments are involved 
depends on backport 0033687RR16Q2.2 closed ranjith_qualiantech_com discounts.bypaymentmethod is creating wrong cashup data when overpayments are involved 
Issue History
2016-08-10 10:35OrekariaNew Issue
2016-08-10 10:35OrekariaAssigned To => ranjith_qualiantech_com
2016-08-10 10:35OrekariaTriggers an Emergency Pack => No
2016-08-10 11:03ranjith_qualiantech_comStatusnew => scheduled
2016-08-10 11:42hgbotCheckin
2016-08-10 11:42hgbotNote Added: 0088939
2016-08-11 11:23ranjith_qualiantech_comNote Added: 0088970
2016-08-11 11:23ranjith_qualiantech_comStatusscheduled => resolved
2016-08-11 11:23ranjith_qualiantech_comResolutionopen => fixed
2016-08-11 12:08OrekariaStatusresolved => new
2016-08-11 12:08OrekariaResolutionfixed => open
2016-08-11 12:08OrekariaStatusnew => scheduled
2016-08-11 12:09OrekariaStatusscheduled => resolved
2016-08-11 12:09OrekariaResolutionopen => fixed
2016-08-16 10:28OrekariaResolution time => 1472076000
2016-08-18 09:31guilleaerReview Assigned To => guilleaer
2016-08-18 09:31guilleaerStatusresolved => closed
2016-08-18 09:31guilleaerFixed in Version => RR16Q4

Notes
(0088939)
hgbot   
2016-08-10 11:42   
Repository: erp/pmods/org.openbravo.retail.discounts.bypaymentmethod
Changeset: 5fb31b505fa51b88b33e6b72e7204884276f2e87
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Aug 10 15:12:00 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bypaymentmethod/rev/5fb31b505fa51b88b33e6b72e7204884276f2e87 [^]

Related to issue 33670 : Discount should not be calculated for Negative payment

---
M web/org.openbravo.retail.discounts.bypaymentmethod/js/paymentmethod-discount.js
---
(0088970)
ranjith_qualiantech_com   
2016-08-11 11:23   
Discount should not be calculated for Negative Payment.
If the ticket has change/overpayment, while completing the ticket, negative payment will be created for change/overpayment. So for negative payment, discount should not be calculated