Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033663Retail ModulesStoreServerpublic2016-08-09 17:172016-11-20 13:42
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033663: Ping service fail method not called in case of multiple servers
DescriptionIn case of multiple servers (central and store) and the store server down the webpos automatically starts pinging the store server.

The ping service does not call the original fail method of the request if there are more than 1 servers ([1]). This results in the synchronizationHelper queue in WebPOS to fill ([2]) up as the request is not correctly finished.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/052f0d3e3b18/web/org.openbravo.mobile.core/source/data/ob-requestrouter.js#l513 [^]

[2]
OB.UTIL.SynchronizationHelper.getBusyQueueStringified()
"[{"busyProcessId":113,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":114,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":133,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":151,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":203,"msg":"serviceGET org.openbravo.mobile.core.login.ContextInformation"},{"busyProcessId":207,"msg":"calculateGross"},{"busyProcessId":208,"msg":"taxescalculation"}]"
Steps To ReproduceInstall multi-server, central and store
Login into store with webpos
do a product search
add a product, pay button is enabled
stop the store server
do a product search --> the webpos switches to central and starts pinging the store server
after the first ping the pay button becomes disable
Proposed SolutionAlso call the success/fail method in case of multiple servers
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034587RR16Q3.4 closed mtaal Ping service fail method not called in case of multiple servers 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-09 17:17mtaalNew Issue
2016-08-09 17:17mtaalAssigned To => mtaal
2016-08-09 17:17mtaalTriggers an Emergency Pack => No
2016-08-10 07:34mtaalDescription Updatedbug_revision_view_page.php?rev_id=12814#r12814
2016-08-10 07:46hgbotCheckin
2016-08-10 07:46hgbotNote Added: 0088932
2016-08-10 07:46hgbotStatusnew => resolved
2016-08-10 07:46hgbotResolutionopen => fixed
2016-08-10 07:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/15fb8809f9708c2464875dc39e8ad4935f81ad5e [^]
2016-08-16 10:29mtaalReview Assigned To => migueldejuana
2016-08-18 09:00migueldejuanaNote Added: 0089199
2016-08-18 09:00migueldejuanaStatusresolved => closed
2016-11-20 13:42mtaalNote Added: 0091672
2016-11-20 13:42mtaalStatusclosed => new
2016-11-20 13:42mtaalResolutionfixed => open
2016-11-20 13:42mtaalStatusnew => scheduled
2016-11-20 13:42mtaalNote Added: 0091673
2016-11-20 13:42mtaalStatusscheduled => resolved
2016-11-20 13:42mtaalFixed in Version => RR16Q4
2016-11-20 13:42mtaalResolutionopen => fixed
2016-11-20 13:42mtaalNote Added: 0091674
2016-11-20 13:42mtaalStatusresolved => closed

Notes
(0088932)
hgbot   
2016-08-10 07:46   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 15fb8809f9708c2464875dc39e8ad4935f81ad5e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Aug 10 07:46:37 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/15fb8809f9708c2464875dc39e8ad4935f81ad5e [^]

Fixes issue 33663: Ping service fail method not called in case of multiple servers
Make sure to call callback also in case of failure when having multi-server.
This removes the request from the synchronization stack kept by the synchronization
helper.

---
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
---
(0089199)
migueldejuana   
2016-08-18 09:00   
Tested and reviewed
(0091672)
mtaal   
2016-11-20 13:42   
changed to new to schedule backport
(0091673)
mtaal   
2016-11-20 13:42   
back to resolved
(0091674)
mtaal   
2016-11-20 13:42   
back to closed