Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033628Retail ModulesWeb POSpublic2016-08-05 07:332016-10-10 12:18
Reporterguillermogil 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033628: External OrderLoader improvements
Description* Since 16Q2 we have Services on WebPOS but External OrderLoader is not prepared to allow them, it should be needed an structure to link some products with others based on their search key, upc, etc...

* Multi UPC is not taken into account, it just looks for standard UPC.

* On OrderLoader the OrderLineId is mandatory, that also means that is mandatory for External OrderLoader which does not make sense. External OrderLoader should create them if they do not exists.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0034278RR17Q1 closed mtaal Add external order loader data resolver to multi-upc retail module 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-05 07:33guillermogilNew Issue
2016-08-05 07:33guillermogilAssigned To => mtaal
2016-08-05 07:33guillermogilOBNetwork customer => No
2016-08-05 07:33guillermogilTriggers an Emergency Pack => No
2016-08-15 22:51hgbotCheckin
2016-08-15 22:51hgbotNote Added: 0089103
2016-08-15 22:51hgbotStatusnew => resolved
2016-08-15 22:51hgbotResolutionopen => fixed
2016-08-15 22:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ebf194422e27ef7ea873a885a4c4c1b7d032de22 [^]
2016-08-15 22:53hgbotCheckin
2016-08-15 22:53hgbotNote Added: 0089104
2016-08-15 22:54hgbotCheckin
2016-08-15 22:54hgbotNote Added: 0089105
2016-08-16 04:25hgbotCheckin
2016-08-16 04:25hgbotNote Added: 0089111
2016-08-16 04:25hgbotCheckin
2016-08-16 04:25hgbotNote Added: 0089112
2016-08-29 15:36mtaalNote Added: 0089514
2016-08-29 15:36mtaalStatusresolved => new
2016-08-29 15:36mtaalResolutionfixed => open
2016-09-24 16:37mtaalStatusnew => scheduled
2016-09-24 16:37mtaalNote Added: 0090220
2016-09-24 16:37mtaalStatusscheduled => resolved
2016-09-24 16:37mtaalResolutionopen => fixed
2016-09-24 16:38mtaalReview Assigned To => Sandrahuguet
2016-09-24 16:38mtaalNote Deleted: 0089514
2016-09-24 16:39mtaalNote Added: 0090221
2016-09-30 08:20SandrahuguetNote Added: 0090399
2016-10-10 12:18SandrahuguetNote Added: 0090515
2016-10-10 12:18SandrahuguetStatusresolved => closed
2016-10-10 12:18SandrahuguetFixed in Version => RR16Q4
2016-10-23 12:58mtaalRelationship addedrelated to 0034278

Notes
(0089103)
hgbot   
2016-08-15 22:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ebf194422e27ef7ea873a885a4c4c1b7d032de22
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 22:51:15 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ebf194422e27ef7ea873a885a4c4c1b7d032de22 [^]

Fixes issue 33628: External OrderLoader improvements
Set id of orderLine if not present, handle order line relations for service parts, made
resolving references extendable by modules.

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0089104)
hgbot   
2016-08-15 22:53   
Repository: tools/automation/pi-mobile
Changeset: 0792effe49a1eba1c8dfc55d24448d8d7d695f64
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 22:53:04 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0792effe49a1eba1c8dfc55d24448d8d7d695f64 [^]

Related to issue 33628: External OrderLoader improvements
Added tests in quarantain for orderloader with services and orderlines without id
Added tests for multiupc resolving for the multiupc module
Placed the generic part of the order loader test in a base class to make it extendable
for the new test classes

---
M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/RetailOrderLoaderTest.java
A src-test/org/openbravo/test/mobile/quarantine/extmodules/MTA/multiupcorderloader/MultUPCOrderLoaderTest.java
A src-test/org/openbravo/test/mobile/quarantine/extmodules/MTA/multiupcorderloader/message-order-multi-upc.json
A src-test/org/openbravo/test/mobile/quarantine/extmodules/MTA/multiupcorderloader/message-order-multiupc-services.json
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/orderloader/RetailOrderLoaderServicesTest.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MTA/orderloader/message-order-services.json
A src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/BaseRetailOrderLoaderTest.java
---
(0089105)
hgbot   
2016-08-15 22:54   
Repository: erp/pmods/org.openbravo.multiupc
Changeset: 40e7a38608f81cf905806d225997d4a117cc989c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 22:54:10 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.multiupc/rev/40e7a38608f81cf905806d225997d4a117cc989c [^]

Related to issue 33628: External OrderLoader improvements
Support resolving of product references using multi-upc by implementing a dataresolver

---
A src/org/openbravo/multiupc/MultiUPCDataResolver.java
---
(0089111)
hgbot   
2016-08-16 04:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 28544ba2a4f19ba6104352763e2cf1d118a01689
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 16 04:24:40 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/28544ba2a4f19ba6104352763e2cf1d118a01689 [^]

Related to issue 33628: External OrderLoader improvements
Make the data resolving further extenable, let the default
data resolving also use the extension approach while still
maintaining backward compat

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0089112)
hgbot   
2016-08-16 04:25   
Repository: tools/automation/pi-mobile
Changeset: 579bc5402be7f7b66d1bdaa99764ab2501dac51e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 23:42:21 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/579bc5402be7f7b66d1bdaa99764ab2501dac51e [^]

Related to issue 33628: External OrderLoader improvements
Removed forgotten System.err

---
M src-test/org/openbravo/test/mobile/quarantine/extmodules/MTA/multiupcorderloader/MultUPCOrderLoaderTest.java
---
(0090220)
mtaal   
2016-09-24 16:37   
http://wiki.openbravo.com/wiki/Retail:Order_Loading_WebService#Extending_the_Order_Loader_with_your_custom_data_resolving_logic [^]
(0090221)
mtaal   
2016-09-24 16:39   
Note: backed out of commit to the multiupc module:
https://code.openbravo.com/erp/pmods/org.openbravo.multiupc/rev/0c180e92cf4a [^]

This to make the multi-upc not depend on 16Q4. The multi-upc resolver is now shown in the docs.
(0090399)
Sandrahuguet   
2016-09-30 08:20   
MultUPCOrderLoaderTest.java is failing
(0090515)
Sandrahuguet   
2016-10-10 12:18   
Reviewed and tested