Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033617Openbravo ERPA. Platformpublic2016-08-03 14:412016-12-16 18:39
ReporterNaroaIriarte 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToNaroaIriarte
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033617: The checkbox "Fully Audited" should not be visible in tables whose data origin are not "Table"
DescriptionThe "Fully Audited" checkbox should not be visible in tables whose data origin is not Table. For example in tables whose data origin is "HQL Query" it makes no sense.
Now it is possible to check that checkbox in HQL tables, but when executing the "Update Audit Trail Infraestructure" process, an error is shown.
Steps To ReproduceIt is needed to have the instance activated:

1- Log in the ERP as System Admin.
2- Go to "Tables and Columns" window.
3- Filter the "Data Origin" column and select "HQL Query".
4- Select, for example the "Aprm_Credit_To_Use" record and open it in form mode.
5- Check the "Fully Audited" checkbox and save the record.
6- Execute the "Update Audit Trail Infraestructure" process and realize that an error is get.
Proposed SolutionIt would be interesting not showing the "Fully Audited" field in every table, only in those whose data origin is "Table". This could be done with a display logic.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-03 14:41NaroaIriarteNew Issue
2016-08-03 14:41NaroaIriarteAssigned To => platform
2016-08-03 14:41NaroaIriarteOBNetwork customer => No
2016-08-03 14:41NaroaIriarteModules => Core
2016-08-03 14:41NaroaIriarteTriggers an Emergency Pack => No
2016-08-03 14:46NaroaIriarteSummaryThe checkbox "Fully Audited" should not be visible in tables which data origin are not "Table" => The checkbox "Fully Audited" should not be visible in tables whose data origin are not "Table"
2016-08-03 14:46NaroaIriarteDescription Updatedbug_revision_view_page.php?rev_id=12780#r12780
2016-12-01 12:39alostaleStatusnew => acknowledged
2016-12-15 08:50alostaleReview Assigned To => inigosanchez
2016-12-15 08:50alostaleAssigned Toplatform => alostale
2016-12-15 08:53hgbotCheckin
2016-12-15 08:53hgbotNote Added: 0092395
2016-12-15 08:53hgbotStatusacknowledged => resolved
2016-12-15 08:53hgbotResolutionopen => fixed
2016-12-15 08:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e2a5fb3292e8cde44268f677c0665a94c924ece7 [^]
2016-12-15 09:42alostaleReview Assigned Toinigosanchez => NaroaIriarte
2016-12-16 13:10NaroaIriarteNote Added: 0092488
2016-12-16 13:10NaroaIriarteStatusresolved => closed
2016-12-16 18:39hudsonbotCheckin
2016-12-16 18:39hudsonbotNote Added: 0092715

Notes
(0092395)
hgbot   
2016-12-15 08:53   
Repository: erp/devel/pi
Changeset: e2a5fb3292e8cde44268f677c0665a94c924ece7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Dec 15 08:53:09 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e2a5fb3292e8cde44268f677c0665a94c924ece7 [^]

fixed bug 33617: don't show "is fully audited" field for non db tables

  Fully audited field makes only sense for AD tables backed out by a physical DB
  table, though it was visible for all of them.

  Now it is hidden for those tables with origin type different to Table and for
  views.

  Additionally, if any non table origin is marked as audited, its audit trigger
  will not be generated, so that error is not thrown.

---
M src-db/database/model/postscript-Oracle.sql
M src-db/database/model/postscript-PostgreSql.sql
M src-db/database/sourcedata/AD_FIELD.xml
---
(0092488)
NaroaIriarte   
2016-12-16 13:10   
Code reviewed + tested with Postgres9.3 and Oracle12.1.
(0092715)
hudsonbot   
2016-12-16 18:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test