Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033590Retail ModulesWeb POSpublic2016-07-29 12:512016-08-19 10:28
ReporterOrekaria 
Assigned Tomario_castello 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q2.2Fixed in VersionRR16Q2.2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033590: Approval is taking too long
DescriptionWhen a clerk tries to delete a product line the POS asked for an approval. The manager approved this transaction via
approval window (This is a preference). After the manager approved the transaction, it takes lots of time to delete the product line. This happend in a ticket (standard) and in a devolution ticket.
This allows the clerk, to clic the button delete several times. Even when the POS is procesing the delete action
Steps To ReproduceIn a high volume context
Configure a user to require delete ticket approval
In the WebPOS
Create a ticket, add a product
Delete the ticket
The approval window will show up
Open the developer tools, network view
Add the credentials for the approval and click ok
Wait until the approval has been granted
Verify in the developer tools that the time taken is too long (see screenshot attached)


When a clerk tries to delete a product line the POS asked for an approval. The manager approved this transaction via
approval window (This is a preference). After the manager approved the transaction, it takes lots of time to delete the product line. This happend in a ticket (standard) and in a devolution ticket.
This allows the clerk, to clic the button delete several times. Even when the POS is procesing the delete action
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033568 closed ranjith_qualiantech_com Approval is taking too long 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-02 09:40OrekariaTypedefect => backport
2016-08-02 09:40OrekariaTarget Version => RR16Q2.2
2016-08-18 19:18hgbotCheckin
2016-08-18 19:18hgbotNote Added: 0089224
2016-08-18 19:19hgbotCheckin
2016-08-18 19:19hgbotNote Added: 0089226
2016-08-18 19:19hgbotStatusscheduled => resolved
2016-08-18 19:19hgbotResolutionopen => fixed
2016-08-18 19:19hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/ffeccc4b3aa05b14183cf91e8be9bf04e29bad12 [^]
2016-08-18 19:20mario_castelloAssigned ToRetail => mario_castello
2016-08-18 19:22mario_castelloNote Edited: 0089224bug_revision_view_page.php?bugnote_id=0089224#r12868
2016-08-19 10:28guilleaerReview Assigned To => guilleaer
2016-08-19 10:28guilleaerStatusresolved => closed
2016-08-19 10:28guilleaerFixed in Version => RR16Q2.2

Notes
(0089224)
hgbot   
2016-08-18 19:18   
(edited on: 2016-08-18 19:22)
Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: c6e632dcf5a8f752f7c8bc60c17cee351c8728ee
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jun 20 15:59:37 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/c6e632dcf5a8f752f7c8bc60c17cee351c8728ee [^]

Related to issue 0033590: Fixes for issue 33291. Changes in CheckApproval Query to remove duplicate

- groupby clause added to query inorder to remove duplicated

This changes are needed to apply the fix for this issue.

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---
(0089226)
hgbot   
2016-08-18 19:19   
Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: ffeccc4b3aa05b14183cf91e8be9bf04e29bad12
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Aug 03 11:09:26 2016 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/ffeccc4b3aa05b14183cf91e8be9bf04e29bad12 [^]

Fixes issue 0033590: Approval is taking too long.
*Replaced ad_isorgincluded(...) function with Organization natural tree list.
*Replaced multiple use of list() with List Object

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---