Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033587Retail ModulesWeb POSpublic2016-08-02 09:132016-10-10 19:02
Reporterairaceburu 
Assigned Tojorge-garcia 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033587: PreDeleteCurrentOrderHook is not called either from the cashup or from the logout
DescriptionPreDeleteCurrentOrderHook is not called either from the cashup or from the logout
Steps To ReproduceLogin
Place a breakpoint in PreDeleteCurrentOrderHook
Add one item to the receipt
Logout
Verify that the execution is not stopped
--
Login
Place a breakpoint in PreDeleteCurrentOrderHook
Add one item to the receipt
Click on Cashup in the main menu
Click on delete (the current order)
Verify that the execution is not stopped
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0034030RR16Q3.2 closed jorge-garcia PreDeleteCurrentOrderHook is not called either from the cashup or from the logout 
causes defect 0034203 closed mario_castello [SERQA 1940] The OBPOS_PreDeleteCurrentOrder hook is called when tickets loaded from backend are removed 
causes defect 0034227 closed jorge-garcia It is not possible to do a logout if you have a ticket with all lines deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-02 09:13airaceburuNew Issue
2016-08-02 09:13airaceburuAssigned To => Retail
2016-08-02 09:13airaceburuOBNetwork customer => Yes
2016-08-02 09:13airaceburuTriggers an Emergency Pack => No
2016-08-26 23:05mario_castelloAssigned ToRetail => mario_castello
2016-08-30 21:14mario_castelloStatusnew => acknowledged
2016-09-02 17:44mario_castelloStatusacknowledged => scheduled
2016-09-07 20:59hgbotCheckin
2016-09-07 20:59hgbotNote Added: 0089818
2016-09-07 20:59hgbotStatusscheduled => resolved
2016-09-07 20:59hgbotResolutionopen => fixed
2016-09-07 20:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5fc2b2fbce73b592f8b62cc977da7460f4fa503f [^]
2016-09-07 21:02mario_castelloNote Edited: 0089818bug_revision_view_page.php?bugnote_id=0089818#r13080
2016-09-07 21:17hgbotCheckin
2016-09-07 21:17hgbotNote Added: 0089819
2016-09-08 16:52guilleaerReview Assigned To => guilleaer
2016-09-08 16:52guilleaerStatusresolved => closed
2016-09-08 16:52guilleaerFixed in Version => RR16Q4
2016-09-15 13:27jorge-garciaNote Added: 0089981
2016-09-15 13:27jorge-garciaStatusclosed => new
2016-09-15 13:27jorge-garciaResolutionfixed => open
2016-09-15 13:27jorge-garciaFixed in VersionRR16Q4 =>
2016-09-15 13:31jorge-garciaStatusnew => scheduled
2016-09-15 13:31jorge-garciaAssigned Tomario_castello => jorge-garcia
2016-09-20 11:40hgbotCheckin
2016-09-20 11:40hgbotNote Added: 0090105
2016-09-20 11:40hgbotCheckin
2016-09-20 11:40hgbotNote Added: 0090106
2016-09-20 11:40hgbotCheckin
2016-09-20 11:40hgbotNote Added: 0090107
2016-09-20 11:40hgbotCheckin
2016-09-20 11:40hgbotNote Added: 0090108
2016-09-20 12:11marvintmStatusscheduled => acknowledged
2016-09-20 12:11marvintmStatusacknowledged => scheduled
2016-09-20 13:47jorge-garciaStatusscheduled => resolved
2016-09-20 13:47jorge-garciaResolutionopen => fixed
2016-10-10 19:02marvintmReview Assigned Toguilleaer => marvintm
2016-10-10 19:02marvintmStatusresolved => closed
2016-10-10 19:02marvintmFixed in Version => RR16Q4
2016-10-13 17:15aaroncaleroRelationship addedcauses 0034203
2016-10-20 19:14dmitry_mezentsevRelationship addedcauses 0034227

Notes
(0089818)
hgbot   
2016-09-07 20:59   
(edited on: 2016-09-07 21:02)
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5fc2b2fbce73b592f8b62cc977da7460f4fa503f
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Sep 07 07:56:34 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5fc2b2fbce73b592f8b62cc977da7460f4fa503f [^]

Fixed issue 33587: Moved the hook OBPOS_PreDeleteCurrentOrder from pointOfSales to order.
Now can be called the function deleteOrder when delete a receipt to execute the hook OBPOS_PreDeleteCurrentOrder.

Call function deleteOrder from cashup.
Call function deleteOrder when the user close the session.

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0089819)
hgbot   
2016-09-07 21:17   
Repository: tools/automation/pi-mobile
Changeset: 5e2698b597b6609bf94618076e9afce8c002ba53
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Sep 07 13:17:27 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/5e2698b597b6609bf94618076e9afce8c002ba53 [^]

Related to issue 33587: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/receipts/I33587_VerifyDeleteReceiptWithPreDeleteOrderHook.java
---
(0089981)
jorge-garcia   
2016-09-15 13:27   
The flows with the Preference 'WebPOS Save Remove Ticket' active are not going through the PreDeleteCurrentOrder hook.
(0090105)
hgbot   
2016-09-20 11:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: aefe9683c6dd07fb2eb0521b54960400126d8681
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 19 12:36:19 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/aefe9683c6dd07fb2eb0521b54960400126d8681 [^]

Related to issue 33587: PreDeleteCurrentOrderHook is not called either from
the cashup or from the logout

Centralize the functionality to delete a ticket keeping in mind all the flows
that use this functionality:

* Delete Tickets from the Point of sale Window
* Delete ticket from the CashUp Window
* Delete ticket in the logout

Also implemented the part where the user wants to save delete tickets from
the WebPOS.

---
M web/org.openbravo.retail.posterminal/js/closecash/view/tabpendingreceipts.js
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0090106)
hgbot   
2016-09-20 11:40   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 90ad72953c8f1bafc7797cfd3246be2f8fae19ea
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 20 09:02:05 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/90ad72953c8f1bafc7797cfd3246be2f8fae19ea [^]

Related to issue 33587: PreDeleteCurrentOrderHook is not called either from
the cashup or from the logout

Change the logout funtionality to close always the active session.

Fix JSlint errors of previous fixes.

---
M web/org.openbravo.retail.posterminal/js/login/model/login-model.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0090107)
hgbot   
2016-09-20 11:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 944a5e21a32531c10cacb32d7e5ca5239678dba3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 19 12:35:40 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/944a5e21a32531c10cacb32d7e5ca5239678dba3 [^]

Related to issue 33587: PreDeleteCurrentOrderHook is not called either from
the cashup or from the logout

Centralize the functionality to delete a ticket keeping in mind all the flows
that use this functionality:

* Delete Tickets from the Point of sale Window
* Delete ticket from the CashUp Window
* Delete ticket in the logout

Also implemented the part where the user wants to save delete tickets from
the WebPOS.

---
M web/org.openbravo.mobile.core/source/component/dialog/ob-logout.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0090108)
hgbot   
2016-09-20 11:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 49015c21ad6a053b0a9165e052de16f6aee52c0c
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 20 09:03:22 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/49015c21ad6a053b0a9165e052de16f6aee52c0c [^]

Related to issue 33587: PreDeleteCurrentOrderHook is not called either from
the cashup or from the logout

Change the lock funtionality to not close the session and don't delete the
pending orders.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---