Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033568Retail ModulesWeb POSpublic2016-07-29 12:512016-09-02 23:39
ReporterOrekaria 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned ToOrekaria
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033568: Approval is taking too long
DescriptionWhen a clerk tries to delete a product line the POS asked for an approval. The manager approved this transaction via
approval window (This is a preference). After the manager approved the transaction, it takes lots of time to delete the product line. This happend in a ticket (standard) and in a devolution ticket.
This allows the clerk, to clic the button delete several times. Even when the POS is procesing the delete action
Steps To ReproduceIn a high volume context
Configure a user to require delete ticket approval
In the WebPOS
Create a ticket, add a product
Delete the ticket
The approval window will show up
Open the developer tools, network view
Add the credentials for the approval and click ok
Wait until the approval has been granted
Verify in the developer tools that the time taken is too long (see screenshot attached)


When a clerk tries to delete a product line the POS asked for an approval. The manager approved this transaction via
approval window (This is a preference). After the manager approved the transaction, it takes lots of time to delete the product line. This happend in a ticket (standard) and in a devolution ticket.
This allows the clerk, to clic the button delete several times. Even when the POS is procesing the delete action
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0033589RR16Q3.1 closed Retail Approval is taking too long 
depends on backport 0033590RR16Q2.2 closed mario_castello Approval is taking too long 
caused by defect 0030673RR15Q4 closed mario_castello all approvals of supervisor should be loaded in terminal when one action is approval by this supervisor 
related to defect 0033673 closed mario_castello slow population of approvals popup 
Attached Filespng approvalTakingLongTime.png (250,553) 2016-07-29 12:53
https://issues.openbravo.com/file_download.php?file_id=9657&type=bug
png

patch Issue_33568.patch (3,725) 2016-08-02 12:05
https://issues.openbravo.com/file_download.php?file_id=9666&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-29 12:51OrekariaNew Issue
2016-07-29 12:51OrekariaAssigned To => Retail
2016-07-29 12:51OrekariaTriggers an Emergency Pack => No
2016-07-29 12:52OrekariaResolution time => 1470261600
2016-07-29 12:53OrekariaFile Added: approvalTakingLongTime.png
2016-07-29 12:53OrekariaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=12754#r12754
2016-08-02 08:19simbu94File Added: Issue_33568.patch
2016-08-02 09:40OrekariaStatusnew => scheduled
2016-08-02 09:41OrekariaStatusscheduled => feedback
2016-08-02 09:41OrekariaStatusfeedback => new
2016-08-02 12:05simbu94File Deleted: Issue_33568.patch
2016-08-02 12:05simbu94File Added: Issue_33568.patch
2016-08-02 14:25ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-08-02 14:25ranjith_qualiantech_comStatusnew => scheduled
2016-08-03 07:39hgbotCheckin
2016-08-03 07:39hgbotNote Added: 0088763
2016-08-03 07:39hgbotStatusscheduled => resolved
2016-08-03 07:39hgbotResolutionopen => fixed
2016-08-03 07:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7540df082f6e24f0c18b5aaacedead195004f83 [^]
2016-08-08 10:07migueldejuanaReview Assigned To => migueldejuana
2016-08-08 10:07migueldejuanaNote Added: 0088876
2016-08-08 10:07migueldejuanaStatusresolved => closed
2016-08-09 21:55OrekariaRelationship addedcaused by 0030673
2016-08-10 10:56alostaleRelationship addedrelated to 0033673
2016-08-16 20:22hgbotCheckin
2016-08-16 20:22hgbotNote Added: 0089152
2016-08-16 20:22hgbotStatusclosed => resolved
2016-08-16 20:22hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7540df082f6e24f0c18b5aaacedead195004f83 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal/rev/6d3755353868344006b47d954ddc0f61ba874cdb [^]
2016-08-16 20:53mario_castelloNote Deleted: 0089152
2016-08-18 12:17OrekariaReview Assigned Tomigueldejuana => Orekaria
2016-08-18 12:17OrekariaStatusresolved => closed
2016-08-18 12:17OrekariaFixed in Version => RR16Q4
2016-08-26 15:31OrekariaRelationship addedcauses 0033826
2016-08-29 13:21simbu94Relationship deletedcauses 0033826
2016-09-02 23:39hgbotCheckin
2016-09-02 23:39hgbotNote Added: 0089714

Notes
(0088763)
hgbot   
2016-08-03 07:39   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e7540df082f6e24f0c18b5aaacedead195004f83
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Aug 03 11:09:26 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e7540df082f6e24f0c18b5aaacedead195004f83 [^]

Fixes issue 33568 : Approval is taking too long.
*Replaced ad_isorgincluded(...) function with Organization natural tree list.
*Replaced multiple use of list() with List Object

---
M src/org/openbravo/retail/posterminal/utility/CheckApproval.java
---
(0088876)
migueldejuana   
2016-08-08 10:07   
Tested and reviewed
(0089714)
hgbot   
2016-09-02 23:39   
Repository: tools/automation/pi-mobile
Changeset: 88d818673aadfc9438ead7808e0941fb3965d6e5
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Aug 24 09:29:20 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/88d818673aadfc9438ead7808e0941fb3965d6e5 [^]

Verifies issue 33568: Added automated test

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33568_DeleteLinesApproval.java
---