Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033565Openbravo ERPA. Platformpublic2016-07-29 10:482016-12-16 18:37
Reporteralostale 
Assigned Tocaristu 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR17Q1Fixed in Version3.0PR17Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033565: ability to disable linked items section
DescriptionLinked items functionality tries to find any record with a FK linked to current one.

This, in some cases, requires many DB queries which, specially with big volumes of data, can be very heavy.

There should be an option to disable it at system or at concrete window level.

Project Link: http://wiki.openbravo.com/wiki/Projects:Deactivable_Linked_Items_Section [^]
Steps To ReproduceIn an environment with few million invoices/orders/whatever made by a concrete partner, open linked items section for that Business Partner. Check it is slow.
Proposed Solution
Additional Information
TagsPerformance
Relationships
has duplicate feature request 0024314 closed platform Add the possibility to hide the linked items section per window 
related to defect 0033843 closed NaroaIriarte useless heavy queries in linked items 
related to defect 0035131 closed platform [RR17Q1][StoreServer][HighVol] Linked Items section never finishes its loading process 
Attached Filesdiff issue33565.diff (5,865) 2016-08-10 14:31
https://issues.openbravo.com/file_download.php?file_id=9708&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-29 10:48alostaleNew Issue
2016-07-29 10:48alostaleAssigned To => platform
2016-07-29 10:48alostaleOBNetwork customer => No
2016-07-29 10:48alostaleModules => Core
2016-07-29 10:48alostaleTriggers an Emergency Pack => No
2016-07-29 10:50alostaleSummarycapability to disable linked items section => ability to disable linked items section
2016-07-29 10:50alostaleStatusnew => acknowledged
2016-07-29 12:08shuehnerIssue Monitored: shuehner
2016-08-10 09:16caristuStatusacknowledged => scheduled
2016-08-10 09:16caristuAssigned Toplatform => caristu
2016-08-10 09:17caristuTarget Version3.0PR16Q4 =>
2016-08-10 09:18caristuFile Added: issue33565.diff
2016-08-10 14:28caristuFile Deleted: issue33565.diff
2016-08-10 14:31caristuFile Added: issue33565.diff
2016-08-29 11:39caristuTarget Version => 3.0PR17Q1
2016-08-29 11:40caristuTag Attached: Performance
2016-08-29 15:07caristuDescription Updatedbug_revision_view_page.php?rev_id=12947#r12947
2016-08-29 15:08caristuDescription Updatedbug_revision_view_page.php?rev_id=12948#r12948
2016-08-29 17:03alostaleRelationship addedrelated to 0033843
2016-09-26 09:45caristuRelationship addedhas duplicate 0024314
2016-09-26 09:54pradeepvarmaIssue Monitored: pradeepvarma
2016-10-14 15:00hgbotCheckin
2016-10-14 15:00hgbotNote Added: 0090588
2016-10-14 15:00hgbotStatusscheduled => resolved
2016-10-14 15:00hgbotResolutionopen => fixed
2016-10-14 15:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f798171e1a8f592862cd888a0f117e00f43723b3 [^]
2016-10-17 09:15hgbotCheckin
2016-10-17 09:15hgbotNote Added: 0090608
2016-10-28 09:18alostaleReview Assigned To => alostale
2016-10-28 09:18alostaleNote Added: 0090975
2016-10-28 09:18alostaleStatusresolved => closed
2016-10-28 09:19alostaleFixed in Version => 3.0PR17Q1
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092508
2016-12-16 18:37hudsonbotCheckin
2016-12-16 18:37hudsonbotNote Added: 0092512
2017-02-10 09:15alostaleRelationship addedrelated to 0035131

Notes
(0090588)
hgbot   
2016-10-14 15:00   
Repository: erp/devel/pi
Changeset: f798171e1a8f592862cd888a0f117e00f43723b3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Oct 14 14:55:13 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f798171e1a8f592862cd888a0f117e00f43723b3 [^]

fixes issue 33565: ability to disable linked items section

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentReadOnlyLogicsHandler.java
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/HeartBeatPopupActionHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/CoreAttachImplementation.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/process/BaseProcessActionHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/BaseDataSourceService.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DefaultDataSourceService.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/DefaultJsonDataService.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorDataSourceFilter.java
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-test/src/org/openbravo/test/datasource/TestAllowUnpagedDatasourcePreference.java
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/base/secureApp/LoginUtils.java
M src/org/openbravo/costing/CostingAlgorithmAdjustmentImp.java
M src/org/openbravo/costing/CostingBackground.java
M src/org/openbravo/costing/CostingServer.java
M src/org/openbravo/erpCommon/ad_forms/ModuleManagement.java
M src/org/openbravo/erpCommon/ad_reports/ReportInvoiceCustomerDimensionalAnalysesJR.java
M src/org/openbravo/erpCommon/ad_reports/ReportValuationStock.java
M src/org/openbravo/erpCommon/businessUtility/Preferences.java
M src/org/openbravo/erpCommon/businessUtility/PrinterReports.java
M src/org/openbravo/erpCommon/utility/UsedByLink.java
M src/org/openbravo/erpCommon/utility/Utility.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
M src/org/openbravo/event/OrderEventHandler.java
---
(0090608)
hgbot   
2016-10-17 09:15   
Repository: erp/devel/pi
Changeset: 5216f55ce73aa5b5828fef5e74b39a01a0f9dfc3
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Oct 17 09:10:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5216f55ce73aa5b5828fef5e74b39a01a0f9dfc3 [^]

related to issue 33565: retrieve the window id from the standard window

For child tabs this.view.windowId is undefined. For this reason, we retrieve the windowId using the standardWindow property of the view. Thus, we ensure that the window id is always retrieved properly

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0090975)
alostale   
2016-10-28 09:18   
Code reviewed as tested in project scope: https://docs.google.com/spreadsheets/d/1mgedL0xdcn22PYKmmcz_W2Er1PsPdEWhpJmqN2cTF7k/edit#gid=0 [^]
(0092508)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test
(0092512)
hudsonbot   
2016-12-16 18:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test