Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033561Openbravo ERPZ. Otherspublic2016-07-27 13:482016-08-26 13:34
Reporterngarcia 
Assigned Tomarkmm82 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR16Q2.2Fixed in Version3.0PR16Q2.2 
Merge Request Status
Review Assigned Toaferraz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2015-11-23
Regression introduced in release3.0PR16Q1
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/336cbe497bec883b0d50b8fc3a248cf3227cfcbb [^]
Triggers an Emergency PackYes
Summary0033561: Cannot void an invoice if the business partner does not have a default financial account defined
DescriptionCannot void an invoice if the business partner does not have a default financial account defined and the payment method is defined as default in a financial account that does not belong to the natural tree of the invoice's organization
Steps To ReproduceAs group admin role:
   Create a new Payment Method:
      Organization: *
      Payment In Allowed: Y
      Receive Payments in Multiple Currencies: Y
  Add it to 'Bank - Account 1' financial account and set it as default
  Add it to 'Cuenta de Banco' financial account (Default = 'N')
  Remove the Financial Account to 'Hoteles Buenas Noches, S.A.' customer (Business Partner - Customer tab)
  Create a Sales Invoice with that business partner and payment method
  Complete it
  Try to void it and check the following error message is shown:
     It does not exist any Financial Account available for this Payment Method
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0033550 closed markmm82 Cannot void an invoice if the business partner does not have a default financial account defined 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-07-28 17:59markmm82Typedefect => backport
2016-07-28 17:59markmm82Target Version => 3.0PR16Q2.2
2016-08-05 09:46hgbotCheckin
2016-08-05 09:46hgbotNote Added: 0088829
2016-08-05 09:46hgbotStatusscheduled => resolved
2016-08-05 09:46hgbotResolutionopen => fixed
2016-08-05 09:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q2.2/rev/f9264ee5a010fac3042feccf3193e94b241ccd20 [^]
2016-08-05 09:46hgbotCheckin
2016-08-05 09:46hgbotNote Added: 0088830
2016-08-05 09:55aferrazReview Assigned To => aferraz
2016-08-05 09:55aferrazNote Added: 0088834
2016-08-05 09:55aferrazStatusresolved => closed
2016-08-05 09:55aferrazFixed in Version => 3.0PR16Q2.2
2016-08-26 13:20hgbotCheckin
2016-08-26 13:20hgbotNote Added: 0089450
2016-08-26 13:20hgbotStatusclosed => resolved
2016-08-26 13:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/backports/3.0PR16Q2.2/rev/f9264ee5a010fac3042feccf3193e94b241ccd20 [^] => http://code.openbravo.com/erp/devel/pi/rev/f9264ee5a010fac3042feccf3193e94b241ccd20 [^]
2016-08-26 13:20hgbotCheckin
2016-08-26 13:20hgbotNote Added: 0089451
2016-08-26 13:34priyamNote Added: 0089460
2016-08-26 13:34priyamStatusresolved => closed

Notes
(0088829)
hgbot   
2016-08-05 09:46   
Repository: erp/backports/3.0PR16Q2.2
Changeset: f9264ee5a010fac3042feccf3193e94b241ccd20
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Aug 04 09:52:25 2016 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2.2/rev/f9264ee5a010fac3042feccf3193e94b241ccd20 [^]

Fixes issue 33561: Error voiding an invoice if bp doesn't have default account

Method used to get the default financial account (getFinancialAccountPaymentMethod) was not taking into account the natural tree of the organization of document being processed, always was ordering by "default" account and when the query returns more than one results, if the first record's account does not belong to the natural tree of the entity's organization (in this case invoice's organization) validation was failing and an error message was shown.

To avoid it, was overwritten the getFinancialAccountPaymentMethod method of the FIN_Utility class to also filtering by financial accounts belonging to the natural tree of the entity's organization. Was necessary to adapt other classes using this method to work correctly.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0088830)
hgbot   
2016-08-05 09:46   
Repository: erp/backports/3.0PR16Q2.2
Changeset: 9b6e3fc57751ee2ca720f2e66287abeffdecef7a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Aug 04 16:07:56 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q2.2/rev/9b6e3fc57751ee2ca720f2e66287abeffdecef7a [^]

Related to issue 33561: Code review improvements

Remove unused OrganizationStructureProvider.
Remove duplicated method.
Remove orgId1 parameter as it can be calculated inside the query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0088834)
aferraz   
2016-08-05 09:55   
Code review + Testing OK
(0089450)
hgbot   
2016-08-26 13:20   
Repository: erp/devel/pi
Changeset: f9264ee5a010fac3042feccf3193e94b241ccd20
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Aug 04 09:52:25 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/f9264ee5a010fac3042feccf3193e94b241ccd20 [^]

Fixes issue 33561: Error voiding an invoice if bp doesn't have default account

Method used to get the default financial account (getFinancialAccountPaymentMethod) was not taking into account the natural tree of the organization of document being processed, always was ordering by "default" account and when the query returns more than one results, if the first record's account does not belong to the natural tree of the entity's organization (in this case invoice's organization) validation was failing and an error message was shown.

To avoid it, was overwritten the getFinancialAccountPaymentMethod method of the FIN_Utility class to also filtering by financial accounts belonging to the natural tree of the entity's organization. Was necessary to adapt other classes using this method to work correctly.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0089451)
hgbot   
2016-08-26 13:20   
Repository: erp/devel/pi
Changeset: 9b6e3fc57751ee2ca720f2e66287abeffdecef7a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Aug 04 16:07:56 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9b6e3fc57751ee2ca720f2e66287abeffdecef7a [^]

Related to issue 33561: Code review improvements

Remove unused OrganizationStructureProvider.
Remove duplicated method.
Remove orgId1 parameter as it can be calculated inside the query.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/filterexpression/AddPaymentDefaultValuesHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0089460)
priyam   
2016-08-26 13:34   
Issues updated as int-promote updated pi with the tag changes of release 16Q2.2 before we merge the tag from main to pi. So the code hg-to-issues plugin updated the issues.

So closing the issue again