Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033527Retail ModulesWeb POSpublic2016-07-22 09:302016-08-01 00:14
Reporterguillermogil 
Assigned Toshivum039 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033527: Save Delete Ticket functionality does not work if you delete an invoice
DescriptionSave Delete Ticket functionality does not work if you delete an invoice.
It goes to errors while importing window while trying to create the invoice

Caused by: java.lang.ArithmeticException: / by zero
    at java.math.BigDecimal.divideAndRound(BigDecimal.java:1424)
    at java.math.BigDecimal.divide(BigDecimal.java:1398)
    at java.math.BigDecimal.divide(BigDecimal.java:1513)
    at org.openbravo.retail.posterminal.OrderLoader.createInvoiceLine(OrderLoader.java:668)
    at org.openbravo.retail.posterminal.OrderLoader.createInvoiceLines(OrderLoader.java:834)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:383)
Steps To Reproduce* Go to the ERP / Preference Window
* Create WEBPOS Save Removed Tickets with value Y
* Login on WebPOS
* Open the menu and select Invoice this receipt
* Add a product
* Remove the ticket
* Go to the ERP / Errors While Importing

You will see there a divide by 0 error
Proposed SolutionDo not Invoice deleted tickets.
See attached diff
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff deleteline.diff (694) 2016-07-22 09:30
https://issues.openbravo.com/file_download.php?file_id=9648&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-22 09:30guillermogilNew Issue
2016-07-22 09:30guillermogilAssigned To => Retail
2016-07-22 09:30guillermogilFile Added: deleteline.diff
2016-07-22 09:30guillermogilResolution time => 1469570400
2016-07-22 09:30guillermogilTriggers an Emergency Pack => No
2016-07-22 09:31guillermogilSummaryDelete Line functionality does not work if you delete an invoice => Save Delete Ticket functionality does not work if you delete an invoice
2016-07-22 09:31guillermogilDescription Updatedbug_revision_view_page.php?rev_id=12731#r12731
2016-07-26 13:18ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-07-26 13:18ranjith_qualiantech_comStatusnew => scheduled
2016-07-26 13:41ranjith_qualiantech_comAssigned Toranjith_qualiantech_com => shivum039
2016-07-28 10:16hgbotCheckin
2016-07-28 10:16hgbotNote Added: 0088686
2016-07-28 10:16hgbotStatusscheduled => resolved
2016-07-28 10:16hgbotResolutionopen => fixed
2016-07-28 10:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/89c3e6d2156cb5d24cf988eb185a035591435c53 [^]
2016-07-28 10:16hgbotCheckin
2016-07-28 10:16hgbotNote Added: 0088687
2016-08-01 00:14marvintmReview Assigned To => marvintm
2016-08-01 00:14marvintmStatusresolved => closed

Notes
(0088686)
hgbot   
2016-07-28 10:16   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 89c3e6d2156cb5d24cf988eb185a035591435c53
Author: Shivanand Madiwalar <shivanand.madiwalar <at> promantia.com>
Date: Thu Jul 28 13:45:36 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/89c3e6d2156cb5d24cf988eb185a035591435c53 [^]

FIxes Issue 33527 :The Proposed Approach (Attached patch) Applied To Verify "Delete Save Ticket " On Invoice .

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0088687)
hgbot   
2016-07-28 10:16   
Repository: tools/automation/pi-mobile
Changeset: 6b8fcd570a1f52fc8847d9019ab044276f55009b
Author: Shivanand Madiwalar <shivanand.madiwalar <at> promantia.com>
Date: Thu Jul 28 13:45:29 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6b8fcd570a1f52fc8847d9019ab044276f55009b [^]

Verifies issue 33527 :The Automated Test To Verify "Delete Save Ticket" on Invoice Action .

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33527_SaveDeleteTicketOnInvoice.java
---