Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033498Retail ModulesWeb POSpublic2016-07-19 16:592016-08-08 10:13
Reporteradrianromero 
Assigned Tomario_castello 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033498: [SER-QA 1433] Discount lines cannot be selected or unselected tapping on the check mark of the line
DescriptionWhen applying a discretionary discount, lines can be selected/unselected tapping on the line, but if the user taps on the check icon the line is not selected/unselected

This behaviour is weird for the user that expects to select/unselect discount lines tapping on the check
Steps To ReproduceCreate a new receipt
Add few lines
Tab on the button "Discount" all lines will show a "check" icon on the left to apply the discount

Notice that discount lines can be selected/unselected only tapping on the body of the line, but tapping on the check icon the line selection does not change.
Proposed Solution
Additional Information
TagsSER QA 1433, SER-QA
Relationships
Attached Filespng Captura de pantalla de 2016-07-19 16:51:58.png (189,210) 2016-07-19 17:00
https://issues.openbravo.com/file_download.php?file_id=9633&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2016-07-19 16:59adrianromeroNew Issue
2016-07-19 16:59adrianromeroAssigned To => Retail
2016-07-19 16:59adrianromeroOBNetwork customer => Yes
2016-07-19 16:59adrianromeroResolution time => 1469484000
2016-07-19 16:59adrianromeroTriggers an Emergency Pack => No
2016-07-19 17:00adrianromeroFile Added: Captura de pantalla de 2016-07-19 16:51:58.png
2016-07-19 17:08mrecasensTag Attached: SER QA 1433
2016-07-19 17:09mrecasensReproducibilityhave not tried => always
2016-07-19 17:18VictorVillarSummaryDiscount lines cannot be selected or unselected tapping on the check mark of the line => [SER-QA 1433] Discount lines cannot be selected or unselected tapping on the check mark of the line
2016-07-19 17:18VictorVillarTag Attached: SER-QA
2016-07-19 17:46marvintmStatusnew => acknowledged
2016-07-19 17:46VictorVillarResolution time1469484000 => 1470088800
2016-07-19 17:46VictorVillarStatusacknowledged => new
2016-07-19 17:47marvintmStatusnew => acknowledged
2016-07-20 15:43mario_castelloAssigned ToRetail => mario_castello
2016-07-20 15:43mario_castelloStatusacknowledged => scheduled
2016-07-28 16:49hgbotCheckin
2016-07-28 16:49hgbotNote Added: 0088692
2016-07-28 16:49hgbotStatusscheduled => resolved
2016-07-28 16:49hgbotResolutionopen => fixed
2016-07-28 16:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a4e4acd38c8e8eaa35f6cff1780d756f74bd1d3 [^]
2016-07-28 16:49hgbotCheckin
2016-07-28 16:49hgbotNote Added: 0088693
2016-07-28 16:50hgbotCheckin
2016-07-28 16:50hgbotNote Added: 0088694
2016-08-08 10:13migueldejuanaReview Assigned To => migueldejuana
2016-08-08 10:13migueldejuanaNote Added: 0088877
2016-08-08 10:13migueldejuanaStatusresolved => closed

Notes
(0088692)
hgbot   
2016-07-28 16:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0a4e4acd38c8e8eaa35f6cff1780d756f74bd1d3
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Jul 25 10:11:04 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0a4e4acd38c8e8eaa35f6cff1780d756f74bd1d3 [^]

Fixed issue 33498: Call the event check in tap function for checkBoxColumns components to check or uncheck this

---
M web/org.openbravo.retail.posterminal/js/components/renderorderline.js
---
(0088693)
hgbot   
2016-07-28 16:49   
Repository: tools/automation/pi-mobile
Changeset: 75a2364565d156200fdf9845e5582f3ca119cdda
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Jul 28 08:48:27 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/75a2364565d156200fdf9845e5582f3ca119cdda [^]

Related to issue 33498: Added testidpack and fixed test afected by this changes

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I30176_UndefinedDiscountWhenReturning.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/multipricelists/I32217_MPLDiscretionaryPromotions.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32277_DeleteDiscretionaryDiscount.java
---
(0088694)
hgbot   
2016-07-28 16:50   
Repository: tools/automation/pi-mobile
Changeset: df09c832195abc2bcc63dd4afa8c837322b81d64
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Jul 28 08:50:27 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/df09c832195abc2bcc63dd4afa8c837322b81d64 [^]

Related to issue 33498: Added automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/discountsandpromotions/I33498_ReceiptSelectCheckboxDiscount.java
---
(0088877)
migueldejuana   
2016-08-08 10:13   
Tested and reviewed